Tests (#2)

Added a few simple tests to ensure minification was working and options are correctly set for Closure Compiler given Rollup configuration.

Author: kristoferbaxter

dist/index.js

@@ -1,6 +1,6 @@
 {
   "name": "@ampproject/rollup-plugin-closure-compiler",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "Rollup + Google Closure Compiler",
   "main": "dist/index.js",
   "repository": {
@@ -17,6 +17,7 @@
   ],
   "license": "Apache-2.0",
   "scripts": {
+    "pretest": "yarn build",
     "test": "ava test/*.js",
     "build": "rimraf dist && tsc -p tsconfig.json"
   },
@@ -32,7 +33,7 @@
     "lint-staged": "^7.2.0",
     "prettier": "^1.13.5",
     "rimraf": "^2.6.2",
-    "rollup": "^0.61.1",
+    "rollup": "^0.62.0",
     "sourcemap-validator": "^1.1.0",
     "typescript": "^2.9.2"
   },
@@ -44,7 +45,8 @@
   },
   "husky": {
     "hooks": {
-      "pre-commit": "lint-staged"
+      "pre-commit": "lint-staged",
+      "pre-push": "yarn test"
     }
   }
 }

dist/index.js.map

@@ -19,7 +19,7 @@ import { sync } from 'temp-write';
 import { readFileSync } from 'fs';
 import { OutputOptions, RawSourceMap, Plugin } from 'rollup';
 
-function defaultCompileOptions(outputOptions: OutputOptions): CompileOptions {
+export function defaultCompileOptions(outputOptions: OutputOptions): CompileOptions {
   // Defaults for Rollup Projects are slightly different than Closure Compiler defaults.
   // - Users of Rollup tend to transpile their code before handing it to a minifier,
   // so no transpile is default.
@@ -77,10 +77,7 @@ export default function closureCompiler(compileOptions: CompileOptions = {}): Pl
           return { code: stdOut, map: sourceMap };
         },
         (error: Error) => {
-          // The TypeScript definition for Rollup is not correct.
-          // `this` has context exposing helper methods like 'error'.
-          // See: https://github.com/rollup/rollup/wiki/Plugins#plugin-context
-          this.error(error);
+          throw error;
         },
       );
     },

package.json

@@ -26,3 +26,17 @@ class Foo {
 
 const x = new Foo('bar');
 console.log(x.baz);
+
+class Bar extends Foo {
+  constructor(happy) {
+    super('bar');
+    this.happy = happy;
+  }
+
+  get happyness() {
+    return this.happy ? 'quite happy' : 'sad';
+  }
+}
+
+const barInstance = new Bar(true);
+console.log(barInstance.baz, barInstance.happyness);

src/index.ts

@@ -0,0 +1,21 @@
+/**
+ * Copyright 2018 The AMP HTML Authors. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS-IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+function greeting(name) {
+  return 'hello ' + name;
+}
+
+console.log(greeting('superuser'));

test/input/es2015.js

@@ -0,0 +1,55 @@
+/**
+ * Copyright 2018 The AMP HTML Authors. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS-IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import test from 'ava';
+import compiler from '../dist/index';
+import { rollup } from 'rollup';
+import { readFileSync } from 'fs';
+import { join } from 'path';
+
+test('es2015 does minify', async t => {
+  const source = readFileSync(join('test/input/es2015.js'), 'utf8');
+  const compilerBundle = await rollup({
+    input: 'test/input/es2015.js',
+    plugins: [
+      compiler(),
+    ],
+  });
+
+  const compilerResults = await compilerBundle.generate({
+    format: 'es',
+    sourcemap: true,
+  });
+
+  t.truthy(compilerResults.code.length < source.length);
+});
+
+test('es5 does minify', async t => {
+  const source = readFileSync(join('test/input/es5.js'), 'utf8');
+  const compilerBundle = await rollup({
+    input: 'test/input/es5.js',
+    plugins: [
+      compiler(),
+    ],
+  });
+
+  const compilerResults = await compilerBundle.generate({
+    format: 'es',
+    sourcemap: true,
+  });
+
+  t.truthy(compilerResults.code.length < source.length);
+});

test/input/es5.js

@@ -0,0 +1,48 @@
+/**
+ * Copyright 2018 The AMP HTML Authors. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS-IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import test from 'ava';
+import {defaultCompileOptions} from '../dist/index';
+import { readFileSync } from 'fs';
+
+test('with no rollup configuration defaults are valid', t => {
+  const options = defaultCompileOptions({});
+  t.deepEqual(options, {
+    language_out: 'NO_TRANSPILE',
+    assume_function_wrapper: false,
+    warning_level: 'QUIET',
+  });
+});
+
+test('when rollup configuration specifies format iife with a name, an extern is generated', t => {
+  const options = defaultCompileOptions({
+    format: 'iife',
+    name: 'Wrapper'
+  });
+
+  t.not(options.externs, undefined);
+
+  const externs = readFileSync(options.externs, 'utf8');
+  t.is(externs, `function Wrapper(){}`);
+});
+
+test('when rollup configuration specifies format es, assume_function_wrapper is true', t => {
+  const options = defaultCompileOptions({
+    format: 'es',
+  });
+
+  t.true(options.assume_function_wrapper);
+});