Remove ArrowFunction Transform since Closure Compiler has fixed their bug with single argument arrow funcitons

kristoferbaxter · kristoferbaxter · commit 9d966c264be7 · 2019-12-19T17:04:22.000-08:00
diff --git a/src/transformers/arrow-function.ts b/src/transformers/arrow-function.ts
diff --git a/src/transforms.ts b/src/transforms.ts
@@ -22,7 +22,6 @@ import ExportTransform from './transformers/exports';
 import ImportTransform from './transformers/imports';
 import StrictTransform from './transformers/strict';
 import ConstTransform from './transformers/const';
-import ArrowFunctionTransform from './transformers/arrow-function';
 import { logSource } from './debug';
 
 /**
@@ -42,7 +41,6 @@ export const createTransforms = (
     new StrictTransform(context, options),
     new ExportTransform(context, options),
     new ImportTransform(context, options),
-    new ArrowFunctionTransform(context, options),
   ];
 };
 
diff --git a/test/arrow-function/fixtures/multiple-arguments.esm.advanced.js b/test/arrow-function/fixtures/multiple-arguments.esm.advanced.js
@@ -0,0 +1 @@
+var multipleArguments=(a,b)=>console.log(a,b);export{multipleArguments};
diff --git a/test/arrow-function/fixtures/multiple-arguments.esm.default.js b/test/arrow-function/fixtures/multiple-arguments.esm.default.js
@@ -0,0 +1 @@
+var multipleArguments=(a,b)=>console.log(a,b);export{multipleArguments};
diff --git a/test/arrow-function/fixtures/multiple-arguments.esm.es5.js b/test/arrow-function/fixtures/multiple-arguments.esm.es5.js
@@ -0,0 +1 @@
+var multipleArguments=function(a,b){return console.log(a,b)};export{multipleArguments};
diff --git a/test/arrow-function/fixtures/multiple-arguments.js b/test/arrow-function/fixtures/multiple-arguments.js
@@ -0,0 +1 @@
+export const multipleArguments = (ar, ar2) => console.log(ar, ar2);
diff --git a/test/arrow-function/fixtures/single-argument.esm.advanced.js b/test/arrow-function/fixtures/single-argument.esm.advanced.js
@@ -0,0 +1 @@
+var singleArgument=a=>console.log(a);export{singleArgument};
diff --git a/test/arrow-function/fixtures/single-argument.esm.default.js b/test/arrow-function/fixtures/single-argument.esm.default.js
@@ -0,0 +1 @@
+var singleArgument=a=>console.log(a);export{singleArgument};
diff --git a/test/arrow-function/fixtures/single-argument.esm.es5.js b/test/arrow-function/fixtures/single-argument.esm.es5.js
@@ -0,0 +1 @@
+var singleArgument=function(a){return console.log(a)};export{singleArgument};
diff --git a/test/arrow-function/fixtures/single-argument.js b/test/arrow-function/fixtures/single-argument.js
@@ -0,0 +1 @@
+export const singleArgument = (ar) => console.log(ar);
diff --git a/test/arrow-function/multiple-arguments.test.js b/test/arrow-function/multiple-arguments.test.js
@@ -0,0 +1,19 @@
+/**
+ * Copyright 2019 The AMP HTML Authors. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS-IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import {generator} from '../generator';
+
+generator('arrow-function', 'multiple-arguments');
diff --git a/test/arrow-function/single-argument.test.js b/test/arrow-function/single-argument.test.js
@@ -0,0 +1,19 @@
+/**
+ * Copyright 2019 The AMP HTML Authors. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS-IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import {generator} from '../generator';
+
+generator('arrow-function', 'single-argument');

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+var multipleArguments=(a,b)=>console.log(a,b);export{multipleArguments};`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+var multipleArguments=function(a,b){return console.log(a,b)};export{multipleArguments};`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+export const multipleArguments = (ar, ar2) => console.log(ar, ar2);`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+var singleArgument=a=>console.log(a);export{singleArgument};`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+var singleArgument=function(a){return console.log(a)};export{singleArgument};`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+export const singleArgument = (ar) => console.log(ar);`