Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset loading state when navigating to a new page #331

Open
amyjko opened this issue Mar 11, 2023 · 0 comments
Open

Reset loading state when navigating to a new page #331

amyjko opened this issue Mar 11, 2023 · 0 comments
Assignees
Labels
defect Something isn't working as intended reading Related to reading books.
Milestone

Comments

@amyjko
Copy link
Owner

amyjko commented Mar 11, 2023

Currently, we load a Svelte <Page> component to render a page. However, we only load it once, and so the image loading feedback that overlays the page only appears on the first page. All subsequent navigations render immediately, causing the page to jump as the cover image loads.

The way to resolve this is to reset the loading state when the page changes, reverting to the loading feedback until new images have loaded. The component doesn't yet take anything to key off, so it would need take a chapter ID, for example.

@amyjko amyjko added defect Something isn't working as intended reading Related to reading books. labels Mar 11, 2023
@amyjko amyjko added this to the 1.0 milestone Mar 11, 2023
@amyjko amyjko self-assigned this Mar 11, 2023
@amyjko amyjko moved this to Backlog in Bookish 1.0 Mar 10, 2024
@amyjko amyjko moved this from Backlog to Next in Bookish 1.0 Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working as intended reading Related to reading books.
Projects
Status: Next
Development

No branches or pull requests

1 participant