clippy

Author: anacrolix

src/c_api/types/value.rs

@@ -11,7 +11,7 @@ impl AsRef<Value> for PossumValue {
     fn as_ref(&self) -> &Value {
         match self {
             Self::ReaderValue(value) => value,
-            Self::SnapshotValue(sv) => *&sv,
+            Self::SnapshotValue(sv) => sv,
         }
     }
 }
@@ -22,7 +22,7 @@ impl Deref for PossumValue {
     fn deref(&self) -> &Self::Target {
         match self {
             Self::ReaderValue(value) => value,
-            Self::SnapshotValue(sv) => *&sv,
+            Self::SnapshotValue(sv) => sv,
         }
     }
 }

src/lib.rs

@@ -151,7 +151,7 @@ impl BeginWriteValue<'_, '_> {
         // Need to rewind the file since we're cloning the whole thing.
         file.seek(Start(0))?;
         value_writer.copy_from(file)?;
-        return Ok(value_writer);
+        Ok(value_writer)
     }
 
     /// Assign an exclusive file for writing a value.

src/tx.rs

@@ -260,14 +260,15 @@ impl<'h> Transaction<'h> {
     }
 
     pub fn rename_item(&mut self, from: &[u8], to: &[u8]) -> PubResult<Timestamp> {
-        let last_used = match self.tx.query_row(
+        let row_result = self.tx.query_row(
             "update keys set key=? where key=? returning last_used",
             [to, from],
             |row| {
                 let ts: Timestamp = row.get(0)?;
                 Ok(ts)
             },
-        ) {
+        );
+        let last_used = match row_result {
             Err(QueryReturnedNoRows) => Err(Error::NoSuchKey),
             Ok(ok) => Ok(ok),
             Err(err) => Err(err.into()),