Merging LWT into HA discovery

[anastas78]

In my opinion LWT is concept really useful for automation systems -i.e. HomeAssistant or in other live data solutions - i.e. skin belchertown. Out of that scenario I don't see a reason for weewx-mqtt to set last will. @ThomDietrich do you agree?
However in HA it is a big plus to have it as option. I would suggest to make it an config option(Fixes 21) and set it to True if ha_discovery is true. Then we can have a device_tracker for weewx and availability status for the sensors.

If you agree I can merge the two PR in one

[ThomDietrich]

Generally agree.

What's your goal here?
If your aim is to provide a PR to Matthew, merging the two might be irritating
If your aim is to maintain an independent fork, I am all for it.

Would you like me to review your HA discovery implementation? Edit: Just saw your PR. I'll respond there.

Regarding the work on this project: I suggested to Matthew to found a GitHub organization under which we could maintain a bunch of weewx extensions as a bigger community. Would you be interested to discuss this idea?

[anastas78]

What's your goal here?
If your aim is to provide a PR to Matthew, merging the two might be irritating
If your aim is to maintain an independent fork, I am all for it.

Merging the two PRs is just an option so we comment and work simultaneously and don't have to rework code later.
Edit:

Out of that scenario I don't see a reason for weewx-mqtt to set last will

That way LWT can be set/used only when ha_discovery is True.

Maintain an independent fork is a must at least till Matthew has the time to look at that extension again.

Regarding the work on this project: I suggested to Matthew to found a GitHub organization under which we could maintain a bunch of weewx extensions as a bigger community. Would you be interested to discuss this idea?

Sure. Just still learning how all of this work - i.e. that PR should have been targeted to a new branch ha-discovery-with-lwt and not the master, but still wondering how to rebase it :)

[anastas78]

I've merged your patch together with the HA discovery into a new branch ha-discovery-with-lwt and added the device tracker and availability options.

I will be delighted if you review it and comment on it.