use $Logger in cronjobs #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rspier
approved these changes
May 4, 2024
| @@ -80,7 +80,7 @@ sub read_errorlog { | |||
| close LOG; | |||
| report "\nErrorlog contains $errorlines lines today\n"; | |||
| } else { | |||
| warn "error opening $PAUSE::Config->{HTTP_ERRORLOG}: $!"; | |||
| $Logger->log("error opening $PAUSE::Config->{HTTP_ERRORLOG}: $!"); | |||
There was a problem hiding this comment.
if this is an error, should it be fatal?
There was a problem hiding this comment.
I think the whole premise of this code is kinda wonky, so I'm gonna not touch it beyond changing its logging. "Send me the day's web error logs" is odd.
| @@ -241,7 +241,8 @@ sub watch_files { | |||
| quoteHighBit => 1, | |||
| ); | |||
| my $v = $d->stringify($File::Find::name); | |||
| warn sprintf qq{Found a bad directory v[%s], rmtree-ing}, $v; | |||
|
|
|||
There was a problem hiding this comment.
Most blanks are, right? :)
Anyway, so much of the PAUSE code is without any vertical whitespace. Sometimes I add some to help break things up. This is maybe not the most obvious place to put it, but: I will continue to add vertical whitespace to create paragraphs of code.
There was a problem hiding this comment.
I like vertical whitespace, this just felt like a weird place to put it.
(and delete a few long-dead lines)
previously, there was an odd number of spaces for the bulk of the `find` sub, which was sort of a pain to deal with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the cron jobs are all(?) successfully loading PAUSE::Logger, we should use it. This replaces "warn" calls with use of $Logger.