improve how we track updating of 02packages after test indexing #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous method for checking this was generic, which is nice, but
sort of verbose to use. Worse, though, I don't think it was reliable.
That code, ->file_updated_ok and ->file_not_updated_ok, worked by
keeping a cache of file stats -- but it didn't precompute those stats,
it computed them on demand. So given this program:
$pause = PAUSE::TestPause->new;
do_stuff();
my $r1 = $pause->test_reindex;
do_other_stuff();
$pause->file_updated_ok("A");
my $r2 = $pause->test_reindex;
do_more_stuff();
my $r3 = $pause->test_reindex;
Calling `->file_updated_ok("A")` at the end would test since the
previous call. Calling `->file_updated_ok("B")` at the end would test
starting from nothing.
In reality, we only use this method for tracking 02packages, so I've
added specific tracking of that file, with the check put onto the Result
object, considering only what changed in the `test_reindex` call that
created that Result.
|
I've rebased #510 onto this work to keep life simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the generic methods for checking file changes. They were generic (great!) but also unreliable and kind of a pain to call. The new method is more reliable and easier to use.