-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing Status methods, except for Status editing #149
Add missing Status methods, except for Status editing #149
Conversation
- adds: translating, bookmarking, muting, pinning - postStatus now has language parameter - deleteStatus now returns a Status for subsequent editing - reblogStatus now has visibility parameter - implements posting of poll statuses - implements status scheduling - removes getCard (removed in Mastodon 3.0.0 after deprecation in 2.6.0) - adds entities Poll, ScheduledStatus, Translation - makes all new methods available via Rx - includes tests and test assets for all new methods - does not implement status editing (see PattaFeuFeu#124) Closes PattaFeuFeu#125, PattaFeuFeu#129, PattaFeuFeu#16
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
============================================
+ Coverage 45.54% 45.68% +0.13%
- Complexity 172 193 +21
============================================
Files 66 69 +3
Lines 1528 1806 +278
Branches 85 99 +14
============================================
+ Hits 696 825 +129
- Misses 809 946 +137
- Partials 23 35 +12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bocops ! First off, thank you very much for this great contribution! 😀 This is really awesome. I made some comments (just minor things). I'd say, let's merge this to master
very soon and then start writing some integration tests for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andregasser I hope I got all documentation links and annotations this time around. Thanks for checking! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good!
Closes #125.