Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Status methods, except for Status editing #149

Merged

Conversation

bocops
Copy link
Collaborator

@bocops bocops commented Feb 16, 2023

  • adds: translating, bookmarking, muting, pinning
  • postStatus now has language parameter
  • deleteStatus now returns a Status for subsequent editing
  • reblogStatus now has visibility parameter
  • implements posting of poll statuses
  • implements status scheduling
  • removes getCard (removed in Mastodon 3.0.0 after deprecation in 2.6.0)
  • adds entities Poll, ScheduledStatus, Translation
  • makes all new methods available via Rx
  • includes tests and test assets for all new methods
  • does not implement status editing (see Implement post editing functionality #124)

Closes #125.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- adds: translating, bookmarking, muting, pinning
- postStatus now has language parameter
- deleteStatus now returns a Status for subsequent editing
- reblogStatus now has visibility parameter
- implements posting of poll statuses
- implements status scheduling
- removes getCard (removed in Mastodon 3.0.0 after deprecation in 2.6.0)
- adds entities Poll, ScheduledStatus, Translation
- makes all new methods available via Rx
- includes tests and test assets for all new methods
- does not implement status editing (see PattaFeuFeu#124)

Closes PattaFeuFeu#125, PattaFeuFeu#129, PattaFeuFeu#16
@bocops bocops requested a review from andregasser February 16, 2023 17:41

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #149 (9d53d52) into master (d860e14) will increase coverage by 0.13%.
The diff coverage is 47.94%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #149      +/-   ##
============================================
+ Coverage     45.54%   45.68%   +0.13%     
- Complexity      172      193      +21     
============================================
  Files            66       69       +3     
  Lines          1528     1806     +278     
  Branches         85       99      +14     
============================================
+ Hits            696      825     +129     
- Misses          809      946     +137     
- Partials         23       35      +12     
Impacted Files Coverage Δ
...c/main/kotlin/social/bigbone/rx/RxStatusMethods.kt 0.00% <0.00%> (ø)
.../kotlin/social/bigbone/api/method/StatusMethods.kt 76.69% <70.00%> (-9.03%) ⬇️
...otlin/social/bigbone/api/entity/ScheduledStatus.kt 84.78% <84.78%> (ø)
.../src/main/kotlin/social/bigbone/api/entity/Poll.kt 100.00% <100.00%> (ø)
...rc/main/kotlin/social/bigbone/api/entity/Status.kt 100.00% <100.00%> (ø)
...in/kotlin/social/bigbone/api/entity/Translation.kt 100.00% <100.00%> (ø)
...in/kotlin/social/bigbone/api/entity/PreviewCard.kt 0.00% <0.00%> (-100.00%) ⬇️
...e/src/main/kotlin/social/bigbone/MastodonClient.kt 33.51% <0.00%> (+1.11%) ⬆️

Copy link
Collaborator

@andregasser andregasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bocops ! First off, thank you very much for this great contribution! 😀 This is really awesome. I made some comments (just minor things). I'd say, let's merge this to master very soon and then start writing some integration tests for this.

Copy link
Collaborator Author

@bocops bocops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andregasser I hope I got all documentation links and annotations this time around. Thanks for checking! :)

Copy link
Collaborator

@andregasser andregasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@andregasser andregasser merged commit ef46ba5 into PattaFeuFeu:master Feb 28, 2023
@bocops bocops deleted the 125_status_methods_implementation branch February 28, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide full support for status posting endpoint
2 participants