Skip to content

Commit 226521b

Browse files
committed
ContainsDuplicates: rewrite tests for readability and avoid duplication
1 parent 000ad84 commit 226521b

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

src/test/java/by/andd3dfx/collections/ContainsDuplicatesTest.java

+13-10
Original file line numberDiff line numberDiff line change
@@ -3,29 +3,32 @@
33
import org.junit.Before;
44
import org.junit.Test;
55

6-
import static org.junit.Assert.assertFalse;
7-
import static org.junit.Assert.assertTrue;
6+
import java.util.function.Function;
7+
8+
import static org.assertj.core.api.Assertions.assertThat;
89

910
public class ContainsDuplicatesTest {
1011

11-
private ContainsDuplicates containsDuplicates;
12+
private ContainsDuplicates solver;
1213

1314
@Before
1415
public void setUp() throws Exception {
15-
containsDuplicates = new ContainsDuplicates();
16+
solver = new ContainsDuplicates();
1617
}
1718

1819
@Test
1920
public void usingSet() {
20-
assertTrue(containsDuplicates.usingSet(new int[]{2, 1, 3, 1}));
21-
assertFalse(containsDuplicates.usingSet(new int[]{2, 1, 3, 56, 4}));
22-
assertTrue(containsDuplicates.usingSet(new int[]{1, 1, 1, 3, 3, 4, 3, 2, 4, 2}));
21+
checkAssertions(solver::usingSet);
2322
}
2423

2524
@Test
2625
public void usingSortWithEarlyReturn() {
27-
assertTrue(containsDuplicates.usingSortWithEarlyReturn(new int[]{2, 1, 3, 1}));
28-
assertFalse(containsDuplicates.usingSortWithEarlyReturn(new int[]{2, 1, 3, 56, 4}));
29-
assertTrue(containsDuplicates.usingSortWithEarlyReturn(new int[]{1, 1, 1, 3, 3, 4, 3, 2, 4, 2}));
26+
checkAssertions(solver::usingSortWithEarlyReturn);
27+
}
28+
29+
private void checkAssertions(Function<int[], Boolean> function) {
30+
assertThat(function.apply(new int[]{2, 1, 3, 1})).isTrue();
31+
assertThat(function.apply(new int[]{2, 1, 3, 56, 4})).isFalse();
32+
assertThat(function.apply(new int[]{1, 1, 1, 3, 3, 4, 3, 2, 4, 2})).isTrue();
3033
}
3134
}

0 commit comments

Comments
 (0)