Skip to content

Commit 856c94f

Browse files
committed
Merge pull request #31 from rynkowsg/master
- Fixed a RecyclerView error "No adapter attached; skipping layout". - Added injection resetting at fragments.
2 parents 0878c64 + 9a2ab82 commit 856c94f

File tree

2 files changed

+15
-6
lines changed

2 files changed

+15
-6
lines changed

presentation/src/main/java/com/fernandocejas/android10/sample/presentation/view/fragment/UserDetailsFragment.java

+5
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,11 @@ public static UserDetailsFragment newInstance(int userId) {
7979
this.userDetailsPresenter.pause();
8080
}
8181

82+
@Override public void onDestroyView() {
83+
super.onDestroyView();
84+
ButterKnife.reset(this);
85+
}
86+
8287
@Override public void onDestroy() {
8388
super.onDestroy();
8489
this.userDetailsPresenter.destroy();

presentation/src/main/java/com/fernandocejas/android10/sample/presentation/view/fragment/UserListFragment.java

+10-6
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.fernandocejas.android10.sample.presentation.view.UserListView;
2424
import com.fernandocejas.android10.sample.presentation.view.adapter.UsersAdapter;
2525
import com.fernandocejas.android10.sample.presentation.view.adapter.UsersLayoutManager;
26+
import java.util.ArrayList;
2627
import java.util.Collection;
2728
import javax.inject.Inject;
2829

@@ -90,6 +91,11 @@ public interface UserListListener {
9091
this.userListPresenter.destroy();
9192
}
9293

94+
@Override public void onDestroyView() {
95+
super.onDestroyView();
96+
ButterKnife.reset(this);
97+
}
98+
9399
private void initialize() {
94100
this.getComponent(UserComponent.class).inject(this);
95101
this.userListPresenter.setView(this);
@@ -98,6 +104,10 @@ private void initialize() {
98104
private void setupUI() {
99105
this.usersLayoutManager = new UsersLayoutManager(getActivity());
100106
this.rv_users.setLayoutManager(usersLayoutManager);
107+
108+
this.usersAdapter = new UsersAdapter(getActivity(), new ArrayList<UserModel>());
109+
this.usersAdapter.setOnItemClickListener(onItemClickListener);
110+
this.rv_users.setAdapter(usersAdapter);
101111
}
102112

103113
@Override public void showLoading() {
@@ -120,13 +130,7 @@ private void setupUI() {
120130

121131
@Override public void renderUserList(Collection<UserModel> userModelCollection) {
122132
if (userModelCollection != null) {
123-
if (this.usersAdapter == null) {
124-
this.usersAdapter = new UsersAdapter(getActivity(), userModelCollection);
125-
} else {
126133
this.usersAdapter.setUsersCollection(userModelCollection);
127-
}
128-
this.usersAdapter.setOnItemClickListener(onItemClickListener);
129-
this.rv_users.setAdapter(usersAdapter);
130134
}
131135
}
132136

0 commit comments

Comments
 (0)