refactored code

Author: Christoph Wolfes

Diff for: src/main/chart/chartController.js

@@ -7,23 +7,6 @@ angular.module('adf.widget.redmine')
     vm.config = config;
     vm.issues = issues;
 
-    var calculateOpenIssuesPerDay = function (from, to, issues) {
-      // order issues by creation date
-      var openIssues = []; // inv: ordered by "closed_on"
-      var dates = [];// x-values
-      var values = [];// y-values
-      while (from.getTime() <= to.getTime()) {
-        moveNewOpenIssues(issues, openIssues, from);
-        removeNewClosedIssues(openIssues, from);
-        dates.push(from.toDateString());
-        values.push(openIssues.length)
-        from.setDate(from.getDate() + 1); // next day
-      }
-      return {
-        dates: dates,
-        values: values
-      }
-    }
     var moveNewOpenIssues = function (allIssues, openIssues, date) {
       //console.log("allIssues.length "+allIssues.length);
       for (var i = 0; i < allIssues.length; i++) {
@@ -37,7 +20,7 @@ angular.module('adf.widget.redmine')
           break;
         }
       }
-    }
+    };
 
     var removeNewClosedIssues = function (openIssues, date) {
       for (var i = 0; i < openIssues.length; i++) {
@@ -51,7 +34,27 @@ angular.module('adf.widget.redmine')
           }
         }
       }
-    }
+    };
+
+
+    var calculateOpenIssuesPerDay = function (from, to, issues) {
+      // order issues by creation date
+      var openIssues = []; // inv: ordered by "closed_on"
+      var dates = [];// x-values
+      var values = [];// y-values
+      while (from.getTime() <= to.getTime()) {
+        moveNewOpenIssues(issues, openIssues, from);
+        removeNewClosedIssues(openIssues, from);
+        dates.push(from.toDateString());
+        values.push(openIssues.length);
+        from.setDate(from.getDate() + 1); // next day
+      }
+      return {
+        dates: dates,
+        values: values
+      };
+    };
+
 
     if (vm.config.timespan && vm.config.timespan.fromDateTime && vm.config.timespan.toDateTime) {
       var from = new Date(vm.config.timespan.fromDateTime);
@@ -74,15 +77,15 @@ angular.module('adf.widget.redmine')
         },
         legend: {
           display: true,
-          position: "bottom"
+          position: 'bottom'
         }
       };
 
       vm.chart = {
         labels: generatedData.dates,
         data: [generatedData.values],
-        series: ["Project ..."],
-        class: "chart-line",
+        series: ['Project ...'],
+        class: 'chart-line',
         options: options
       };
     }

Diff for: src/main/issues/edit/editIssuesController.js

@@ -3,18 +3,18 @@
 angular.module('adf.widget.redmine')
   .controller('editIssuesController', function(projects, config){
     var vm = this;
-    console.log("config: "+config);
+    console.log('config: '+config);
     vm.possibleColumns = {
-      "id":{"name":"ID", "show": true},
-      "tracker":{"name":"Tracker","show": true},
-      "status":{"name":"Status","show": true},
-      "subject":{"name":"Subject","show": true}
+      'id':{'name':'ID', 'show': true},
+      'tracker':{'name':'Tracker','show': true},
+      'status':{'name':'Status','show': true},
+      'subject':{'name':'Subject','show': true}
     };
 
     if(angular.equals({},config)) {
       config.columns=vm.possibleColumns;
-      config.project="";
-      config.assigned_to_id="me";
+      config.project='';
+      config.assigned_to_id='me';
       config.showClosed=false;
     }
 

Diff for: src/main/redmine.js

@@ -1,7 +1,7 @@
 'use strict';
 
 angular.module('adf.widget.redmine', ['adf.provider', 'smart-table', 'chart.js', 'ui.bootstrap.datepicker'])
-  .constant("redmineEndpoint", "http://www.redmine.org/")
+  .constant('redmineEndpoint', 'http://www.redmine.org/')
   .config(function (dashboardProvider) {
 
     var editIssues = {

Diff for: src/main/service.js

@@ -36,7 +36,7 @@ angular.module('adf.widget.redmine')
           return allIssues;
         }
 
-      })
+      });
     }
 
     function collectPageIssues(params, offset){