Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

shift / ctrl clicking #205

Closed
seiyria opened this issue Jun 20, 2014 · 12 comments
Closed

shift / ctrl clicking #205

seiyria opened this issue Jun 20, 2014 · 12 comments

Comments

@seiyria
Copy link

seiyria commented Jun 20, 2014

Is this a feature that could be added to ui-sortable, or should it just be added on top as a separate component?

@thgreasi
Copy link
Contributor

I think this is a duplicate of #167 (found using search). In there I provided a proof of concept repo allowing multi-item sorting.
Please use with caution! I never created test cases since the feedback/discussion didn't continue.
It would be nice to have some feedback or any help.

@thgreasi
Copy link
Contributor

Tl;Dr; jquery UI does not provide something like that. It should be a directive.

@seiyria
Copy link
Author

seiyria commented Jun 20, 2014

Yeah, alright. That's how I did it with knockout - I was wondering if I should do the same here. I'm a little new to making these things into directives but I'll do what I can. Thanks for getting back to me!

@seiyria seiyria closed this as completed Jun 20, 2014
@thgreasi thgreasi reopened this Jun 20, 2014
@vadimtar
Copy link

vadimtar commented Sep 3, 2014

Hi. I've just inserted this into my project and meanwhile its working just fine.
Have anyone got into some issues? Edge cases ?
Thanks.

@seiyria
Copy link
Author

seiyria commented Sep 3, 2014

You have shift/ctrl selection working fine?

@thgreasi
Copy link
Contributor

thgreasi commented Sep 3, 2014

Why not? Are the two example in README not working for you?

@seiyria
Copy link
Author

seiyria commented Sep 3, 2014

Sorry @thgreasi - I haven't been keeping up with the repo. Which two examples? Is one of them shift/ctrl across connected lists?

@vadimtar
Copy link

vadimtar commented Sep 3, 2014

The multi select and drag is working fine for me. If anyone has come into issues please let me know.

@thgreasi
Copy link
Contributor

thgreasi commented Sep 3, 2014

I was referring to this README.

@seiyria
Copy link
Author

seiyria commented Sep 3, 2014

Oh, great! Thanks! It looks fine, I will try it out soon.

@louiskirsch
Copy link

Will this extension still be considered for the main project?

@thgreasi
Copy link
Contributor

thgreasi commented Mar 6, 2015

In it's current state, I would prefer having ui-sortable to be just a jquery-ui-sortable wrapper and as slim as possible.
This way the main branch code can be more maintainable but it will also have to expose enough hooks to provide more complex interactions.

Merging the multi-selection interaction, would also need lots of extra test, that I have yet to write for ui-sortable-multiselection.
Maybe at a later time, if some refactoring to the multi-selection code is done so that it looks similar to the code in the main branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants