From 93c4b7d043fd6442912ac9a449ce56d408b2e056 Mon Sep 17 00:00:00 2001 From: Thodoris Greasidis Date: Mon, 14 Apr 2014 23:58:46 +0300 Subject: [PATCH 1/2] Improvement(README) added notes about dependencies. Script include order & jquery-ui minimal custom build. --- README.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/README.md b/README.md index f76eef1..4740bd2 100644 --- a/README.md +++ b/README.md @@ -6,6 +6,11 @@ This directive allows you to sort an array with drag & drop. - JQuery - JQueryUI +- AngularJS + +**Notes:** +> JQuery must be included before AngularJS. +> JQueryUI dependecies include core, widget, mouse & sortable. Creating a [custom build](http://jqueryui.com/download/#!version=1.10&components=1110000010000000000000000000000000) will [greatly reduce](https://github.com/angular-ui/ui-sortable/issues/154#issuecomment-40279430) the required file size. ## Usage From 72be8f39186be5ffbce3f5d96e5365daaddf5b47 Mon Sep 17 00:00:00 2001 From: Thodoris Greasidis Date: Tue, 15 Apr 2014 00:23:44 +0300 Subject: [PATCH 2/2] Improved(README): Canceling section. --- README.md | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 4740bd2..3db5862 100644 --- a/README.md +++ b/README.md @@ -78,16 +78,18 @@ $scope.sortableOptions = { }; ``` -**Note:** `update` occurs before any model/scope changes but after the DOM position has been updated. +**Notes:** +* `update` is the appropriate place to cancel a sorting, since it occurs before any model/scope changes but after the DOM position has been updated. So `ui.item.scope` and the directive's `ng-model`, are equal to the scope before the drag start. +* To [cancel a sorting between connected lists](https://github.com/angular-ui/ui-sortable/issues/107#issuecomment-33633638), `cancel` should be called inside the `update` callback of the originating list. ## Examples - [Simple Demo](http://codepen.io/thgreasi/pen/jlkhr) -- [Connected Lists](http://codepen.io/thgreasi/pen/uFile) -- [Filtering](http://codepen.io/thgreasi/pen/mzGbq) [details #113](https://github.com/angular-ui/ui-sortable/issues/113) -- [Ordering](http://plnkr.co/edit/XPUzJjdvwE0QWQ6py6mQ?p=preview) [details #70](https://github.com/angular-ui/ui-sortable/issues/70) -- [Cloning](http://codepen.io/thgreasi/pen/qmvhG) [details #139](https://github.com/angular-ui/ui-sortable/issues/139) +- [Connected Lists](http://codepen.io/thgreasi/pen/uFile) & [Connected Lists Canceling](http://codepen.io/thgreasi/pen/IdvFc) +- [Filtering](http://codepen.io/thgreasi/pen/mzGbq) ([details](https://github.com/angular-ui/ui-sortable/issues/113)) +- [Ordering](http://plnkr.co/edit/XPUzJjdvwE0QWQ6py6mQ?p=preview) ([details](https://github.com/angular-ui/ui-sortable/issues/70)) +- [Cloning](http://codepen.io/thgreasi/pen/qmvhG) ([details](https://github.com/angular-ui/ui-sortable/issues/139)) ## Reporting Issues