Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

Commit 434308a

Browse files
authored
docs(forms): revise prose for form.reset (#2853)
1 parent a752572 commit 434308a

File tree

4 files changed

+66
-77
lines changed

4 files changed

+66
-77
lines changed

Diff for: public/docs/_examples/forms/ts/app/hero-form.component.html

+15-19
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ <h1>Hero Form</h1>
3636
required
3737
[(ngModel)]="model.power" name="power"
3838
#power="ngModel" >
39-
<option *ngFor="let p of powers" [value]="p">{{p}}</option>
39+
<option *ngFor="let pow of powers" [value]="pow">{{pow}}</option>
4040
</select>
4141
<div [hidden]="power.valid || power.pristine" class="alert alert-danger">
4242
Power is required
@@ -46,12 +46,18 @@ <h1>Hero Form</h1>
4646
<!-- #docregion submit-button -->
4747
<button type="submit" class="btn btn-default" [disabled]="!heroForm.form.valid">Submit</button>
4848
<!-- #enddocregion submit-button -->
49-
50-
<!-- #docregion new-hero-button -->
49+
<!-- #docregion new-hero-button-form-reset -->
5150
<button type="button" class="btn btn-default" (click)="newHero(); heroForm.reset()">New Hero</button>
52-
<!-- #enddocregion new-hero-button -->
53-
51+
<!-- #enddocregion new-hero-button-form-reset -->
5452
<!-- #enddocregion final -->
53+
<i>with</i> reset
54+
55+
&nbsp;&nbsp;
56+
<!-- #docregion new-hero-button-no-reset -->
57+
<button type="button" class="btn btn-default" (click)="newHero()">New Hero</button>
58+
<!-- #enddocregion new-hero-button-no-reset -->
59+
<i>without</i> reset
60+
5561
<!-- NOT SHOWN IN DOCS -->
5662
<div>
5763
<hr>
@@ -126,7 +132,7 @@ <h1>Hero Form</h1>
126132
<div class="form-group">
127133
<label for="power">Hero Power</label>
128134
<select class="form-control" id="power" required>
129-
<option *ngFor="let p of powers" [value]="p">{{p}}</option>
135+
<option *ngFor="let pow of powers" [value]="pow">{{pow}}</option>
130136
</select>
131137
</div>
132138

@@ -165,7 +171,7 @@ <h1>Hero Form</h1>
165171
<select class="form-control" id="power"
166172
required
167173
[(ngModel)]="model.power" name="power">
168-
<option *ngFor="let p of powers" [value]="p">{{p}}</option>
174+
<option *ngFor="let pow of powers" [value]="pow">{{pow}}</option>
169175
</select>
170176
</div>
171177

@@ -178,12 +184,12 @@ <h1>Hero Form</h1>
178184

179185
<!-- EXTRA MATERIAL FOR DOCUMENTATION -->
180186
<hr>
181-
<!-- #docregion ngModel-1-->
187+
<!-- #docregion ngModelName-1 -->
182188
<input type="text" class="form-control" id="name"
183189
required
184190
[(ngModel)]="model.name" name="name">
185191
TODO: remove this: {{model.name}}
186-
<!-- #enddocregion ngModel-1-->
192+
<!-- #enddocregion ngModelName-1 -->
187193
<hr>
188194
<!-- #docregion ngModel-3-->
189195
<input type="text" class="form-control" id="name"
@@ -193,16 +199,6 @@ <h1>Hero Form</h1>
193199
TODO: remove this: {{model.name}}
194200
<!-- #enddocregion ngModel-3-->
195201
<hr>
196-
<!-- #docregion form-reset -->
197-
<button type="button" class="btn btn-default" (click)="newHero(); heroForm.reset()">New Hero</button>
198-
<!-- #enddocregion form-reset -->
199-
200-
<!-- #docregion ngModelName-1 -->
201-
<input type="text" class="form-control" id="name"
202-
required
203-
[(ngModel)]="model.name" name="name" >
204-
<!-- #enddocregion ngModelName-1 -->
205-
<hr>
206202
<!-- #docregion ngModelName-2 -->
207203
<input type="text" class="form-control" id="name"
208204
required

Diff for: public/docs/_examples/forms/ts/app/hero-form.component.ts

-2
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,9 @@ export class HeroFormComponent {
3030

3131
// #docregion final
3232
// #docregion new-hero
33-
// #docregion new-hero-v1
3433
newHero() {
3534
this.model = new Hero(42, '', '');
3635
}
37-
// #enddocregion new-hero-v1
3836
// #enddocregion new-hero
3937
// #enddocregion final
4038
//////// NOT SHOWN IN DOCS ////////

Diff for: public/docs/_examples/forms/ts/app/main.ts

-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,4 @@
22
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
33
import { AppModule } from './app.module';
44

5-
// Compiles the module (asynchronously) with the runtime compiler
6-
// which generates a compiled module factory in memory.
7-
// Then bootstraps with that factory, targeting the browser.
85
platformBrowserDynamic().bootstrapModule(AppModule);

0 commit comments

Comments
 (0)