Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 1d4216a

Browse files
committed
chore(travis): use Firefox 47
This commit also adds a new capability to the protractor configs that ensures that all angularjs.org tests run correctly on Firefox. See SeleniumHQ/selenium#1202
1 parent 9566055 commit 1d4216a

4 files changed

+14
-11
lines changed

docs/protractor-conf.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ config.specs = [
66
'app/e2e/**/*.scenario.js'
77
];
88

9-
config.capabilities = {
10-
browserName: 'chrome',
11-
};
9+
config.capabilities.browserName = 'chrome';
1210

1311
exports.config = config;

protractor-conf.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@ config.specs = [
88
'docs/app/e2e/**/*.scenario.js'
99
];
1010

11-
config.capabilities = {
12-
browserName: 'chrome'
13-
};
11+
config.capabilities.browserName = 'chrome';
1412

1513
config.directConnect = true;
1614

protractor-shared-conf.js

+5
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ exports.config = {
77

88
framework: 'jasmine2',
99

10+
capabilities: {
11+
// Fix element scrolling behavior in Firefox for fixed header elements (like angularjs.org has)
12+
'elementScrollBehavior': 1
13+
},
14+
1015
onPrepare: function() {
1116
/* global angular: false, browser: false, jasmine: false */
1217

protractor-travis-conf.js

+7-5
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ if (process.env.BROWSER_PROVIDER === 'browserstack') {
1313
}),
1414
capabilitiesForBrowserStack({
1515
browserName: 'firefox',
16-
version: '28'
16+
version: '47'
1717
}),
1818
capabilitiesForBrowserStack({
1919
browserName: 'safari',
@@ -33,7 +33,7 @@ if (process.env.BROWSER_PROVIDER === 'browserstack') {
3333
}),
3434
capabilitiesForSauceLabs({
3535
browserName: 'firefox',
36-
version: '28'
36+
version: '47'
3737
}),
3838
capabilitiesForSauceLabs({
3939
browserName: 'safari',
@@ -54,7 +54,7 @@ function capabilitiesForBrowserStack(capabilities) {
5454
return {
5555
'browserstack.user': process.env.BROWSER_STACK_USERNAME,
5656
'browserstack.key': process.env.BROWSER_STACK_ACCESS_KEY,
57-
'browserstack.local' : 'true',
57+
'browserstack.local': 'true',
5858
'browserstack.debug': 'true',
5959
'browserstack.tunnelIdentifier': process.env.TRAVIS_JOB_NUMBER,
6060
'tunnelIdentifier': process.env.TRAVIS_JOB_NUMBER,
@@ -64,7 +64,8 @@ function capabilitiesForBrowserStack(capabilities) {
6464

6565
'browserName': capabilities.browserName,
6666
'platform': capabilities.platform,
67-
'version': capabilities.version
67+
'version': capabilities.version,
68+
'elementScrollBehavior': 1
6869
};
6970
}
7071

@@ -77,6 +78,7 @@ function capabilitiesForSauceLabs(capabilities) {
7778

7879
'browserName': capabilities.browserName,
7980
'platform': capabilities.platform,
80-
'version': capabilities.version
81+
'version': capabilities.version,
82+
'elementScrollBehavior': 1
8183
};
8284
}

0 commit comments

Comments
 (0)