Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 2b7a359

Browse files
gkalpakgkalpak
committed
test(ngAnimate): make expectations more specific
1 parent e7d8eee commit 2b7a359

File tree

1 file changed

+44
-44
lines changed

1 file changed

+44
-44
lines changed

‎test/ngAnimate/animateSpec.js

+44-44
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ describe('animations', function() {
168168
inject(function($animate, $rootScope) {
169169
$animate.enter(element, parent);
170170
$rootScope.$digest();
171-
expect(capturedAnimation).toBeFalsy();
171+
expect(capturedAnimation).toBeNull();
172172
expect(element[0].parentNode).toEqual(parent[0]);
173173

174174
hidden = false;
@@ -188,7 +188,7 @@ describe('animations', function() {
188188

189189
$animate.enter(element, parent);
190190
$rootScope.$digest();
191-
expect(capturedAnimation).toBeFalsy();
191+
expect(capturedAnimation).toBeNull();
192192

193193
element.addClass('only-allow-this-animation');
194194

@@ -208,7 +208,7 @@ describe('animations', function() {
208208

209209
$animate.enter(svgElement, parent);
210210
$rootScope.$digest();
211-
expect(capturedAnimation).toBeFalsy();
211+
expect(capturedAnimation).toBeNull();
212212

213213
svgElement.attr('class', 'element only-allow-this-animation-svg');
214214

@@ -290,7 +290,7 @@ describe('animations', function() {
290290
$animate.leave(element);
291291
$rootScope.$digest();
292292

293-
expect(capturedAnimation).toBeFalsy();
293+
expect(capturedAnimation).toBeNull();
294294
expect(element[0].parentNode).toBeFalsy();
295295
});
296296
});
@@ -314,9 +314,9 @@ describe('animations', function() {
314314

315315
$animate.enter(element, parent);
316316

317-
expect(capturedAnimation).toBeFalsy();
317+
expect(capturedAnimation).toBeNull();
318318
$rootScope.$digest();
319-
expect(capturedAnimation).toBeFalsy();
319+
expect(capturedAnimation).toBeNull();
320320
}));
321321

322322
it('should disable all animations on the given element',
@@ -328,15 +328,15 @@ describe('animations', function() {
328328
expect($animate.enabled(element)).toBeFalsy();
329329

330330
$animate.addClass(element, 'red');
331-
expect(capturedAnimation).toBeFalsy();
331+
expect(capturedAnimation).toBeNull();
332332
$rootScope.$digest();
333-
expect(capturedAnimation).toBeFalsy();
333+
expect(capturedAnimation).toBeNull();
334334

335335
$animate.enabled(element, true);
336336
expect($animate.enabled(element)).toBeTruthy();
337337

338338
$animate.addClass(element, 'blue');
339-
expect(capturedAnimation).toBeFalsy();
339+
expect(capturedAnimation).toBeNull();
340340
$rootScope.$digest();
341341
expect(capturedAnimation).toBeTruthy();
342342
}));
@@ -347,14 +347,14 @@ describe('animations', function() {
347347
$animate.enabled(parent, false);
348348

349349
$animate.enter(element, parent);
350-
expect(capturedAnimation).toBeFalsy();
350+
expect(capturedAnimation).toBeNull();
351351
$rootScope.$digest();
352-
expect(capturedAnimation).toBeFalsy();
352+
expect(capturedAnimation).toBeNull();
353353

354354
$animate.enabled(parent, true);
355355

356356
$animate.enter(element, parent);
357-
expect(capturedAnimation).toBeFalsy();
357+
expect(capturedAnimation).toBeNull();
358358
$rootScope.$digest();
359359
expect(capturedAnimation).toBeTruthy();
360360
}));
@@ -370,11 +370,11 @@ describe('animations', function() {
370370

371371
$animate.addClass(element, 'red');
372372
$rootScope.$digest();
373-
expect(capturedAnimation).toBeFalsy();
373+
expect(capturedAnimation).toBeNull();
374374

375375
$animate.addClass(child, 'red');
376376
$rootScope.$digest();
377-
expect(capturedAnimation).toBeFalsy();
377+
expect(capturedAnimation).toBeNull();
378378

379379
$animate.enabled(element, true);
380380

@@ -402,7 +402,7 @@ describe('animations', function() {
402402
$rootScope.items = [1,2,3,4,5];
403403
$rootScope.$digest();
404404

405-
expect(capturedAnimation).toBeFalsy();
405+
expect(capturedAnimation).toBeNull();
406406
}));
407407

408408
it('should not attempt to perform an animation on a text node element',
@@ -414,7 +414,7 @@ describe('animations', function() {
414414
$animate.addClass(textNode, 'some-class');
415415
$rootScope.$digest();
416416

417-
expect(capturedAnimation).toBeFalsy();
417+
expect(capturedAnimation).toBeNull();
418418
}));
419419

420420
it('should not attempt to perform an animation on an empty jqLite collection',
@@ -426,7 +426,7 @@ describe('animations', function() {
426426
$animate.addClass(emptyNode, 'some-class');
427427
$rootScope.$digest();
428428

429-
expect(capturedAnimation).toBeFalsy();
429+
expect(capturedAnimation).toBeNull();
430430
})
431431
);
432432

@@ -439,7 +439,7 @@ describe('animations', function() {
439439

440440
$animate.leave(textNode);
441441
$rootScope.$digest();
442-
expect(capturedAnimation).toBeFalsy();
442+
expect(capturedAnimation).toBeNull();
443443
expect(textNode[0].parentNode).not.toBe(parentNode);
444444
}));
445445

@@ -455,7 +455,7 @@ describe('animations', function() {
455455

456456
$animate.leave(commentNode);
457457
$rootScope.$digest();
458-
expect(capturedAnimation).toBeFalsy();
458+
expect(capturedAnimation).toBeNull();
459459
expect(commentNode[0].parentNode).not.toBe(parentNode);
460460
}));
461461

@@ -667,13 +667,13 @@ describe('animations', function() {
667667

668668
$animate.removeClass(element, 'something-to-remove');
669669
$rootScope.$digest();
670-
expect(capturedAnimation).toBeFalsy();
670+
expect(capturedAnimation).toBeNull();
671671

672672
element.addClass('something-to-add');
673673

674674
$animate.addClass(element, 'something-to-add');
675675
$rootScope.$digest();
676-
expect(capturedAnimation).toBeFalsy();
676+
expect(capturedAnimation).toBeNull();
677677
}));
678678
});
679679

@@ -689,7 +689,7 @@ describe('animations', function() {
689689
parent.append(element);
690690
$animate.animate(element, null, toStyle);
691691
$rootScope.$digest();
692-
expect(capturedAnimation).toBeFalsy();
692+
expect(capturedAnimation).toBeNull();
693693
});
694694
});
695695

@@ -700,7 +700,7 @@ describe('animations', function() {
700700
parent.append(element);
701701
$animate.animate(element, fromStyle);
702702
$rootScope.$digest();
703-
expect(capturedAnimation).toBeFalsy();
703+
expect(capturedAnimation).toBeNull();
704704
}));
705705

706706
it('should perform an animation if only from styles are provided as well as any valid classes',
@@ -712,7 +712,7 @@ describe('animations', function() {
712712
var options = { removeClass: 'goop' };
713713
$animate.animate(element, fromStyle, null, null, options);
714714
$rootScope.$digest();
715-
expect(capturedAnimation).toBeFalsy();
715+
expect(capturedAnimation).toBeNull();
716716

717717
fromStyle = { color: 'blue' };
718718
options = { addClass: 'goop' };
@@ -816,11 +816,11 @@ describe('animations', function() {
816816

817817
var elm1 = $compile('<div class="animated"></div>')($rootScope);
818818

819-
expect(capturedAnimation).toBeFalsy();
819+
expect(capturedAnimation).toBeNull();
820820
$animate.addClass(elm1, 'klass2');
821-
expect(capturedAnimation).toBeFalsy();
821+
expect(capturedAnimation).toBeNull();
822822
$rootScope.$digest();
823-
expect(capturedAnimation).toBeFalsy();
823+
expect(capturedAnimation).toBeNull();
824824
}));
825825

826826
it('should skip animations if the element is attached to the $rootElement, but not apart of the body',
@@ -834,30 +834,30 @@ describe('animations', function() {
834834
newParent.append($rootElement);
835835
$rootElement.append(elm1);
836836

837-
expect(capturedAnimation).toBeFalsy();
837+
expect(capturedAnimation).toBeNull();
838838
$animate.addClass(elm1, 'klass2');
839-
expect(capturedAnimation).toBeFalsy();
839+
expect(capturedAnimation).toBeNull();
840840
$rootScope.$digest();
841-
expect(capturedAnimation).toBeFalsy();
841+
expect(capturedAnimation).toBeNull();
842842
}));
843843

844844
it('should skip the animation if the element is removed from the DOM before the post digest kicks in',
845845
inject(function($animate, $rootScope) {
846846

847847
$animate.enter(element, parent);
848-
expect(capturedAnimation).toBeFalsy();
848+
expect(capturedAnimation).toBeNull();
849849

850850
element.remove();
851851
$rootScope.$digest();
852-
expect(capturedAnimation).toBeFalsy();
852+
expect(capturedAnimation).toBeNull();
853853
}));
854854

855855
it('should be blocked when there is an ongoing structural parent animation occurring',
856856
inject(function($rootScope, $rootElement, $animate) {
857857

858858
parent.append(element);
859859

860-
expect(capturedAnimation).toBeFalsy();
860+
expect(capturedAnimation).toBeNull();
861861
$animate.move(parent, parent2);
862862
$rootScope.$digest();
863863

@@ -867,7 +867,7 @@ describe('animations', function() {
867867

868868
$animate.addClass(element, 'blue');
869869
$rootScope.$digest();
870-
expect(capturedAnimation).toBeFalsy();
870+
expect(capturedAnimation).toBeNull();
871871
}));
872872

873873
it('should disable all child animations for atleast one turn when a structural animation is issued',
@@ -917,7 +917,7 @@ describe('animations', function() {
917917

918918
parent.append(element);
919919

920-
expect(capturedAnimation).toBeFalsy();
920+
expect(capturedAnimation).toBeNull();
921921
$animate.addClass(parent, 'rogers');
922922
$rootScope.$digest();
923923

@@ -940,7 +940,7 @@ describe('animations', function() {
940940
$animate.addClass(element, 'rumlow');
941941
$animate.move(parent, null, parent2);
942942

943-
expect(capturedAnimation).toBeFalsy();
943+
expect(capturedAnimation).toBeNull();
944944
expect(capturedAnimationHistory.length).toBe(0);
945945
$rootScope.$digest();
946946

@@ -1193,12 +1193,12 @@ describe('animations', function() {
11931193
inject(function($animate, $rootScope) {
11941194

11951195
$animate.enter(element, parent);
1196-
expect(capturedAnimation).toBeFalsy();
1196+
expect(capturedAnimation).toBeNull();
11971197

11981198
$animate.addClass(element, 'red');
11991199
expect(element).not.toHaveClass('red');
12001200

1201-
expect(capturedAnimation).toBeFalsy();
1201+
expect(capturedAnimation).toBeNull();
12021202
$rootScope.$digest();
12031203

12041204
expect(capturedAnimation[1]).toBe('enter');
@@ -1227,7 +1227,7 @@ describe('animations', function() {
12271227
$animate.removeClass(element, 'red');
12281228
$rootScope.$digest();
12291229

1230-
expect(capturedAnimation).toBeFalsy();
1230+
expect(capturedAnimation).toBeNull();
12311231

12321232
$animate.addClass(element, 'blue');
12331233
$rootScope.$digest();
@@ -1344,7 +1344,7 @@ describe('animations', function() {
13441344
$animate.removeClass(element, 'four');
13451345

13461346
$rootScope.$digest();
1347-
expect(capturedAnimation).toBeFalsy();
1347+
expect(capturedAnimation).toBeNull();
13481348
}));
13491349

13501350
it('but not skip the animation if it is a structural animation and if there are no classes to be animated',
@@ -1632,7 +1632,7 @@ describe('animations', function() {
16321632

16331633
$animate.addClass(animateElement, 'red');
16341634
$rootScope.$digest();
1635-
expect(capturedAnimation).toBeFalsy();
1635+
expect(capturedAnimation).toBeNull();
16361636

16371637
// Pin the element to the app root to enable animations
16381638
$animate.pin(pinElement, $rootElement);
@@ -1676,13 +1676,13 @@ describe('animations', function() {
16761676

16771677
$animate.addClass(animateElement, 'red');
16781678
$rootScope.$digest();
1679-
expect(capturedAnimation).toBeFalsy();
1679+
expect(capturedAnimation).toBeNull();
16801680

16811681
$animate.pin(pinElement, pinTargetElement);
16821682

16831683
$animate.addClass(animateElement, 'blue');
16841684
$rootScope.$digest();
1685-
expect(capturedAnimation).toBeFalsy();
1685+
expect(capturedAnimation).toBeNull();
16861686

16871687
dealoc(pinElement);
16881688
});
@@ -1720,7 +1720,7 @@ describe('animations', function() {
17201720

17211721
$animate.addClass(animateElement, 'blue');
17221722
$rootScope.$digest();
1723-
expect(capturedAnimation).toBeFalsy();
1723+
expect(capturedAnimation).toBeNull();
17241724

17251725
$animate.enabled(pinHostElement, true);
17261726

0 commit comments

Comments
 (0)