-
Notifications
You must be signed in to change notification settings - Fork 26.1k
Improve types for TestModuleMetadata #51765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this issue
Sep 13, 2023
To improve compiler errors on `TestModuleMetadata`, lets replace `any` for `providers`, `declarations` and `imports` fixes angular#51765
3 tasks
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this issue
Sep 13, 2023
To improve compiler errors on `TestModuleMetadata`, lets replace `any` for `providers`, `declarations` and `imports` fixes angular#51765
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this issue
Sep 13, 2023
To improve compiler errors on `TestModuleMetadata`, lets replace `any` for `providers`, `declarations` and `imports` fixes angular#51765
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this issue
Sep 13, 2023
To improve compiler errors on `TestModuleMetadata`, lets replace `any` for `providers`, `declarations` and `imports` fixes angular#51765
JeanMeche
added a commit
to JeanMeche/angular
that referenced
this issue
Sep 13, 2023
To improve compiler errors on `TestModuleMetadata`, lets replace `any` for `providers`, `declarations` and `imports` fixes angular#51765
FYI, closing this ticket as a duplicate of #37178. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Which @angular/* package(s) are relevant/related to the feature request?
core
Description
Hello,
I wish
TestModuleMetadata
were typed a little more. I have seen something along the lines of:useValue
isn't written correctly, there is no error in the static code analysis, because the actual type is justany[]
.Proposed solution
Maybe we can change it to something like:
This would still allow people to pass any mock for providers they want, but we would help them get the structure for the provider correctly.
Alternatives considered
None
The text was updated successfully, but these errors were encountered: