build: clean-up to use fine-grained targets for faster rebuilds

We've decided to not leverage pnpm workspace first-party dependency
linking, except for integration tests.

This commit cleans up leftovers from the previous revert commit, and
also fixes other tests to work with the fine-grained targets. In
addition, we also improve visibility rules to safe-guard against
accidentally relying on the pnpm first party linkings.

Author: devversion

.aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx

@@ -3,18 +3,18 @@
 # This file should be checked into version control along with the pnpm-lock.yaml file.
 .npmrc=-1406867100
 integration/package.json=-620011313
-package.json=-635422980
+package.json=20540807
 patches/@angular__compiler-cli.patch=-65319555
-pnpm-lock.yaml=-1494189058
+pnpm-lock.yaml=-1601778403
 pnpm-workspace.yaml=334858811
-src/cdk-experimental/package.json=2063150503
+src/cdk-experimental/package.json=237487315
 src/cdk/package.json=-908433069
 src/components-examples/package.json=560048349
 src/dev-app/package.json=624475908
 src/e2e-app/package.json=-1971485006
 src/google-maps/package.json=-886415500
 src/material-date-fns-adapter/package.json=-332076964
-src/material-experimental/package.json=592784609
+src/material-experimental/package.json=1822916455
 src/material-luxon-adapter/package.json=-199007660
 src/material-moment-adapter/package.json=-1407689629
 src/material/package.json=-1237533685

WORKSPACE

@@ -167,9 +167,10 @@ npm_translate_lock(
         "@angular/animations": "node ../../@nginfra/angular-linking/index.mjs",
         "@angular/common": "node ../../@nginfra/angular-linking/index.mjs",
         "@angular/forms": "node ../../@nginfra/angular-linking/index.mjs",
+        "@angular/localize": "node ../../@nginfra/angular-linking/index.mjs",
         "@angular/platform-browser": "node ../../@nginfra/angular-linking/index.mjs",
+        "@angular/platform-server": "node ../../@nginfra/angular-linking/index.mjs",
         "@angular/router": "node ../../@nginfra/angular-linking/index.mjs",
-        "@angular/localize": "node ../../@nginfra/angular-linking/index.mjs",
     },
     data = [
         "//:package.json",
@@ -191,6 +192,17 @@ npm_translate_lock(
         "//src/youtube-player:package.json",
     ],
     npmrc = "//:.npmrc",
+    package_visibility = {
+        "@angular/cdk": ["//integration:__subpackages__"],
+        "@angular/cdk-experimental": ["//integration:__subpackages__"],
+        "@angular/material": ["//integration:__subpackages__"],
+        "@angular/material-experimental": ["//integration:__subpackages__"],
+        "@angular/google-maps": ["//integration:__subpackages__"],
+        "@angular/youtube-player": ["//integration:__subpackages__"],
+        "@angular/material-moment-adapter": ["//integration:__subpackages__"],
+        "@angular/material-date-fns-adapter": ["//integration:__subpackages__"],
+        "@angular/material-luxon-adapter": ["//integration:__subpackages__"],
+    },
     pnpm_lock = "//:pnpm-lock.yaml",
     update_pnpm_lock = True,
     verify_node_modules_ignored = "//:.bazelignore",
@@ -238,7 +250,7 @@ load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
 
 git_repository(
     name = "devinfra",
-    commit = "b9bcdb3f9dff85fbfe8d1ca1d95531ddfe475f80",
+    commit = "492cc1f5295d3ededcd6b226354a1e2924c64246",
     remote = "https://github.com/angular/dev-infra.git",
 )
 
@@ -252,7 +264,7 @@ setup_dependencies_2()
 
 git_repository(
     name = "rules_angular",
-    commit = "92127883c3a3714e63782a51bac1a7c03ec8b0f5",
+    commit = "60d0dbdf18224f5167da1a43f4de9c4cb717b593",
     remote = "https://github.com/devversion/rules_angular.git",
 )
 

package.json

@@ -65,8 +65,8 @@
     "date-fns": "^4.1.0",
     "luxon": "^3.0.0",
     "moment": "^2.29.1",
-    "rxjs-tslint-rules": "^4.34.8",
     "rxjs": "^6.6.7",
+    "rxjs-tslint-rules": "^4.34.8",
     "tslib": "^2.3.1",
     "zone.js": "~0.15.0"
   },
@@ -226,6 +226,11 @@
         "dependencies": {
           "@nginfra/angular-linking": "1.0.6"
         }
+      },
+      "@angular/platform-server": {
+        "dependencies": {
+          "@nginfra/angular-linking": "1.0.6"
+        }
       }
     }
   }

pnpm-lock.yaml

@@ -5,6 +5,7 @@ load("//src/cdk:config.bzl", "CDK_ENTRYPOINTS")
 load("//src/material:config.bzl", "MATERIAL_ENTRYPOINTS", "MATERIAL_TESTING_ENTRYPOINTS")
 load("//tools/dgeni:index.bzl", "dgeni_api_docs")
 load("//tools:defaults2.bzl", "ts_project")
+load("@aspect_rules_js//js:defs.bzl", "js_library")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -37,6 +38,11 @@ copy_to_bin(
     srcs = ["package.json"],
 )
 
+js_library(
+    name = "esbuild-linked-config",
+    srcs = ["esbuild-linked.config.mjs"],
+)
+
 dgeni_api_docs(
     name = "api-docs",
     srcs = apiSourceFiles + [

src/BUILD.bazel

@@ -2,7 +2,7 @@ load("//src/cdk-experimental:config.bzl", "CDK_EXPERIMENTAL_TARGETS")
 load("//tools:defaults.bzl", "ng_package")
 load("//tools:defaults2.bzl", "ts_project")
 load("//tools/bazel:legacy_target.bzl", "get_legacy_label")
-load("@npm2//defs:bzl", "npm_link_all_packages")
+load("@npm2//:defs.bzl", "npm_link_all_packages")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -21,6 +21,13 @@ ng_package(
     name = "npm_package",
     package_name = "@angular/cdk-experimental",
     srcs = ["package.json"],
+    package_deps = [":node_modules/@angular/cdk"],
     tags = ["release-package"],
+    visibility = [
+        "//:__pkg__",
+        "//goldens:__pkg__",
+        "//integration:__subpackages__",
+        "//src/material-experimental:__subpackages__",
+    ],
     deps = [get_legacy_label(t) for t in CDK_EXPERIMENTAL_TARGETS],
 )

src/cdk-experimental/BUILD.bazel

@@ -15,6 +15,9 @@
     "@angular/cdk": "0.0.0-PLACEHOLDER",
     "@angular/core": "0.0.0-NG"
   },
+  "devDependencies": {
+    "@angular/cdk": "workspace:*"
+  },
   "dependencies": {
     "tslib": "^2.3.0"
   },

src/cdk-experimental/package.json

@@ -63,6 +63,11 @@ ng_package(
         "//src/cdk/schematics:npm_package",
     ],
     tags = ["release-package"],
+    visibility = [
+        "//:__pkg__",
+        "//goldens:__pkg__",
+        "//integration:__subpackages__",
+    ],
     deps = [get_legacy_label(t) for t in CDK_TARGETS],
 )
 

src/cdk/BUILD.bazel

@@ -1,9 +1,8 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "copy_to_bin")
-load("//tools:defaults.bzl", "jasmine_node_test")
-load("//tools:defaults2.bzl", "npm_package", "ts_project")
+load("//tools:defaults2.bzl", "jasmine_test", "npm_package", "ts_project")
 load("@aspect_rules_ts//ts:defs.bzl", rules_js_tsconfig = "ts_config")
 
-package(default_visibility = ["//visibility:public"])
+package(default_visibility = [":__subpackages__"])
 
 copy_to_bin(
     name = "schematics_assets",
@@ -63,6 +62,10 @@ npm_package(
         ":schematics_assets",
     ],
     package = "@angular/cdk/schematics",
+    visibility = [
+        "//src/cdk:__pkg__",
+        "//src/material/schematics:__pkg__",
+    ],
 )
 
 ts_project(
@@ -91,10 +94,10 @@ ts_project(
     ],
 )
 
-jasmine_node_test(
+jasmine_test(
     name = "unit_tests",
-    srcs = [":unit_test_sources_legacy"],
     data = [
         ":schematics_assets",
+        ":unit_test_sources",
     ],
 )

src/cdk/schematics/BUILD.bazel

@@ -27,8 +27,6 @@ setDefaultService(
   new ServiceBuilder(chromeDriver).enableVerboseLogging().loggingTo('/tmp/test.txt').build(),
 );
 
-process.env['CHROMEDRIVER_EXE'] = chromeDriver;
-
 // Kagekiri is available globally in the browser. We declare it here so we can use it in the
 // browser-side script passed to `By.js`.
 declare const kagekiri: {

src/cdk/testing/tests/webdriver.e2e.spec.ts

@@ -4,9 +4,12 @@ load("//tools/package-docs-content:index.bzl", "package_docs_content")
 load(":config.bzl", "ALL_EXAMPLES")
 load("//tools:defaults2.bzl", "ng_project")
 load("//tools/bazel:legacy_target.bzl", "get_legacy_label")
+load("@npm2//:defs.bzl", "npm_link_all_packages")
 
 package(default_visibility = ["//visibility:public"])
 
+npm_link_all_packages()
+
 ng_project(
     name = "components-examples",
     srcs = glob(
@@ -59,11 +62,13 @@ package_docs_content(
 
 ng_package(
     name = "npm_package",
+    package_name = "@angular/components-examples",
     srcs = ["package.json"],
     # this is a workaround to store a tree artifact in the ng_package.
     # ng_package does not properly handle tree artifacts currently so we escalate to nested_packages
     nested_packages = [":docs-content"],
     tags = ["docs-package"],
+    visibility = ["//visibility:private"],
     deps = [":components-examples_legacy"] + [get_legacy_label(t) for t in ALL_EXAMPLES],
 )
 

src/components-examples/BUILD.bazel

@@ -1,16 +1,20 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "pkg_web")
-load("//tools:defaults.bzl", "devmode_esbuild", "esbuild_config", "http_server", "sass_binary")
-load("//src/components-examples:config.bzl", "ALL_EXAMPLES")
-load("//tools/angular:index.bzl", "LINKER_PROCESSED_FW_PACKAGES")
+load("//tools:defaults.bzl", "http_server", "sass_binary")
 load("//tools:defaults2.bzl", "ng_project")
+load("@npm2//:defs.bzl", "npm_link_all_packages")
+load("@aspect_rules_esbuild//esbuild:defs.bzl", "esbuild")
+load("//src/components-examples:config.bzl", "ALL_EXAMPLES")
 
 package(default_visibility = ["//visibility:public"])
 
+npm_link_all_packages()
+
 ng_project(
     name = "dev-app",
     srcs = [
         "dev-app.ts",
         "main.ts",
+        "polyfills.ts",
         "routes.ts",
     ],
     deps = [
@@ -91,24 +95,25 @@ ng_project(
     ],
 )
 
-esbuild_config(
-    name = "esbuild_config",
-    config_file = "esbuild.config.mjs",
-)
-
-devmode_esbuild(
+esbuild(
     name = "bundles",
-    config = ":esbuild_config",
-    entry_points = [":main.ts"] + ["%s:index.ts" % e for e in ALL_EXAMPLES],
+    srcs = [
+        "//src:build-tsconfig",
+    ],
+    bundle = True,
+    config = "//src:esbuild-linked-config",
+    entry_points = [
+        ":main.js",
+        ":polyfills.js",
+    ] + ["%s:index.js" % e for e in ALL_EXAMPLES],
+    minify = True,
     platform = "browser",
     splitting = True,
     # We cannot use `ES2017` or higher as that would result in `async/await` not being downleveled.
     # ZoneJS needs to be able to intercept these as otherwise change detection would not work properly.
     target = "es2016",
-    # Note: We add all linker-processed FW packages as dependencies here so that ESBuild will
-    # map all framework packages to their linker-processed bundles from `tools/angular`.
-    deps = LINKER_PROCESSED_FW_PACKAGES + [
-        ":dev-app_legacy",
+    deps = ALL_EXAMPLES + [
+        ":dev-app",
     ],
 )
 

src/dev-app/BUILD.bazel

@@ -6,7 +6,5 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-export default {
-  resolveExtensions: ['.js'],
-  format: 'esm',
-};
+// Load `$localize` for examples using it.
+import '@angular/localize/init';