fix(menu): remove pointer-events from disabled mat-menu for consistent behavior

Author: mistrykaran91

Diff for: src/material/menu/_m2-menu.scss

@@ -20,26 +20,31 @@ $prefix: (mat, menu);
     item-with-icon-leading-spacing: 16px,
     item-with-icon-trailing-spacing: 16px,
     container-elevation-shadow: elevation.get-box-shadow(8),
-
     // Unused
-    base-elevation-level: null,
+    base-elevation-level: null
   );
 }
 
 // Tokens that can be configured through Angular Material's color theming API.
 @function get-color-tokens($theme) {
   $is-dark: inspection.get-theme-type($theme) == dark;
-  $active-state-layer-color: inspection.get-theme-color($theme, foreground, base,
-    if($is-dark, 0.08, 0.04));
+  $active-state-layer-color: inspection.get-theme-color(
+    $theme,
+    foreground,
+    base,
+    if($is-dark, 0.08, 0.04)
+  );
+  $disabled-background: inspection.get-theme-color($theme, foreground, disabled-button);
   $text-color: inspection.get-theme-color($theme, foreground, text);
 
   @return (
     item-label-text-color: $text-color,
     item-icon-color: $text-color,
     item-hover-state-layer-color: $active-state-layer-color,
+    item-disabled-hover-state-layer-color: $disabled-background,
     item-focus-state-layer-color: $active-state-layer-color,
     container-color: inspection.get-theme-color($theme, background, card),
-    divider-color: inspection.get-theme-color($theme, foreground, divider),
+    divider-color: inspection.get-theme-color($theme, foreground, divider)
   );
 }
 
@@ -50,7 +55,7 @@ $prefix: (mat, menu);
     item-label-text-size: inspection.get-theme-typography($theme, body-1, font-size),
     item-label-text-tracking: inspection.get-theme-typography($theme, body-1, letter-spacing),
     item-label-text-line-height: inspection.get-theme-typography($theme, body-1, line-height),
-    item-label-text-weight: inspection.get-theme-typography($theme, body-1, font-weight),
+    item-label-text-weight: inspection.get-theme-typography($theme, body-1, font-weight)
   );
 }
 
@@ -63,9 +68,9 @@ $prefix: (mat, menu);
 // This is used to create token slots.
 @function get-token-slots() {
   @return sass-utils.deep-merge-all(
-      get-unthemable-tokens(),
-      get-color-tokens(m2-utils.$placeholder-color-config),
-      get-typography-tokens(m2-utils.$placeholder-typography-config),
-      get-density-tokens(m2-utils.$placeholder-density-config)
+    get-unthemable-tokens(),
+    get-color-tokens(m2-utils.$placeholder-color-config),
+    get-typography-tokens(m2-utils.$placeholder-typography-config),
+    get-density-tokens(m2-utils.$placeholder-density-config)
   );
 }

Diff for: src/material/menu/_m3-menu.scss

@@ -23,21 +23,24 @@ $prefix: (mat, menu);
       item-icon-color: map.get($systems, md-sys-color, on-surface-variant),
       item-icon-size: m3-utils.hardcode(24px, $exclude-hardcoded),
       item-hover-state-layer-color: sass-utils.safe-color-change(
-        map.get($systems, md-sys-color, on-surface),
-        $alpha: map.get($systems, md-sys-state, hover-state-layer-opacity)
-      ),
+          map.get($systems, md-sys-color, on-surface),
+          $alpha: map.get($systems, md-sys-state, hover-state-layer-opacity)
+        ),
+      item-disabled-hover-state-layer-color: sass-utils.safe-color-change(
+          map.get($systems, md-sys-color, n-surface),
+          $alpha: 0.38
+        ),
       item-focus-state-layer-color: sass-utils.safe-color-change(
-        map.get($systems, md-sys-color, on-surface),
-        $alpha: map.get($systems, md-sys-state, focus-state-layer-opacity)
-      ),
+          map.get($systems, md-sys-color, on-surface),
+          $alpha: map.get($systems, md-sys-state, focus-state-layer-opacity)
+        ),
       item-spacing: m3-utils.hardcode(12px, $exclude-hardcoded),
       item-leading-spacing: m3-utils.hardcode(12px, $exclude-hardcoded),
       item-trailing-spacing: m3-utils.hardcode(12px, $exclude-hardcoded),
       item-with-icon-leading-spacing: m3-utils.hardcode(12px, $exclude-hardcoded),
       item-with-icon-trailing-spacing: m3-utils.hardcode(12px, $exclude-hardcoded),
       container-color: map.get($systems, md-sys-color, surface-container),
-      container-elevation-shadow: m3-utils.hardcode(
-        elevation.get-box-shadow(2), $exclude-hardcoded),
+      container-elevation-shadow: m3-utils.hardcode(elevation.get-box-shadow(2), $exclude-hardcoded),
     )
   );
 

Diff for: src/material/menu/menu.scss

@@ -180,7 +180,6 @@ mat-menu {
   &[disabled] {
     cursor: default;
     opacity: 0.38;
-    pointer-events: none;
 
     // The browser prevents clicks on disabled buttons from propagating which prevents the menu
     // from closing, but clicks on child nodes still propagate which is inconsistent (see #16694).
@@ -201,7 +200,7 @@ mat-menu {
         pointer-events: auto;
 
         &:hover {
-          background-color: token-utils.slot(item-hover-state-layer-color);
+          background-color: token-utils.slot(item-disabled-hover-state-layer-color);
         }
 
         &.cdk-program-focused,