Skip to content

Commit 49f2ed1

Browse files
devversionmmalerba
authored andcommitted
test: disambiguate MDC component test names (#17674)
Currently the MDC-based component tests are copied from the non-MDC based component. The top-level describe name has not be changed to contain MDC in the most cases. This causes duplicate tests and it's difficult to tell from which component a test failure originates from.
1 parent 320f387 commit 49f2ed1

23 files changed

+24
-24
lines changed

Diff for: src/material-experimental/mdc-button/button.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {MatButtonModule, MatButton} from './index';
55
import {MatRipple, ThemePalette} from '@angular/material/core';
66

77

8-
describe('MatButton', () => {
8+
describe('MDC-based MatButton', () => {
99

1010
beforeEach(async(() => {
1111
TestBed.configureTestingModule({

Diff for: src/material-experimental/mdc-checkbox/checkbox.e2e.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import {browser, by, element, Key} from 'protractor';
22

3-
describe('MDC checkbox', () => {
3+
describe('MDC-based checkbox', () => {
44
describe('check behavior', () => {
55
beforeEach(async () => await browser.get('/mdc-checkbox'));
66

Diff for: src/material-experimental/mdc-checkbox/checkbox.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {
1818
import {MAT_CHECKBOX_DEFAULT_OPTIONS} from '@angular/material/checkbox';
1919

2020

21-
describe('MatCheckbox', () => {
21+
describe('MDC-based MatCheckbox', () => {
2222
let fixture: ComponentFixture<any>;
2323

2424
function createComponent<T>(componentType: Type<T>, extraDeclarations: Type<any>[] = []) {

Diff for: src/material-experimental/mdc-chips/chip-grid.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ import {
4646
} from './index';
4747

4848

49-
describe('MatChipGrid', () => {
49+
describe('MDC-based MatChipGrid', () => {
5050
let fixture: ComponentFixture<any>;
5151
let chipGridDebugElement: DebugElement;
5252
let chipGridNativeElement: HTMLElement;

Diff for: src/material-experimental/mdc-chips/chip-input.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import {
2222
} from './index';
2323

2424

25-
describe('MatChipInput', () => {
25+
describe('MDC-based MatChipInput', () => {
2626
let fixture: ComponentFixture<any>;
2727
let testChipInput: TestChipInput;
2828
let inputDebugElement: DebugElement;

Diff for: src/material-experimental/mdc-chips/chip-listbox.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import {Subject} from 'rxjs';
3131
import {MatChip, MatChipListbox, MatChipOption, MatChipsModule} from './index';
3232

3333

34-
describe('MatChipListbox', () => {
34+
describe('MDC-based MatChipListbox', () => {
3535
let fixture: ComponentFixture<any>;
3636
let chipListboxDebugElement: DebugElement;
3737
let chipListboxNativeElement: HTMLElement;

Diff for: src/material-experimental/mdc-chips/chip-option.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515
} from './index';
1616

1717

18-
describe('Option Chips', () => {
18+
describe('MDC-based Option Chips', () => {
1919
let fixture: ComponentFixture<any>;
2020
let chipDebugElement: DebugElement;
2121
let chipNativeElement: HTMLElement;

Diff for: src/material-experimental/mdc-chips/chip-remove.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {By} from '@angular/platform-browser';
44
import {async, ComponentFixture, TestBed} from '@angular/core/testing';
55
import {MatChip, MatChipsModule} from './index';
66

7-
describe('Chip Remove', () => {
7+
describe('MDC-based Chip Remove', () => {
88
let fixture: ComponentFixture<TestChip>;
99
let testChip: TestChip;
1010
let chipDebugElement: DebugElement;

Diff for: src/material-experimental/mdc-chips/chip-row.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {Subject} from 'rxjs';
1313
import {MatChipEvent, MatChipGrid, MatChipRow, MatChipsModule} from './index';
1414

1515

16-
describe('Row Chips', () => {
16+
describe('MDC-based Row Chips', () => {
1717
let fixture: ComponentFixture<any>;
1818
let chipDebugElement: DebugElement;
1919
let chipNativeElement: HTMLElement;

Diff for: src/material-experimental/mdc-chips/chip-set.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {By} from '@angular/platform-browser';
55
import {MatChip, MatChipSet, MatChipsModule} from './index';
66

77

8-
describe('MatChipSet', () => {
8+
describe('MDC-based MatChipSet', () => {
99
beforeEach(async(() => {
1010
TestBed.configureTestingModule({
1111
imports: [MatChipsModule, CommonModule],

Diff for: src/material-experimental/mdc-chips/chip.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {Subject} from 'rxjs';
88
import {MatChip, MatChipEvent, MatChipSet, MatChipsModule} from './index';
99

1010

11-
describe('MatChip', () => {
11+
describe('MDC-based MatChip', () => {
1212
let fixture: ComponentFixture<any>;
1313
let chipDebugElement: DebugElement;
1414
let chipNativeElement: HTMLElement;

Diff for: src/material-experimental/mdc-menu/menu.e2e.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
const presenceOf = ExpectedConditions.presenceOf;
1111
const not = ExpectedConditions.not;
1212

13-
describe('menu', () => {
13+
describe('MDC-based menu', () => {
1414
const menuSelector = '.mat-mdc-menu-panel';
1515
const page = {
1616
menu: () => element(by.css(menuSelector)),

Diff for: src/material-experimental/mdc-menu/menu.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ import {
4444

4545
const MENU_PANEL_TOP_PADDING = 8;
4646

47-
describe('MatMenu', () => {
47+
describe('MDC-based MatMenu', () => {
4848
let overlayContainer: OverlayContainer;
4949
let overlayContainerElement: HTMLElement;
5050
let focusMonitor: FocusMonitor;

Diff for: src/material-experimental/mdc-progress-bar/progress-bar.e2e.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {browser} from 'protractor';
22
import {expectToExist} from '@angular/cdk/testing/private/e2e';
33

4-
describe('progress-bar', () => {
4+
describe('MDC-based progress-bar', () => {
55
beforeEach(async () => await browser.get('/mdc-progress-bar'));
66

77
it('should render a determinate progress bar', async () => {

Diff for: src/material-experimental/mdc-progress-bar/progress-bar.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {MatProgressBarModule} from './index';
77
import {MatProgressBar} from './progress-bar';
88

99

10-
describe('MatProgressBar', () => {
10+
describe('MDC-based MatProgressBar', () => {
1111
function createComponent<T>(componentType: Type<T>,
1212
imports?: Array<Type<{}>>): ComponentFixture<T> {
1313
TestBed.configureTestingModule({

Diff for: src/material-experimental/mdc-slide-toggle/slide-toggle.e2e.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {browser, element, by, Key} from 'protractor';
22
import {expectToExist} from '@angular/cdk/testing/private/e2e';
33

44

5-
describe('slide-toggle', () => {
5+
describe('MDC-based slide-toggle', () => {
66
const getInput = () => element(by.css('#normal-slide-toggle input'));
77
const getNormalToggle = () => element(by.css('#normal-slide-toggle'));
88

Diff for: src/material-experimental/mdc-slide-toggle/slide-toggle.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {By} from '@angular/platform-browser';
77
import {MatSlideToggle, MatSlideToggleChange, MatSlideToggleModule} from './index';
88
import {MAT_SLIDE_TOGGLE_DEFAULT_OPTIONS} from './slide-toggle-config';
99

10-
describe('MatSlideToggle without forms', () => {
10+
describe('MDC-based MatSlideToggle without forms', () => {
1111
beforeEach(fakeAsync(() => {
1212
TestBed.configureTestingModule({
1313
imports: [MatSlideToggleModule, BidiModule],
@@ -390,7 +390,7 @@ describe('MatSlideToggle without forms', () => {
390390
});
391391
});
392392

393-
describe('MatSlideToggle with forms', () => {
393+
describe('MDC-based MatSlideToggle with forms', () => {
394394

395395
beforeEach(fakeAsync(() => {
396396
TestBed.configureTestingModule({

Diff for: src/material-experimental/mdc-slider/slider.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import {FormControl, FormsModule, ReactiveFormsModule} from '@angular/forms';
2525
import {By} from '@angular/platform-browser';
2626
import {MatSlider, MatSliderModule} from './index';
2727

28-
describe('MatMdcSlider', () => {
28+
describe('MDC-based MatSlider', () => {
2929
const platform = new Platform();
3030

3131
function createComponent<T>(component: Type<T>): ComponentFixture<T> {

Diff for: src/material-experimental/mdc-tabs/tab-body.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {MatTabBody, MatTabBodyPortal} from './tab-body';
99
import {Subject} from 'rxjs';
1010

1111

12-
describe('MatTabBody', () => {
12+
describe('MDC-based MatTabBody', () => {
1313
let dir: Direction = 'ltr';
1414
let dirChange: Subject<Direction> = new Subject<Direction>();
1515

Diff for: src/material-experimental/mdc-tabs/tab-group.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {Observable} from 'rxjs';
99
import {MAT_TABS_CONFIG, MatTab, MatTabGroup, MatTabHeaderPosition, MatTabsModule} from './index';
1010

1111

12-
describe('MatTabGroup', () => {
12+
describe('MDC-based MatTabGroup', () => {
1313
beforeEach(fakeAsync(() => {
1414
TestBed.configureTestingModule({
1515
imports: [MatTabsModule, CommonModule, NoopAnimationsModule],

Diff for: src/material-experimental/mdc-tabs/tab-header.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import {Subject} from 'rxjs';
2626
import {ObserversModule, MutationObserverFactory} from '@angular/cdk/observers';
2727

2828

29-
describe('MatTabHeader', () => {
29+
describe('MDC-based MatTabHeader', () => {
3030
let dir: Direction = 'ltr';
3131
let change = new Subject();
3232
let fixture: ComponentFixture<SimpleTabHeaderApp>;

Diff for: src/material-experimental/mdc-tabs/tab-nav-bar/tab-nav-bar.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {BrowserAnimationsModule} from '@angular/platform-browser/animations';
1111
import {MAT_TABS_CONFIG} from '../index';
1212

1313

14-
describe('MatTabNavBar', () => {
14+
describe('MDC-based MatTabNavBar', () => {
1515
let dir: Direction = 'ltr';
1616
let dirChange = new Subject();
1717
let globalRippleOptions: RippleGlobalOptions;

Diff for: src/material-experimental/mdc-tabs/tabs.e2e.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
} from 'protractor';
99
import {pressKeys} from '@angular/cdk/testing/private/e2e';
1010

11-
describe('MDC tabs', () => {
11+
describe('MDC-based tabs', () => {
1212
describe('basic behavior', () => {
1313
let tabLabels: ElementArrayFinder;
1414
let tabBodies: ElementArrayFinder;

0 commit comments

Comments
 (0)