Skip to content

Commit 63e3c4a

Browse files
committed
build: remove linker tests that are superseded by integration test
We have an integration linker test that verifies the linker better. The tests currently aren't verifying anything.
1 parent 34e4102 commit 63e3c4a

File tree

4 files changed

+0
-109
lines changed

4 files changed

+0
-109
lines changed

.bazelrc

-5
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,6 @@ build:release --stamp
5858
build:snapshot-build --workspace_status_command="pnpm -s ng-dev:stamp --mode=snapshot"
5959
build:snapshot-build --stamp
6060

61-
####################################
62-
# Bazel custom flags #
63-
####################################
64-
build --flag_alias=partial_compilation=@rules_angular//src/ng_project/config:partial_compilation
65-
6661
##################################
6762
# Always enable Ivy compilation #
6863
##################################

.github/workflows/ci.yml

-46
Original file line numberDiff line numberDiff line change
@@ -120,52 +120,6 @@ jobs:
120120
JOB_NAME: 'Integration test'
121121
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
122122

123-
linker_aot_tests:
124-
runs-on: ubuntu-latest-4core
125-
steps:
126-
- name: Initialize environment
127-
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e4bf37af223483ce00f9316d227fd62cd744dc4b
128-
with:
129-
cache-node-modules: true
130-
- name: Setup Bazel
131-
uses: angular/dev-infra/github-actions/bazel/setup@e4bf37af223483ce00f9316d227fd62cd744dc4b
132-
- name: Setup Bazel RBE
133-
uses: angular/dev-infra/github-actions/bazel/configure-remote@e4bf37af223483ce00f9316d227fd62cd744dc4b
134-
with:
135-
google_credential: ${{ secrets.RBE_TRUSTED_BUILDS_USER }}
136-
- name: Install node modules
137-
run: pnpm install --frozen-lockfile
138-
- name: Run linker AOT tests
139-
run: pnpm test-linker-aot
140-
- uses: ./.github/actions/slack
141-
if: failure()
142-
with:
143-
JOB_NAME: 'Link AOT test'
144-
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
145-
146-
linker_jit_tests:
147-
runs-on: ubuntu-latest-4core
148-
steps:
149-
- name: Initialize environment
150-
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e4bf37af223483ce00f9316d227fd62cd744dc4b
151-
with:
152-
cache-node-modules: true
153-
- name: Setup Bazel
154-
uses: angular/dev-infra/github-actions/bazel/setup@e4bf37af223483ce00f9316d227fd62cd744dc4b
155-
- name: Setup Bazel RBE
156-
uses: angular/dev-infra/github-actions/bazel/configure-remote@e4bf37af223483ce00f9316d227fd62cd744dc4b
157-
with:
158-
google_credential: ${{ secrets.RBE_TRUSTED_BUILDS_USER }}
159-
- name: Install node modules
160-
run: pnpm install --frozen-lockfile
161-
- name: Run linker JIT tests
162-
run: pnpm test-linker-jit
163-
- uses: ./.github/actions/slack
164-
if: failure()
165-
with:
166-
JOB_NAME: 'Link JIT test'
167-
SLACK_BOT_TOKEN: ${{ secrets.ANGULAR_ROBOT_SLACK_TOKEN }}
168-
169123
test:
170124
runs-on: ubuntu-latest-16core
171125
steps:

.github/workflows/pr.yml

-32
Original file line numberDiff line numberDiff line change
@@ -99,38 +99,6 @@ jobs:
9999
- name: Run integration tests
100100
run: pnpm integration-tests
101101

102-
linker_aot_tests:
103-
runs-on: ubuntu-latest-4core
104-
steps:
105-
- name: Initialize environment
106-
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e4bf37af223483ce00f9316d227fd62cd744dc4b
107-
with:
108-
cache-node-modules: true
109-
- name: Setup Bazel
110-
uses: angular/dev-infra/github-actions/bazel/setup@e4bf37af223483ce00f9316d227fd62cd744dc4b
111-
- name: Setup Bazel RBE
112-
uses: angular/dev-infra/github-actions/bazel/configure-remote@e4bf37af223483ce00f9316d227fd62cd744dc4b
113-
- name: Install node modules
114-
run: pnpm install --frozen-lockfile
115-
- name: Run linker AOT tests
116-
run: pnpm test-linker-aot
117-
118-
linker_jit_tests:
119-
runs-on: ubuntu-latest-4core
120-
steps:
121-
- name: Initialize environment
122-
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@e4bf37af223483ce00f9316d227fd62cd744dc4b
123-
with:
124-
cache-node-modules: true
125-
- name: Setup Bazel
126-
uses: angular/dev-infra/github-actions/bazel/setup@e4bf37af223483ce00f9316d227fd62cd744dc4b
127-
- name: Setup Bazel RBE
128-
uses: angular/dev-infra/github-actions/bazel/configure-remote@e4bf37af223483ce00f9316d227fd62cd744dc4b
129-
- name: Install node modules
130-
run: pnpm install --frozen-lockfile
131-
- name: Run linker JIT tests
132-
run: pnpm test-linker-jit
133-
134102
test:
135103
runs-on: ubuntu-latest-16core
136104
steps:

tools/BUILD.bazel

-26
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
21
load("@aspect_rules_ts//ts:defs.bzl", rules_js_tsconfig = "ts_config")
32

43
package(default_visibility = ["//visibility:public"])
@@ -18,31 +17,6 @@ rules_js_tsconfig(
1817
],
1918
)
2019

21-
# Bazel config setting that matches if the partial compilation is enabled.
22-
config_setting(
23-
name = "partial_compilation_enabled",
24-
flag_values = {
25-
"@rules_angular//src/ng_project/config:partial_compilation": "True",
26-
},
27-
)
28-
29-
# Command line flag that can be specified to force the JIT compilation to be used for tests
30-
# with partial compilation. By default, tests are processed with the linker at build time.
31-
bool_flag(
32-
name = "force_partial_jit_compilation",
33-
build_setting_default = False,
34-
)
35-
36-
# Config setting that matches if the force JIT compilation build setting is enabled.
37-
# This setting needs to be used in combination of the partial compilation build setting.
38-
config_setting(
39-
name = "force_partial_jit_compilation_enabled",
40-
flag_values = {
41-
"@rules_angular//src/ng_project/config:partial_compilation": "True",
42-
":force_partial_jit_compilation": "True",
43-
},
44-
)
45-
4620
# Detect if the build is running with stamping enabled.
4721
config_setting(
4822
name = "stamp",

0 commit comments

Comments
 (0)