Skip to content

Commit 7202d5c

Browse files
committed
Addressed comments
1 parent eed8a03 commit 7202d5c

File tree

3 files changed

+9
-14
lines changed

3 files changed

+9
-14
lines changed

Diff for: src/cdk-experimental/tabs/tabs.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export class CdkTablist {
9696
});
9797

9898
/** The Tab UIPatterns of the child Tabs. */
99-
protected items = computed(() => this._cdkTabs().map(tab => tab.pattern));
99+
protected tabs = computed(() => this._cdkTabs().map(tab => tab.pattern));
100100

101101
/** Whether the tablist is vertically or horizontally oriented. */
102102
orientation = input<'vertical' | 'horizontal'>('horizontal');
@@ -125,7 +125,7 @@ export class CdkTablist {
125125
/** The Tablist UIPattern. */
126126
pattern: TablistPattern = new TablistPattern({
127127
...this,
128-
items: this.items,
128+
items: this.tabs,
129129
textDirection: this.textDirection,
130130
});
131131
}

Diff for: src/cdk-experimental/ui-patterns/tabs/tab.ts

+4-9
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,11 @@
77
*/
88

99
import {computed, Signal} from '@angular/core';
10-
import {ListSelection, ListSelectionItem} from '../behaviors/list-selection/list-selection';
11-
import {ListNavigation, ListNavigationItem} from '../behaviors/list-navigation/list-navigation';
12-
import {ListFocus, ListFocusItem} from '../behaviors/list-focus/list-focus';
10+
import {ListSelectionItem} from '../behaviors/list-selection/list-selection';
11+
import {ListNavigationItem} from '../behaviors/list-navigation/list-navigation';
12+
import {ListFocusItem} from '../behaviors/list-focus/list-focus';
1313
import {TabpanelPattern} from './tabpanel';
14-
15-
interface TablistPattern {
16-
focusManager: ListFocus<TabPattern>;
17-
selection: ListSelection<TabPattern>;
18-
navigation: ListNavigation<TabPattern>;
19-
}
14+
import {TablistPattern} from './tablist';
2015

2116
/** The required inputs to tabs. */
2217
export interface TabInputs extends ListNavigationItem, ListSelectionItem, ListFocusItem {

Diff for: src/cdk-experimental/ui-patterns/tabs/tabpanel.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ export class TabpanelPattern {
2626
/** Whether the tabpanel is hidden. */
2727
hidden = computed(() => !this.tab().selected());
2828

29-
constructor(args: TabpanelInputs) {
30-
this.id = args.id;
31-
this.tab = args.tab;
29+
constructor(inputs: TabpanelInputs) {
30+
this.id = inputs.id;
31+
this.tab = inputs.tab;
3232
}
3333
}

0 commit comments

Comments
 (0)