Skip to content

Commit 7faac70

Browse files
authored
docs: remove noop module from harness examples (#30899)
Removes the `NoopAnimationsModule` from the harness examples since it isn't necessary for most of them. The rest of the examples have been switched to our token for disabling animations.
1 parent 912bacd commit 7faac70

File tree

17 files changed

+20
-62
lines changed

17 files changed

+20
-62
lines changed

src/components-examples/material/autocomplete/autocomplete-harness/autocomplete-harness-example.spec.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,12 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatAutocompleteHarness} from '@angular/material/autocomplete/testing';
44
import {HarnessLoader} from '@angular/cdk/testing';
55
import {AutocompleteHarnessExample} from './autocomplete-harness-example';
6-
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
7-
import {MatAutocompleteModule} from '@angular/material/autocomplete';
86

97
describe('AutocompleteHarnessExample', () => {
108
let fixture: ComponentFixture<AutocompleteHarnessExample>;
119
let loader: HarnessLoader;
1210

1311
beforeEach(() => {
14-
TestBed.configureTestingModule({
15-
imports: [MatAutocompleteModule, NoopAnimationsModule],
16-
});
1712
fixture = TestBed.createComponent(AutocompleteHarnessExample);
1813
fixture.detectChanges();
1914
loader = TestbedHarnessEnvironment.loader(fixture);

src/components-examples/material/bottom-sheet/bottom-sheet-harness/bottom-sheet-harness-example.spec.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,15 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatBottomSheetHarness} from '@angular/material/bottom-sheet/testing';
44
import {HarnessLoader} from '@angular/cdk/testing';
55
import {BottomSheetHarnessExample} from './bottom-sheet-harness-example';
6-
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
7-
import {MatBottomSheetModule} from '@angular/material/bottom-sheet';
6+
import {MATERIAL_ANIMATIONS} from '@angular/material/core';
87

98
describe('BottomSheetHarnessExample', () => {
109
let fixture: ComponentFixture<BottomSheetHarnessExample>;
1110
let loader: HarnessLoader;
1211

1312
beforeEach(() => {
1413
TestBed.configureTestingModule({
15-
imports: [MatBottomSheetModule, NoopAnimationsModule],
14+
providers: [{provide: MATERIAL_ANIMATIONS, useValue: {animationsDisabled: true}}],
1615
});
1716
fixture = TestBed.createComponent(BottomSheetHarnessExample);
1817
fixture.detectChanges();

src/components-examples/material/datepicker/datepicker-harness/datepicker-harness-example.spec.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,16 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatDatepickerInputHarness} from '@angular/material/datepicker/testing';
44
import {HarnessLoader} from '@angular/cdk/testing';
55
import {DatepickerHarnessExample} from './datepicker-harness-example';
6-
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
7-
import {MatDatepickerModule} from '@angular/material/datepicker';
8-
import {MatNativeDateModule} from '@angular/material/core';
6+
import {MATERIAL_ANIMATIONS, MatNativeDateModule} from '@angular/material/core';
97

108
describe('DatepickerHarnessExample', () => {
119
let fixture: ComponentFixture<DatepickerHarnessExample>;
1210
let loader: HarnessLoader;
1311

1412
beforeEach(() => {
1513
TestBed.configureTestingModule({
16-
imports: [MatDatepickerModule, NoopAnimationsModule, MatNativeDateModule],
14+
imports: [MatNativeDateModule],
15+
providers: [{provide: MATERIAL_ANIMATIONS, useValue: {animationsDisabled: true}}],
1716
});
1817
fixture = TestBed.createComponent(DatepickerHarnessExample);
1918
fixture.detectChanges();

src/components-examples/material/dialog/dialog-harness/dialog-harness-example.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import {ComponentFixture, TestBed} from '@angular/core/testing';
22
import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
3+
import {MATERIAL_ANIMATIONS} from '@angular/material/core';
34
import {MatDialogHarness} from '@angular/material/dialog/testing';
45
import {HarnessLoader} from '@angular/cdk/testing';
56
import {DialogHarnessExample} from './dialog-harness-example';
6-
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
77

88
describe('DialogHarnessExample', () => {
99
let fixture: ComponentFixture<DialogHarnessExample>;
1010
let loader: HarnessLoader;
1111

1212
beforeEach(() => {
1313
TestBed.configureTestingModule({
14-
imports: [NoopAnimationsModule],
14+
providers: [{provide: MATERIAL_ANIMATIONS, useValue: {animationsDisabled: true}}],
1515
});
1616
fixture = TestBed.createComponent(DialogHarnessExample);
1717
fixture.detectChanges();

src/components-examples/material/expansion/expansion-harness/expansion-harness-example.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,13 @@ import {ComponentFixture, TestBed} from '@angular/core/testing';
22
import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatAccordionHarness, MatExpansionPanelHarness} from '@angular/material/expansion/testing';
44
import {HarnessLoader} from '@angular/cdk/testing';
5-
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
65
import {ExpansionHarnessExample} from './expansion-harness-example';
76

87
describe('ExpansionHarnessExample', () => {
98
let fixture: ComponentFixture<ExpansionHarnessExample>;
109
let loader: HarnessLoader;
1110

1211
beforeEach(() => {
13-
TestBed.configureTestingModule({
14-
imports: [NoopAnimationsModule],
15-
});
1612
fixture = TestBed.createComponent(ExpansionHarnessExample);
1713
fixture.detectChanges();
1814
loader = TestbedHarnessEnvironment.loader(fixture);

src/components-examples/material/form-field/form-field-harness/form-field-harness-example.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,13 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatFormFieldHarness} from '@angular/material/form-field/testing';
44
import {HarnessLoader} from '@angular/cdk/testing';
55
import {FormFieldHarnessExample} from './form-field-harness-example';
6-
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
76
import {MatInputHarness} from '@angular/material/input/testing';
87

98
describe('FormFieldHarnessExample', () => {
109
let fixture: ComponentFixture<FormFieldHarnessExample>;
1110
let loader: HarnessLoader;
1211

1312
beforeEach(() => {
14-
TestBed.configureTestingModule({
15-
imports: [NoopAnimationsModule],
16-
});
1713
fixture = TestBed.createComponent(FormFieldHarnessExample);
1814
fixture.detectChanges();
1915
loader = TestbedHarnessEnvironment.loader(fixture);

src/components-examples/material/input/input-harness/input-harness-example.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,12 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatInputHarness} from '@angular/material/input/testing';
44
import {HarnessLoader} from '@angular/cdk/testing';
55
import {InputHarnessExample} from './input-harness-example';
6-
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
76

87
describe('InputHarnessExample', () => {
98
let fixture: ComponentFixture<InputHarnessExample>;
109
let loader: HarnessLoader;
1110

1211
beforeEach(() => {
13-
TestBed.configureTestingModule({
14-
imports: [NoopAnimationsModule],
15-
});
1612
fixture = TestBed.createComponent(InputHarnessExample);
1713
fixture.detectChanges();
1814
loader = TestbedHarnessEnvironment.loader(fixture);

src/components-examples/material/menu/menu-harness/menu-harness-example.spec.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,16 @@ import {ComponentFixture, TestBed} from '@angular/core/testing';
22
import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatMenuHarness} from '@angular/material/menu/testing';
44
import {HarnessLoader} from '@angular/cdk/testing';
5-
import {MatMenuModule} from '@angular/material/menu';
5+
import {MATERIAL_ANIMATIONS} from '@angular/material/core';
66
import {MenuHarnessExample} from './menu-harness-example';
7-
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
87

98
describe('MenuHarnessExample', () => {
109
let fixture: ComponentFixture<MenuHarnessExample>;
1110
let loader: HarnessLoader;
1211

1312
beforeEach(() => {
1413
TestBed.configureTestingModule({
15-
imports: [MatMenuModule, NoopAnimationsModule, MenuHarnessExample],
14+
providers: [{provide: MATERIAL_ANIMATIONS, useValue: {animationsDisabled: true}}],
1615
});
1716
fixture = TestBed.createComponent(MenuHarnessExample);
1817
fixture.detectChanges();

src/components-examples/material/paginator/paginator-harness/paginator-harness-example.spec.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,13 @@ import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatPaginatorHarness} from '@angular/material/paginator/testing';
44
import {HarnessLoader} from '@angular/cdk/testing';
55
import {PaginatorHarnessExample} from './paginator-harness-example';
6-
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
7-
import {MatPaginatorModule} from '@angular/material/paginator';
86

97
describe('PaginatorHarnessExample', () => {
108
let fixture: ComponentFixture<PaginatorHarnessExample>;
119
let loader: HarnessLoader;
1210
let instance: PaginatorHarnessExample;
1311

1412
beforeEach(() => {
15-
TestBed.configureTestingModule({
16-
imports: [MatPaginatorModule, NoopAnimationsModule],
17-
});
1813
fixture = TestBed.createComponent(PaginatorHarnessExample);
1914
fixture.detectChanges();
2015
loader = TestbedHarnessEnvironment.loader(fixture);

src/components-examples/material/select/select-harness/select-harness-example.spec.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
11
import {ComponentFixture, TestBed} from '@angular/core/testing';
22
import {TestbedHarnessEnvironment} from '@angular/cdk/testing/testbed';
33
import {MatSelectHarness} from '@angular/material/select/testing';
4+
import {MATERIAL_ANIMATIONS} from '@angular/material/core';
45
import {HarnessLoader} from '@angular/cdk/testing';
56
import {SelectHarnessExample} from './select-harness-example';
6-
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
7-
import {MatSelectModule} from '@angular/material/select';
87

98
describe('SelectHarnessExample', () => {
109
let fixture: ComponentFixture<SelectHarnessExample>;
1110
let loader: HarnessLoader;
1211

1312
beforeEach(() => {
1413
TestBed.configureTestingModule({
15-
imports: [MatSelectModule, NoopAnimationsModule],
14+
providers: [{provide: MATERIAL_ANIMATIONS, useValue: {animationsDisabled: true}}],
1615
});
1716
fixture = TestBed.createComponent(SelectHarnessExample);
1817
fixture.detectChanges();

0 commit comments

Comments
 (0)