build: migrate all ts_library targets in tools/

Migrates all `ts_library` targets in `tools/` to use the `rules_js`
`ts_project` rule.

Author: devversion

Diff for: .aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx

@@ -2,7 +2,7 @@
 # Input hashes for repository rule npm_translate_lock(name = "npm2", pnpm_lock = "@//:pnpm-lock.yaml").
 # This file should be checked into version control along with the pnpm-lock.yaml file.
 .npmrc=-2023857461
-package.json=-713547691
+package.json=1433234131
 pnpm-lock.yaml=-26661838
 pnpm-workspace.yaml=1711114604
 yarn.lock=824621907

Diff for: package.json

@@ -47,7 +47,7 @@
     "integration-tests:size-test": "bazel test //integration/size-test/...",
     "test-linker-aot": "bazel test --partial_compilation --test_tag_filters=partial-compilation-integration,-firefox --build_tests_only -- //integration/... //src/...",
     "test-linker-jit": "bazel test --partial_compilation --test_tag_filters=partial-compilation-integration,-firefox --build_tests_only --//tools:force_partial_jit_compilation=True  -- //integration/... //src/...",
-    "check-tooling-setup": "yarn tsc --project tools/tsconfig.json && yarn tsc --project scripts/tsconfig.json && yarn tsc --project .ng-dev/tsconfig.json",
+    "check-tooling-setup": "yarn tsc --project tools/tsconfig.json --noEmit && yarn tsc --project scripts/tsconfig.json --noEmit && yarn tsc --project .ng-dev/tsconfig.json --noEmit",
     "tsc": "node ./node_modules/typescript/bin/tsc",
     "ci-push-deploy-docs-app": "node --no-warnings=ExperimentalWarning --loader ts-node/esm/transpile-only scripts/docs-deploy/deploy-ci-push.mts",
     "ci-docs-monitor-test": "node --no-warnings=ExperimentalWarning --loader ts-node/esm/transpile-only scripts/docs-deploy/monitoring/ci-test.mts",

Diff for: tools/BUILD.bazel

@@ -1,7 +1,23 @@
 load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
+load("@aspect_rules_ts//ts:defs.bzl", rules_js_tsconfig = "ts_config")
 
 package(default_visibility = ["//visibility:public"])
 
+rules_js_tsconfig(
+    name = "tsconfig",
+    src = "tsconfig.json",
+    deps = ["//:node_modules/@types/node"],
+)
+
+rules_js_tsconfig(
+    name = "tsconfig-test",
+    src = "tsconfig-test.json",
+    deps = [
+        ":tsconfig",
+        "//:node_modules/@types/jasmine",
+    ],
+)
+
 # Bazel config setting that matches if the partial compilation flag
 # for `@angular/bazel` is set to `True`.
 config_setting(

Diff for: tools/dgeni/BUILD.bazel

@@ -1,5 +1,5 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -16,18 +16,15 @@ nodejs_binary(
     templated_args = ["--bazel_patch_module_resolver"],
 )
 
-ts_library(
+ts_project(
     name = "sources",
     srcs = glob(["**/*.ts"]),
-    # TODO(ESM): remove this once the Bazel NodeJS rules can handle ESM with `nodejs_binary`.
-    devmode_module = "commonjs",
-    tsconfig = ":tsconfig.json",
+    tsconfig = "//tools:tsconfig",
     deps = [
-        "//tools/highlight-files:sources",
-        "@npm//@types/node",
-        "@npm//dgeni",
-        "@npm//dgeni-packages",
-        "@npm//highlight.js",
-        "@npm//typescript",
+        "//:node_modules/dgeni",
+        "//:node_modules/dgeni-packages",
+        "//:node_modules/highlight.js",
+        "//:node_modules/typescript",
+        "//tools/highlight-files:sources_rjs",
     ],
 )

Diff for: tools/example-module/BUILD.bazel

@@ -1,17 +1,14 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ts_library(
+ts_project(
     name = "example-module-lib",
     srcs = glob(["**/*.ts"]),
-    # TODO(ESM): remove this once the Bazel NodeJS rules can handle ESM with `nodejs_binary`.
-    devmode_module = "commonjs",
-    tsconfig = ":tsconfig.json",
+    tsconfig = "//tools:tsconfig",
     deps = [
-        "@npm//@types/node",
-        "@npm//typescript",
+        "//:node_modules/typescript",
     ],
 )
 

Diff for: tools/extract-tokens/BUILD.bazel

@@ -1,18 +1,15 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ts_library(
+ts_project(
     name = "extract_tokens_lib",
     srcs = glob(["**/*.ts"]),
-    # TODO(ESM): remove this once the Bazel NodeJS rules can handle ESM with `nodejs_binary`.
-    devmode_module = "commonjs",
-    tsconfig = ":tsconfig.json",
+    tsconfig = "//tools:tsconfig",
     deps = [
-        "//tools/highlight-files:sources",
-        "@npm//@types/node",
-        "@npm//sass",
+        "//:node_modules/sass",
+        "//tools/highlight-files:sources_rjs",
     ],
 )
 

Diff for: tools/highlight-files/BUILD.bazel

@@ -1,19 +1,16 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ts_library(
+ts_project(
     name = "sources",
     srcs = glob(["**/*.ts"]),
-    # TODO(ESM): remove this once the Bazel NodeJS rules can handle ESM with `nodejs_binary`.
-    devmode_module = "commonjs",
-    tsconfig = ":tsconfig.json",
+    tsconfig = "//tools:tsconfig",
     deps = [
-        "//tools/region-parser",
-        "@npm//@types/fs-extra",
-        "@npm//@types/node",
-        "@npm//fs-extra",
+        "//:node_modules/@types/fs-extra",
+        "//:node_modules/fs-extra",
+        "//tools/region-parser:region-parser_rjs",
     ],
 )
 

Diff for: tools/markdown-to-html/BUILD.bazel

@@ -1,24 +1,22 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
-load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
+load("//tools:defaults.bzl", "jasmine_node_test")
+load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ts_library(
+ts_project(
     name = "transform-markdown",
     srcs = glob(
         ["**/*.ts"],
         exclude = [
             "*.spec.ts",
         ],
     ),
-    # TODO(ESM): remove this once the Bazel NodeJS rules can handle ESM with `nodejs_binary`.
-    devmode_module = "commonjs",
-    tsconfig = ":tsconfig.json",
+    tsconfig = "//tools:tsconfig",
     deps = [
-        "//tools/highlight-files:sources",
-        "@npm//@types/marked",
-        "@npm//@types/node",
-        "@npm//marked",
+        "//:node_modules/@types/marked",
+        "//:node_modules/marked",
+        "//tools/highlight-files:sources_rjs",
     ],
 )
 
@@ -33,16 +31,16 @@ nodejs_binary(
     templated_args = ["--bazel_patch_module_resolver"],
 )
 
-ts_library(
+ts_project(
     name = "unit_test_lib",
     testonly = True,
     srcs = glob(
         ["*.spec.ts"],
     ),
-    tsconfig = ":tsconfig.json",
+    tsconfig = "//tools:tsconfig-test",
     visibility = ["//visibility:private"],
     deps = [
-        ":transform-markdown",
+        ":transform-markdown_rjs",
         "@npm//@types/jasmine",
         "@npm//@types/node",
         "@npm//marked",

Diff for: tools/markdown-to-html/docs-marked-renderer.spec.ts

@@ -7,8 +7,8 @@ describe('DocsMarkdownRenderer', () => {
   });
 
   it('generates regular headings for h1 and h2', () => {
-    expect(renderer.heading('a', 1, 'ignored')).toEqual('<h1>a</h1>');
-    expect(renderer.heading('b', 2, 'ignored')).toEqual('<h2>b</h2>');
+    expect(renderer.heading('a', 1, 'ignored')).toBe('<h1>a</h1>');
+    expect(renderer.heading('b', 2, 'ignored')).toContain('<h2 ');
   });
 
   it('creates header link for h3 and h4 headings', () => {
@@ -74,23 +74,28 @@ describe('DocsMarkdownRenderer', () => {
     const result = renderer.html(`<!-- example(
          {
           "example": "exampleName",
-          "file": "example-html.html",
+          "file": "example-html.html"
          }
         ) -->`);
     expectEqualIgnoreLeadingWhitespace(
       result,
       `<div material-docs-example="exampleName"
-          file="example-html.html"></div>`,
+          file="example-html.html"
+       ></div>`,
     );
   });
 
   it('generates html using new API with no file and no region', () => {
     const result = renderer.html(`<!-- example(
          {
-          "example": "exampleName",
+          "example": "exampleName"
          }
         ) -->`);
-    expectEqualIgnoreLeadingWhitespace(result, `<div material-docs-example="exampleName"></div>`);
+    expectEqualIgnoreLeadingWhitespace(
+      result,
+      `<div material-docs-example="exampleName"
+       ></div>`,
+    );
   });
 
   it('generates html using old API', () => {

Diff for: tools/markdown-to-html/docs-marked-renderer.ts

@@ -2,7 +2,7 @@ import {Renderer, Slugger} from 'marked';
 import {basename, extname} from 'path';
 
 /** Regular expression that matches example comments. */
-const exampleCommentRegex = /<!--\s*example\(([^)]+)\)\s*-->/g;
+const exampleCommentRegex = /<!--\s*example\(\s*([^)]+)\)\s*-->/g;
 
 /**
  * Custom renderer for marked that will be used to transform markdown files to HTML
@@ -80,7 +80,7 @@ export class DocsMarkdownRenderer extends Renderer {
     html = html.replace(exampleCommentRegex, (_match: string, content: string) => {
       // using [\s\S]* because .* does not match line breaks
       if (content.match(/\{[\s\S]*\}/g)) {
-        const {example, file, region} = JSON.parse(content) as {
+        const {example, file, region} = JSON.parse(content.trim()) as {
           example: string;
           file: string;
           region: string;

Diff for: tools/markdown-to-html/tsconfig.json

@@ -1,5 +1,5 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -15,14 +15,11 @@ nodejs_binary(
     templated_args = ["--bazel_patch_module_resolver"],
 )
 
-ts_library(
+ts_project(
     name = "sources",
     srcs = glob(["**/*.ts"]),
-    # TODO(ESM): remove this once the Bazel NodeJS rules can handle ESM with `nodejs_binary`.
-    devmode_module = "commonjs",
-    tsconfig = ":tsconfig.json",
+    tsconfig = "//tools:tsconfig",
     deps = [
-        "@npm//@types/fs-extra",
-        "@npm//@types/node",
+        "//:node_modules/@types/fs-extra",
     ],
 )

Diff for: tools/package-docs-content/BUILD.bazel

@@ -1,15 +1,14 @@
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ts_library(
+ts_project(
     name = "postcss",
     srcs = [
         "compare-nodes.ts",
     ],
-    # TODO(ESM): remove this once the Bazel NodeJS rules can handle ESM with `nodejs_binary`.
-    devmode_module = "commonjs",
+    tsconfig = "//tools:tsconfig",
     deps = [
-        "@npm//postcss",
+        "//:node_modules/postcss",
     ],
 )

Diff for: tools/package-docs-content/tsconfig.json

@@ -1,14 +1,9 @@
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ts_library(
+ts_project(
     name = "region-parser",
     srcs = glob(["**/*.ts"]),
-    # TODO(ESM): remove this once the Bazel NodeJS rules can handle ESM with `nodejs_binary`.
-    devmode_module = "commonjs",
-    tsconfig = ":tsconfig.json",
-    deps = [
-        "@npm//@types/node",
-    ],
+    tsconfig = "//tools:tsconfig",
 )

Diff for: tools/postcss/BUILD.bazel

@@ -1,22 +1,21 @@
 load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_binary")
-load("//tools:defaults.bzl", "ts_library")
+load("//tools:defaults2.bzl", "ts_project")
 
 package(default_visibility = ["//visibility:public"])
 
-ts_library(
+ts_project(
     name = "sass_lib",
     srcs = [
         "compiler-main.ts",
         "local-sass-importer.ts",
     ],
-    # TODO(ESM): remove this once the Bazel NodeJS rules can handle ESM with `nodejs_binary`.
-    devmode_module = "commonjs",
+    tsconfig = "//tools:tsconfig",
     deps = [
-        "@npm//@bazel/worker",
-        "@npm//@types/node",
-        "@npm//@types/yargs",
-        "@npm//sass",
-        "@npm//yargs",
+        "//:node_modules/@bazel/worker",
+        "//:node_modules/@types/node",
+        "//:node_modules/@types/yargs",
+        "//:node_modules/sass",
+        "//:node_modules/yargs",
     ],
 )