refactor(material/icon): provides context for undoing previous fix

essjay05 · essjay05 · commit d33010e5d8f9 · 2024-10-10T15:55:30.000Z
Updates notation to style change in icon.scss which undoes a previous bug fix for GH issue #11826. As this change is now deemed as an accessibility issue due to it being cut off/hidden. Fixes b/250063405 BREAKING CHANGE: undoes hiding icon overflow Reverts icon having its overflow visible to be more accessible.
diff --git a/src/material/icon/icon.scss b/src/material/icon/icon.scss
@@ -41,7 +41,9 @@ mat-icon {
   }
 
   // Makes button icon overflow visible to fix b/250063405
-  // Apply styles to avoid applying text-spacing to .mat-icon
+  // Undoes previous fix to Issue #11826 in preference of
+  // fixing to improve accessibility by not having the icon
+  // get cut off
   overflow: visible;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,9 @@ mat-icon {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`// Makes button icon overflow visible to fix b/250063405`
`44`		`- // Apply styles to avoid applying text-spacing to .mat-icon`
	`44`	`+ // Undoes previous fix to Issue #11826 in preference of`
	`45`	`+ // fixing to improve accessibility by not having the icon`
	`46`	`+ // get cut off`
`45`	`47`	`overflow: visible;`
`46`	`48`	`}`
`47`	`49`