-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Dialog directives not functioning as expected when opening a dialog template with a set height #12138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks like that example has some issues, but the dialog directives are working as designed. They're intended to provide the styling for that region of the dialog, but don't "stick" to the top bottom so that developers have some flexibility about how they're placed. @crisbeto can you look at that example? |
This has been an issue for a while. I have #9236 that should sort most of these out and allow us to make the buttons stick to the bottom. |
@jelbourn I was under the impression that the directives would also "stick" the title to the top as described in the API docs and similar behavior would apply to the dialog actions. But I look forward to @crisbeto's changes going through. |
Verfied that is working correctly in the MDC dialog |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Bug
What is the expected behavior?
The elements inside a dialog template should be aligned/pinned correctly when a dialog is opened with a specified height.
mat-dialog-title
directive should be pinned to the topmat-dialog-actions
directive should be pinned to the bottomWhat is the current behavior?
What are the steps to reproduce?
StackBlitz from Angular Material's Dialog documentation.
An edited StackBlitz to show a different scenario.
What is the use-case or motivation for changing an existing behavior?
The existing behavior is not consistent and does not display the expected behavior described in the documentation.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?
The text was updated successfully, but these errors were encountered: