-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Block scroll strategy for mat-select works same as noop strategy with custom scroll area in Firefox #12747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is the same issue as #12746. |
Actually, in case of Firefox it's not the same as #12746. In Firefox backdrop doesn't blocks scroll events, at least if it has zero opacity. If you try Stackblitz example in Firefox, you will see that scrolling isn't actually blocked, while scroll strategy factory returns BlockStrategy. In Chrome yes, scroll is blocked because of backdrop, but not in FIrefox. |
We did a fix for Firefox a while ago, but it seems like it got reintroduced in a later version (see crisbeto@d0ad3b7). Either way, the idea is that it's supposed to be scrollable everywhere which is what #12746 will handle. |
As i can see, #12756 is about mat-icon rendering and it is closed without related commits. |
Looks like I made a typo. It's #12746. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Bug
What is the expected behavior?
Block scroll strategy for mat-select must block scroll in closest parent scroll area when panel is opened.
What is the current behavior?
If closest parent scroll area is not document element, mat-select with opened panel and block scroll strategy behaves like it has noop scroll strategy.
What are the steps to reproduce?
https://stackblitz.com/edit/angular-material2-issue-819jcf
What is the use-case or motivation for changing an existing behavior?
Some apps can have custom scroll area and mat-select scroll strategy will not always work with them as expected.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
"@angular/core": "6.1.3", "@angular/material": "^6.4.5", macOS High Sierra 10.13.3, "typescript": "2.9.2", Firefox 61.0.2 64-bit
Is there anything else we should know?
No
The text was updated successfully, but these errors were encountered: