Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 79bf96b

Browse files
authored
fix(slider): vertical slider in a scrolled container sets value to zero on all clicks (#11801)
Fixes #11800
1 parent 6f64da6 commit 79bf96b

File tree

2 files changed

+90
-91
lines changed

2 files changed

+90
-91
lines changed

Diff for: src/components/slider/slider.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ function SliderDirective($$rAF, $window, $mdAria, $mdUtil, $mdConstant, $mdThemi
561561
element[0].focus();
562562
refreshSliderDimensions();
563563

564-
var exactVal = percentToValue(positionToPercent(vertical ? ev.pointer.y : ev.pointer.x));
564+
var exactVal = percentToValue(positionToPercent(vertical ? ev.srcEvent.clientY : ev.srcEvent.clientX));
565565
var closestVal = minMaxValidator(stepValidator(exactVal));
566566
scope.$apply(function() {
567567
setModelValue(closestVal);
@@ -573,7 +573,7 @@ function SliderDirective($$rAF, $window, $mdAria, $mdUtil, $mdConstant, $mdThemi
573573

574574
element.removeClass('md-dragging');
575575

576-
var exactVal = percentToValue(positionToPercent(vertical ? ev.pointer.y : ev.pointer.x));
576+
var exactVal = percentToValue(positionToPercent(vertical ? ev.srcEvent.clientY : ev.srcEvent.clientX));
577577
var closestVal = minMaxValidator(stepValidator(exactVal));
578578
scope.$apply(function() {
579579
setModelValue(closestVal);
@@ -603,8 +603,8 @@ function SliderDirective($$rAF, $window, $mdAria, $mdUtil, $mdConstant, $mdThemi
603603
function setSliderFromEvent(ev) {
604604
// While panning discrete, update only the
605605
// visual positioning but not the model value.
606-
if (discrete) adjustThumbPosition(vertical ? ev.pointer.y : ev.pointer.x);
607-
else doSlide(vertical ? ev.pointer.y : ev.pointer.x);
606+
if (discrete) adjustThumbPosition(vertical ? ev.srcEvent.clientY : ev.srcEvent.clientX);
607+
else doSlide(vertical ? ev.srcEvent.clientY : ev.srcEvent.clientX);
608608
}
609609

610610
/**

0 commit comments

Comments
 (0)