Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit 3f48640

Browse files
committed
chore(test): move altRoot and inferRoot test off of the control flow (#5003)
1 parent 7a0e3bd commit 3f48640

File tree

4 files changed

+16
-11
lines changed

4 files changed

+16
-11
lines changed

scripts/test.js

+3
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ var passingTests = [
99
'node built/cli.js spec/multiConf.js',
1010
// 'node built/cli.js spec/altRootConf.js',
1111
// 'node built/cli.js spec/inferRootConf.js',
12+
// 'node built/cli.js spec/multiConf.js',
13+
'node built/cli.js spec/altRootConf.js',
14+
'node built/cli.js spec/inferRootConf.js',
1215
// 'node built/cli.js spec/onCleanUpAsyncReturnValueConf.js',
1316
// 'node built/cli.js spec/onCleanUpNoReturnValueConf.js',
1417
// 'node built/cli.js spec/onCleanUpSyncReturnValueConf.js',

spec/altRoot/findelements_spec.js

+11-11
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
1-
describe('finding elements when ng-app is nested', function() {
2-
beforeEach(function() {
3-
browser.get('alt_root_index.html#/form');
1+
describe('finding elements when ng-app is nested', () => {
2+
beforeEach(async() => {
3+
await browser.get('alt_root_index.html#/form');
44
});
55

6-
it('should find an element by binding', function() {
7-
var greeting = element(by.binding('{{greeting}}'));
6+
it('should find an element by binding', async() => {
7+
const greeting = element(by.binding('{{greeting}}'));
88

9-
expect(greeting.getText()).toEqual('Hiya');
9+
expect(await greeting.getText()).toEqual('Hiya');
1010
});
1111

12-
it('should find elements outside of angular', function() {
13-
var outside = element(by.id('outside-ng'));
14-
var inside = element(by.id('inside-ng'));
12+
it('should find elements outside of angular', async() => {
13+
const outside = element(by.id('outside-ng'));
14+
const inside = element(by.id('inside-ng'));
1515

16-
expect(outside.getText()).toEqual('{{1 + 2}}');
17-
expect(inside.getText()).toEqual('3');
16+
expect(await outside.getText()).toEqual('{{1 + 2}}');
17+
expect(await inside.getText()).toEqual('3');
1818
});
1919
});

spec/altRootConf.js

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ var env = require('./environment.js');
33
// Tests for an Angular app where ng-app is not on the body.
44
exports.config = {
55
seleniumAddress: env.seleniumAddress,
6+
SELENIUM_PROMISE_MANAGER: false,
67

78
framework: 'jasmine',
89

spec/inferRootConf.js

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ var env = require('./environment.js');
33
// Tests for an Angular app where ng-app is not on the body.
44
exports.config = {
55
seleniumAddress: env.seleniumAddress,
6+
SELENIUM_PROMISE_MANAGER: false,
67

78
framework: 'jasmine',
89

0 commit comments

Comments
 (0)