Skip to content

fix(extension): Fix grouping of Angular commands into submenu #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented Jan 14, 2025

This commit moves the Angular commands to a submenu. This was the intent initially but not enough time was spent to figure out how to do it correctly.

fixes #2076
image

@atscott atscott added the target: minor This PR is targeted for the next minor release label Jan 14, 2025
@atscott atscott requested a review from devversion January 14, 2025 19:27
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock file for some reason has a huge diff, but likely some pnpm version differences. LGTM

This commit moves the Angular commands to a submenu. This was the intent
initially but not enough time was spent to figure out how to do it
correctly.

fixes angular#2076
@atscott atscott added the action: merge Ready to merge label Feb 6, 2025
@atscott atscott merged commit 8adc17a into angular:main Feb 6, 2025
4 of 5 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group command
2 participants