Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Commit 40149e6

Browse files
committed
chore(dirtychecking): remove hashCode references
As Victor explained, and as I've verified in the dart tree, hashCodes have a specified default implemenation in Dart which is not exposed in JS. While it is possible to implement similar functionality, it's not clear that there's any real benefit to it, so it is simply removed for the time being. At a later point when it becomes clear that toString needs to uniquely identify objects, then we can look at implementing a suitable algorithm for generating unique identifiers. Closes #41
1 parent 5b5fcd8 commit 40149e6

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/dirty_checking.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -199,9 +199,7 @@ export class ChangeRecord {
199199
}
200200

201201
toString() {
202-
// Where the heck is hashCode from?
203-
var hashCode = 0;
204-
return `${_MODE_NAMES[this._mode]}[${this.field}]{${hashCode}}`;
202+
return `${_MODE_NAMES[this._mode]}[${this.field}]`;
205203
}
206204
}
207205

0 commit comments

Comments
 (0)