Skip to content

Commit 3724df1

Browse files
sanjushahguptasanjushahgupta
authored
ci: Upgrade linter (#808)
1 parent b1e8c21 commit 3724df1

File tree

12 files changed

+29
-29
lines changed

12 files changed

+29
-29
lines changed

‎.golangci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ linters:
1313
- revive
1414
- godot
1515
- gofumpt
16-
- gomnd
16+
- mnd
1717
- gosimple
1818
- govet
1919
- ineffassign
@@ -32,7 +32,7 @@ linters-settings:
3232
rules:
3333
- name: package-comments
3434
disabled: true
35-
gomnd:
35+
mnd:
3636
ignored-numbers: ['0', '1', '2', '3']
3737
issues:
3838
exclude-use-default: false

‎Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ install:
4444
lint:
4545
@if ! command -v golangci-lint > /dev/null 2>&1; then \
4646
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | \
47-
sh -s -- -b "$$(go env GOPATH)/bin" v1.57.2 ; \
47+
sh -s -- -b "$$(go env GOPATH)/bin" v1.62.2 ; \
4848
fi
4949
golangci-lint run ./...
5050

‎internal/cmd/root/help.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ func helpFunc(cmd *cobra.Command, _ []string) {
2020
out := cmd.OutOrStdout()
2121
for _, e := range entries {
2222
if e.Title != "" {
23-
fmt.Fprintf(out, "\033[1m%s\033[0m\n", e.Title)
24-
fmt.Fprintln(out, text.Indent(strings.Trim(e.Body, "\r\n"), " "))
23+
_, _ = fmt.Fprintf(out, "\033[1m%s\033[0m\n", e.Title)
24+
_, _ = fmt.Fprintln(out, text.Indent(strings.Trim(e.Body, "\r\n"), " "))
2525
} else {
26-
fmt.Fprintln(out, e.Body)
26+
_, _ = fmt.Fprintln(out, e.Body)
2727
}
28-
fmt.Fprintln(out)
28+
_, _ = fmt.Fprintln(out)
2929
}
3030
}
3131

‎internal/cmdutil/datetime.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ var (
2626

2727
// DateStringToJiraFormatInLocation parses a standard string to jira compatible RFC3339 datetime format.
2828
//
29-
//nolint:gomnd
29+
//nolint:mnd
3030
func DateStringToJiraFormatInLocation(value string, timezone string) (string, error) {
3131
if value == "" || value == "0" || value == "0000-00-00 00:00:00" || value == "0000-00-00" || value == "00:00:00" {
3232
return "", nil

‎internal/cmdutil/utils.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,17 +71,17 @@ func Info(msg string) *spinner.Spinner {
7171

7272
// Success prints success message in stdout.
7373
func Success(msg string, args ...interface{}) {
74-
fmt.Fprintf(os.Stdout, fmt.Sprintf("\n\u001B[0;32m✓\u001B[0m %s\n", msg), args...)
74+
_, _ = fmt.Fprintf(os.Stdout, fmt.Sprintf("\n\u001B[0;32m✓\u001B[0m %s\n", msg), args...)
7575
}
7676

7777
// Warn prints warning message in stderr.
7878
func Warn(msg string, args ...interface{}) {
79-
fmt.Fprintf(os.Stderr, fmt.Sprintf("\u001B[0;33m%s\u001B[0m\n", msg), args...)
79+
_, _ = fmt.Fprintf(os.Stderr, fmt.Sprintf("\u001B[0;33m%s\u001B[0m\n", msg), args...)
8080
}
8181

8282
// Fail prints failure message in stderr.
8383
func Fail(msg string, args ...interface{}) {
84-
fmt.Fprintf(os.Stderr, fmt.Sprintf("\u001B[0;31m✗\u001B[0m %s\n", msg), args...)
84+
_, _ = fmt.Fprintf(os.Stderr, fmt.Sprintf("\u001B[0;31m✗\u001B[0m %s\n", msg), args...)
8585
}
8686

8787
// Failed prints failure message in stderr and exits.

‎internal/config/generator.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -616,7 +616,7 @@ func (c *JiraCLIConfigGenerator) searchAndAssignBoard(project, keyword string) e
616616
func (c *JiraCLIConfigGenerator) configureMetadata() error {
617617
var err error
618618

619-
//nolint:gomnd
619+
//nolint:mnd
620620
isV9Compatible := c.value.version.major >= 9 || (c.value.version.major == 8 && c.value.version.minor > 4)
621621
if c.value.installation == jira.InstallationTypeLocal && isV9Compatible {
622622
err = c.configureIssueTypesForJiraServerV9()

‎internal/view/board.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ func (b Board) Render() error {
4646
b.printHeader()
4747

4848
for _, d := range b.data {
49-
fmt.Fprintf(b.writer, "%d\t%s\t%s\n", d.ID, prepareTitle(d.Name), d.Type)
49+
_, _ = fmt.Fprintf(b.writer, "%d\t%s\t%s\n", d.ID, prepareTitle(d.Name), d.Type)
5050
}
5151
if _, ok := b.writer.(*tabwriter.Writer); ok {
5252
err := b.writer.(*tabwriter.Writer).Flush()
@@ -69,10 +69,10 @@ func (b Board) header() []string {
6969
func (b Board) printHeader() {
7070
n := len(b.header())
7171
for i, h := range b.header() {
72-
fmt.Fprintf(b.writer, "%s", h)
72+
_, _ = fmt.Fprintf(b.writer, "%s", h)
7373
if i != n-1 {
74-
fmt.Fprintf(b.writer, "\t")
74+
_, _ = fmt.Fprintf(b.writer, "\t")
7575
}
7676
}
77-
fmt.Fprintln(b.writer, "")
77+
_, _ = fmt.Fprintln(b.writer, "")
7878
}

‎internal/view/helper.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,19 +141,19 @@ func jiraURLFromTuiData(server string, r int, d interface{}) string {
141141
}
142142

143143
func navigate(server string) tui.SelectedFunc {
144-
return func(r, c int, d interface{}) {
144+
return func(r, _ int, d interface{}) {
145145
_ = browser.Browse(jiraURLFromTuiData(server, r, d))
146146
}
147147
}
148148

149149
func copyURL(server string) tui.CopyFunc {
150-
return func(r, c int, d interface{}) {
150+
return func(r, _ int, d interface{}) {
151151
_ = clipboard.WriteAll(jiraURLFromTuiData(server, r, d))
152152
}
153153
}
154154

155155
func copyKey() tui.CopyKeyFunc {
156-
return func(r, c int, d interface{}) {
156+
return func(r, _ int, d interface{}) {
157157
_ = clipboard.WriteAll(issueKeyFromTuiData(r, d))
158158
}
159159
}
@@ -162,12 +162,12 @@ func renderPlain(w io.Writer, data tui.TableData) error {
162162
for _, items := range data {
163163
n := len(items)
164164
for j, v := range items {
165-
fmt.Fprintf(w, "%s", v)
165+
_, _ = fmt.Fprintf(w, "%s", v)
166166
if j != n-1 {
167-
fmt.Fprintf(w, "\t")
167+
_, _ = fmt.Fprintf(w, "\t")
168168
}
169169
}
170-
fmt.Fprintln(w)
170+
_, _ = fmt.Fprintln(w)
171171
}
172172

173173
if _, ok := w.(*tabwriter.Writer); ok {

‎internal/view/project.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ func (p Project) Render() error {
4646
p.printHeader()
4747

4848
for _, d := range p.data {
49-
fmt.Fprintf(p.writer, "%s\t%s\t%s\t%s\n", d.Key, prepareTitle(d.Name), d.Type, d.Lead.Name)
49+
_, _ = fmt.Fprintf(p.writer, "%s\t%s\t%s\t%s\n", d.Key, prepareTitle(d.Name), d.Type, d.Lead.Name)
5050
}
5151
if _, ok := p.writer.(*tabwriter.Writer); ok {
5252
err := p.writer.(*tabwriter.Writer).Flush()
@@ -71,10 +71,10 @@ func (p Project) printHeader() {
7171
headers := p.header()
7272
end := len(headers) - 1
7373
for i, h := range headers {
74-
fmt.Fprintf(p.writer, "%s", h)
74+
_, _ = fmt.Fprintf(p.writer, "%s", h)
7575
if i != end {
76-
fmt.Fprintf(p.writer, "\t")
76+
_, _ = fmt.Fprintf(p.writer, "\t")
7777
}
7878
}
79-
fmt.Fprintln(p.writer)
79+
_, _ = fmt.Fprintln(p.writer)
8080
}

‎internal/view/serverinfo.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func WithServerInfoWriter(w io.Writer) ServerInfoOption {
4343

4444
// Render renders the serverinfo view.
4545
func (s ServerInfo) Render() error {
46-
fmt.Fprintf(s.writer, `SERVER INFO
46+
_, _ = fmt.Fprintf(s.writer, `SERVER INFO
4747
-----------
4848
4949
Version: %s

0 commit comments

Comments
 (0)