fix: Update eslint rule severity and modify todo comments

Signed-off-by: prisis <[email protected]>

Author: prisis

Diff for: packages/eslint-config/src/config/plugins/typescript.ts

@@ -257,23 +257,6 @@ const config: Linter.Config = createConfigs([
                             Number: { message: "Use number instead", fixWith: "number" },
                             Object: { message: "Use object instead", fixWith: "object" },
                             Array: { message: "Provide a more specific type" },
-                            // Ban the type-unsafe built-in utility types because they're vulnerable to typos and to failing silently after a rename refactoring.
-                            // See https://www.typescriptlang.org/docs/handbook/utility-types.html
-                            // See https://github.com/pelotom/type-zoo#omitstrictt-k-extends-keyof-t
-                            // See https://github.com/krzkaczor/ts-essentials#Comparison-between-Omit-and-StrictOmit
-                            // TODO make this a real rule instead of using `ban-types`: https://github.com/danielnixon/eslint-plugin-total-functions/issues/88
-                            Omit: {
-                                fixWith: "OmitStrict",
-                                message: "Omit is not type-safe. Prefer a strict version such as OmitStrict from the type-zoo package.",
-                            },
-                            Exclude: {
-                                fixWith: "ExcludeStrict",
-                                message: "Exclude is not type-safe. Prefer a strict version such as ExcludeStrict from the type-zoo package.",
-                            },
-                            Extract: {
-                                fixWith: "ExtractStrict",
-                                message: "Extract is not type-safe. Prefer a strict version such as ExtractStrict from the type-zoo package.",
-                            },
                         },
                     },
                 ],

Diff for: packages/eslint-config/src/config/plugins/unicorn.ts

@@ -50,13 +50,13 @@ const config: Linter.Config = {
             "error",
             {
                 case: "kebabCase",
-                ignore: [/(FUNDING\.yml|README\.md|CHANGELOG\.md|CONTRIBUTING\.md|CODE_OF_CONDUCT\.md|SECURITY\.md|LICENSE)/],
+                ignore: [/(FUNDING\.yml|README\.md|CHANGELOG\.md|CONTRIBUTING\.md|CODE_OF_CONDUCT\.md|SECURITY\.md|LICENSE)/u],
             },
         ],
 
         "unicorn/no-array-for-each": "off",
 
-        // TODO: Disabled for now as I don't have time to deal with the backslash that might come from this. Try to enable this rule in 2021.
+        // TODO: Disabled for now as I don't have time to deal with the backslash that might come from this. Try to enable this rule in 2024.
         "unicorn/no-null": "off",
 
         // TODO: Temporarily disabled until it becomes more mature.

Diff for: packages/eslint-config/src/typescript-type-checking.ts

@@ -113,7 +113,7 @@ const config = createConfig("typescript", {
 
         // Warns if a type assertion does not change the type of an expression
         // See https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/non-nullable-type-assertion-style.md
-        "@typescript-eslint/non-nullable-type-assertion-style": "error",
+        "@typescript-eslint/non-nullable-type-assertion-style": "off",
 
         // See https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/method-signature-style.md
         "@typescript-eslint/method-signature-style": "error",
@@ -175,15 +175,17 @@ const config = createConfig("typescript", {
         // Enforces unbound methods are called with their expected scope
         "@typescript-eslint/unbound-method": ["error", { ignoreStatic: false }],
 
+        // TODO: enable this rule when decision is made on
         "@typescript-eslint/consistent-type-assertions": [
-            "error",
+            "off",
             {
                 assertionStyle: "never",
             },
         ],
 
+        // TODO: enable this rule when decision is made on
         "@typescript-eslint/strict-boolean-expressions": [
-            "error",
+            "off",
             {
                 allowString: false,
                 allowNumber: false,
@@ -192,7 +194,7 @@ const config = createConfig("typescript", {
         ],
 
         // Interfaces encourage OO, types encourage FP.
-        "@typescript-eslint/consistent-type-definitions": ["error", "type"],
+        "@typescript-eslint/consistent-type-definitions": "off",
     },
 });