fix: Remove splitting option and improve react version retrieval

In 'react.ts', refactored the react version retrieval to parse the version and store in a global variable. This guarantees more accuracy and easier debugging. A global variable 'anolilabEslintConfigReactVersion' was added in 'global.d.ts' to hold the parsed react version. These changes enhance code efficiency.

Signed-off-by: prisis <[email protected]>

Author: prisis

.eslintignore

@@ -7,5 +7,6 @@ packages/babel-preset/fixture/test.js
 packages/babel-preset/fixture/test.ts
 packages/stylelint-config/.stylelintrc.js
 packages/lint-staged-config/.lintstagedrc.js
+packages/eslint-config/src/global.d.ts
 
 tsup.config.ts

package.json

@@ -109,6 +109,8 @@
         "cz-conventional-changelog": "^3.3.0",
         "eslint": "^8.43.0",
         "eslint-plugin-vitest": "^0.2.6",
+        "eslint-plugin-etc": "^2.0.3",
+        "eslint-plugin-typescript-sort-keys": "^2.3.0",
         "husky": "^8.0.3",
         "is-ci": "^3.0.1",
         "lint-staged": "^13.2.3",
@@ -136,6 +138,9 @@
                 "eslint": {
                     "config": "./.eslintrc.js"
                 }
+            },
+            "plugin": {
+                "eslint-plugin-tsdoc": false
             }
         }
     },

packages/eslint-config/src/config/plugins/react.ts

@@ -3,6 +3,7 @@ import { getPackageSubProperty, hasDependency, hasDevDependency } from "@anolila
 import type { Linter } from "eslint";
 import findUp from "find-up";
 import { env } from "node:process";
+import { parse } from "semver";
 
 import anolilabEslintConfig from "../../utils/eslint-config";
 import { consoleLog } from "../../utils/loggers";
@@ -54,15 +55,25 @@ const hasJsxRuntime = (() => {
     return global.hasAnolilabEsLintConfigReactRuntimePath;
 })();
 
-let reactVersion: string | undefined = getPackageSubProperty<string>("dependencies")("react");
+if (!global.anolilabEslintConfigReactVersion) {
+    let reactVersion = getPackageSubProperty<string | undefined>("dependencies")("react");
 
-if (reactVersion === undefined) {
-    reactVersion = getPackageSubProperty<string | undefined>("devDependencies")("react");
+    if (reactVersion === undefined) {
+        reactVersion = getPackageSubProperty<string | undefined>("devDependencies")("react");
+    }
+
+    if (reactVersion !== undefined) {
+        const parsedVersion = parse(reactVersion);
+
+        if (parsedVersion !== null) {
+            global.anolilabEslintConfigReactVersion = `${parsedVersion.major}.${parsedVersion.minor}`;
+        }
+    }
 }
 
-if (reactVersion !== undefined && anolilabEslintConfig?.["info_on_found_react_version"] !== false) {
+if (global.anolilabEslintConfigReactVersion !== undefined && anolilabEslintConfig?.["info_on_found_react_version"] !== false) {
     consoleLog(
-        `\n@anolilab/eslint-config found the version ${reactVersion} of react in your dependencies, this version ${reactVersion} will be used to setup the "eslint-plugin-react"\n`,
+        `\n@anolilab/eslint-config found the version ${global.anolilabEslintConfigReactVersion} of react in your dependencies, this version ${global.anolilabEslintConfigReactVersion} will be used to setup the "eslint-plugin-react"\n`,
     );
 }
 
@@ -93,7 +104,7 @@ const config: Linter.Config = {
                     // The default value is "detect". Automatic detection works by loading the entire React library
                     // into the linter's process, which is inefficient. It is recommended to specify the version
                     // explicity.
-                    version: reactVersion ?? "detect",
+                    version: global.anolilabEslintConfigReactVersion ?? "detect",
                 },
                 propWrapperFunctions: [
                     "forbidExtraProps", // https://www.npmjs.com/package/airbnb-prop-types

packages/eslint-config/src/config/plugins/typescript.ts

@@ -60,7 +60,13 @@ const config: Linter.Config = {
     overrides: [
         {
             files: ["*.ts", "*.mts", "*.cts", "*.tsx"],
-            extends: ["plugin:import/typescript"],
+            extends: [
+                "plugin:import/typescript",
+                // TODO: enable the rule when typescript-eslint 6.0.0 is released
+                // "plugin:@typescript-eslint/recommended",
+                // "plugin:@typescript-eslint/stylistic",
+                // "plugin:@typescript-eslint/strict",
+            ],
             plugins: ["@typescript-eslint"],
             parser: "@typescript-eslint/parser",
             parserOptions: {

packages/eslint-config/src/global.d.ts

@@ -29,6 +29,8 @@ declare global {
 
     var anolilabEslintConfigReactPrettierRules: undefined | Linter.RulesRecord;
 
+    var anolilabEslintConfigReactVersion: undefined | string;
+
     var anolilabEslintConfigTestingLibraryRuleSet: undefined | string;
 
     var anolilabEslintConfigUnicornPrettierRules: undefined | Linter.RulesRecord;

packages/eslint-config/src/typescript-type-checking.ts

@@ -6,6 +6,12 @@ import { createConfig } from "./utils/create-config";
 const bestPracticesRules = bestPracticesConfig.rules as Linter.RulesRecord;
 
 const config = createConfig("typescript", {
+    // TODO: enable the rule when typescript-eslint 6.0.0 is released
+    // extends: [
+    // "plugin:@typescript-eslint/recommended-type-checked",
+    // "plugin:@typescript-eslint/strict-type-checked",
+    // "plugin:@typescript-eslint/stylistic-type-checked"
+    // ],
     rules: {
         // Disallows awaiting a value that is not a Thenable
         "@typescript-eslint/await-thenable": "error",

packages/eslint-config/tsup.config.ts

@@ -2,7 +2,6 @@ import { createConfig } from "../../tsup.config";
 
 const config = createConfig({
     format: "cjs",
-    splitting: false,
 });
 
 export default config;