Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set of public keys in SigningTxData #4238

Open
grarco opened this issue Jan 14, 2025 · 0 comments
Open

Set of public keys in SigningTxData #4238

grarco opened this issue Jan 14, 2025 · 0 comments

Comments

@grarco
Copy link
Collaborator

grarco commented Jan 14, 2025

pub struct SigningTxData {
/// The address owning the transaction
pub owner: Option<Address>,
/// The public keys associated to an account
pub public_keys: Vec<common::PublicKey>,

We could change the collection of public keys used for multisig public keys to a HashSet to avoid useless duplicates and/or the need to filter them out.

A similar approach should be taken for the generate_tx_signatures function used to produce offline signatures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant