Skip to content

Commit a847e0f

Browse files
authored
Also consider BaseException. (#389)
1 parent ae2f93e commit a847e0f

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
bugfixes:
2+
- "Make sure that all errors are caught during documentation normalization.
3+
Until now exceptions derived from ``BaseException`` that are not derived from ``Exception`` are not handled correctly
4+
(https://github.com/ansible-community/antsibull-docs/pull/389)."

src/antsibull_docs/process_docs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ async def normalize_all_plugin_info(
234234
for (plugin_type, plugin_name), plugin_record in zip(normalizers, results):
235235
# Errors which broke doc parsing (and therefore we won't have enough info to
236236
# build a docs page)
237-
if isinstance(plugin_record, Exception):
237+
if isinstance(plugin_record, BaseException):
238238
# An exception means there is no usable documentation for this plugin
239239
# Record a nonfatal error and then move on
240240
nonfatal_errors[plugin_type][plugin_name].append(str(plugin_record))

0 commit comments

Comments
 (0)