From 0b958c47a6214e887cdd6c041d380f6744553491 Mon Sep 17 00:00:00 2001 From: Samuel Lopez <85613111+Samuelopez-ansys@users.noreply.github.com> Date: Mon, 29 Apr 2024 08:57:17 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com> --- pyaedt/misc/Run_Toolkit_Manager.py_build | 2 +- pyaedt/misc/aedtlib_personalib_install.py | 2 +- pyaedt/misc/toolkit_manager.py | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pyaedt/misc/Run_Toolkit_Manager.py_build b/pyaedt/misc/Run_Toolkit_Manager.py_build index f32a698966a..577a13f6307 100644 --- a/pyaedt/misc/Run_Toolkit_Manager.py_build +++ b/pyaedt/misc/Run_Toolkit_Manager.py_build @@ -73,7 +73,7 @@ def main(): def check_file(file_path): if not os.path.isfile(file_path): - show_error('"{}" does not exist. Please click on the "Install PyAEDT" button in the Automation ribbon.'.format( + show_error('"{}" does not exist. Click the "Install PyAEDT" button in the Automation ribbon.'.format( file_path)) diff --git a/pyaedt/misc/aedtlib_personalib_install.py b/pyaedt/misc/aedtlib_personalib_install.py index c9b54a03e20..bc4dfca095b 100644 --- a/pyaedt/misc/aedtlib_personalib_install.py +++ b/pyaedt/misc/aedtlib_personalib_install.py @@ -149,7 +149,7 @@ def install_toolkit(toolkit_dir, product, aedt_version, is_student_version=False os.makedirs(lib_dir, exist_ok=True) os.makedirs(tool_dir, exist_ok=True) files_to_copy = ["Console", "Run_PyAEDT_Script", "Jupyter", "Run_Toolkit_Manager"] - # Remove hard-coded version number from Python virtual environment path, and replace it with the corresponding AEDT + # Remove hard-coded version number from Python virtual environment path and replace it with the corresponding AEDT # version's Python virtual environment. version_agnostic = False if aedt_version[2:6].replace(".", "") in sys.executable: diff --git a/pyaedt/misc/toolkit_manager.py b/pyaedt/misc/toolkit_manager.py index 1e4c26b7d83..27c2ccfb2b7 100644 --- a/pyaedt/misc/toolkit_manager.py +++ b/pyaedt/misc/toolkit_manager.py @@ -114,7 +114,7 @@ def is_toolkit_installed(toolkit_name): def open_window(window, window_name, open_source_toolkits): - """Open window action""" + """Open a window.""" if not hasattr(window, "opened"): window.opened = True window.title(window_name) @@ -217,9 +217,9 @@ def button_is_clicked( executable_interpreter=executable_interpreter, ) else: - desktop.logger.info("PyAEDT environment is not installed") + desktop.logger.info("PyAEDT environment is not installed.") else: - desktop.logger.info("Uninstall {}".format(name)) + desktop.logger.info("Uninstall {}.".format(name)) desktop.remove_script_from_menu(name, product=toolkit_level) desktop.odesktop.CloseAllWindows()