From 571674ddb13a69f66140305dc51baa91b928ae76 Mon Sep 17 00:00:00 2001 From: Massimo Capodiferro <77293250+maxcapodi78@users.noreply.github.com> Date: Tue, 9 Apr 2024 12:50:53 +0200 Subject: [PATCH 1/2] fixed bug in VirtualCompliance class (#4472) Co-authored-by: maxcapodi78 Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com> --- pyaedt/generic/compliance.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/pyaedt/generic/compliance.py b/pyaedt/generic/compliance.py index 90ee2e5238b..c87de470e08 100644 --- a/pyaedt/generic/compliance.py +++ b/pyaedt/generic/compliance.py @@ -691,6 +691,7 @@ def _add_statistical_violations(self, report, pdf_report, image_name, local_conf self._desktop_class.logger.error(msg) return mag_data = {i: k for i, k in sols.full_matrix_real_imag[0][sols.expressions[0]].items() if k > 0} + # mag_data is a dictionary. The key isa tuple (__AMPLITUDE, __UI), and the value is the eye value. mystr = "Eye Mask Violation:" result_value = "PASS" points_to_check = [i[::-1] for i in local_config["eye_mask"]["points"]] @@ -711,13 +712,14 @@ def _add_statistical_violations(self, report, pdf_report, image_name, local_conf if result_value == "FAIL": result_value = f"FAIL on {num_failed} points." pass_fail_table.append([mystr, result_value]) - + result_value = "PASS" if local_config["eye_mask"]["enable_limits"]: mystr = "Upper/Lower Mask Violation:" for point in mag_data: + # checking if amplitude is overcoming limits. if ( - point[1] > local_config["eye_mask"]["upper_limit"] - or point[1] < local_config["eye_mask"]["lower_limit"] + point[0] > local_config["eye_mask"]["upper_limit"] + or point[0] < local_config["eye_mask"]["lower_limit"] ): result_value = "FAIL" break From a402ebafd6c6346e2ed8a980df44b7438b1f48ab Mon Sep 17 00:00:00 2001 From: gkorompi Date: Tue, 9 Apr 2024 14:17:06 +0300 Subject: [PATCH 2/2] 2399 --- _unittest/test_20_HFSS.py | 1 + pyaedt/hfss.py | 1 + 2 files changed, 2 insertions(+) diff --git a/_unittest/test_20_HFSS.py b/_unittest/test_20_HFSS.py index 3856d3d1b7b..5189b0829b8 100644 --- a/_unittest/test_20_HFSS.py +++ b/_unittest/test_20_HFSS.py @@ -830,6 +830,7 @@ def test_20_create_voltage_on_sheet(self): def test_21_create_open_region(self): assert self.aedtapp.create_open_region("1GHz") + assert len(self.aedtapp.field_setups) == 3 assert self.aedtapp.create_open_region("1GHz", "FEBI") assert self.aedtapp.create_open_region("1GHz", "PML", True, "-z") diff --git a/pyaedt/hfss.py b/pyaedt/hfss.py index 86c8b6f6c25..8846a328fb3 100644 --- a/pyaedt/hfss.py +++ b/pyaedt/hfss.py @@ -2846,6 +2846,7 @@ def create_open_region(self, Frequency="1GHz", Boundary="Radiation", ApplyInfini self.omodelsetup.CreateOpenRegion(vars) self.logger.info("Open Region correctly created.") + self.save_project() return True @pyaedt_function_handler()