Merge branch 'main' into improve_remote_file_access

Author: maxcapodi78

.pre-commit-config.yaml

@@ -48,7 +48,7 @@ repos:
 
 # validate GitHub workflow files
 - repo: https://github.com/python-jsonschema/check-jsonschema
-  rev: 0.28.0
+  rev: 0.28.1
   hooks:
     - id: check-github-workflows
 

_unittest/test_02_3D_modeler.py

@@ -326,7 +326,6 @@ def test_30_create_waveguide(self):
             position, self.aedtapp.AXIS.Z, wgmodel="MYMODEL", wg_length=2000, parametrize_h=True
         )
         assert not wgfail
-        pass
 
     def test_31_set_objects_unmodel(self):
         assert self.aedtapp.modeler.set_object_model_state("Second_airbox", False)
@@ -663,7 +662,6 @@ def test_45_sweep_along_path(self):
     def test_46_section_object(self):
         box1 = self.aedtapp.modeler.create_box([-10, -10, -10], [20, 20, 20], "box_to_split")
         assert self.aedtapp.modeler.section(box1, 0, create_new=True, section_cross_object=False)
-        pass
 
     def test_47_sweep_along_vector(self):
         sweep_vector = [5, 0, 0]

_unittest/test_04_SBR.py

@@ -58,6 +58,10 @@ def init(self, aedtapp, local_scratch):
     def test_01_open_source(self, source):
         assert self.aedtapp.create_sbr_linked_antenna(source, target_cs="feederPosition", fieldtype="farfield")
         assert len(self.aedtapp.native_components) == 1
+        assert self.aedtapp.create_sbr_linked_antenna(
+            source, target_cs="feederPosition", fieldtype="farfield", source_name="LinkedAntenna"
+        )
+        assert len(self.aedtapp.native_components) == 2
 
     def test_02_add_antennas(self):
         self.aedtapp.insert_design("add_antennas")

_unittest/test_07_Object3D.py

@@ -226,6 +226,8 @@ def test_07_object_clone_and_get_properties(self):
         assert len(new_object.faces) == 6
         assert len(new_object.edges) == 12
         assert new_object.display_wireframe == initial_object.display_wireframe
+        new_object.name = "Properties_Box"
+        assert not new_object.name == "Properties_Box"
 
     def test_08_set_model(self):
         o = self.create_copper_box()

_unittest/test_08_Primitives3D.py

@@ -98,8 +98,6 @@ def create_copper_box(self, name=None):
             name = "MyBox"
         if self.aedtapp.modeler[name]:
             self.aedtapp.modeler.delete(name)
-        else:
-            pass
         new_object = self.aedtapp.modeler.create_box([0, 0, 0], [10, 10, 5], name, "Copper")
         return new_object
 
@@ -241,8 +239,6 @@ def test_03_create_polyhedron(self):
             matname="Aluminum",
         )
 
-        pass
-
     def test_05_center_and_centroid(self):
         o = self.create_copper_box()
         tol = 1e-9
@@ -334,7 +330,6 @@ def test_15_create_cylinder(self):
         assert o.is3d is True
         assert not self.aedtapp.modeler.create_cylinder(axis, [2, 2], radius, height, 8, "MyCyl", "Copper")
         assert not self.aedtapp.modeler.create_cylinder(axis, udp, -0.1, height, 8, "MyCyl", "Copper")
-        pass
 
     def test_16_create_ellipse(self):
         udp = self.aedtapp.modeler.Position(5, 3, 8)
@@ -378,7 +373,6 @@ def test_17_create_object_from_edge(self):
         of = self.aedtapp.modeler.create_object_from_edge([o4.edges[0], o3.edges[1], o4.edges[1]])
         assert of
         assert len(of) == 3
-        pass
 
     def test_18_create_object_from_face(self):
         o = self.create_copper_cylinder()
@@ -400,7 +394,6 @@ def test_18_create_object_from_face(self):
         of = self.aedtapp.modeler.create_object_from_face([o3.faces[0], o4.faces[1], o4.faces[1], o3.faces[2]])
         assert of
         assert len(of) == 4
-        pass
 
     def test_19_create_polyline(self):
         udp1 = [0, 0, 0]
@@ -868,8 +861,6 @@ def test_48_insert_polylines_segments_test2(self):
 
         P.insert_segment(position_list=[start_point, insert_point1, insert_point2], segment="Arc")
 
-        pass
-
     def test_49_modify_crossection(self):
         P = self.aedtapp.modeler.create_polyline(
             position_list=[[34.1004, 14.1248, 0], [27.646, 16.7984, 0], [24.9725, 10.3439, 0]],
@@ -1157,7 +1148,6 @@ def test_60_get_edges_on_bounding_box(self):
     def test_61_get_closest_edge_to_position(self):
         my_box = self.create_copper_box("test_closest_edge")
         assert isinstance(self.aedtapp.modeler.get_closest_edgeid_to_position([0.2, 0, 0]), int)
-        pass
 
     @pytest.mark.skipif(config["NonGraphical"], reason="Not running in non-graphical mode")
     def test_62_import_space_claim(self):

_unittest/test_09_VariableManager.py

@@ -119,7 +119,6 @@ def test_02_test_formula(self):
         v = self.aedtapp.variable_manager
         for var_name in v.variable_names:
             print("{} = {}".format(var_name, self.aedtapp[var_name]))
-        pass
         tol = 1e-9
         c2pi = math.pi * 2.0
         assert abs(v["$PrjVar1"].numeric_value - c2pi) < tol

_unittest/test_12_1_PostProcessing.py

@@ -459,7 +459,6 @@ def test_09n_add_line_from_point(self):  # pragma: no cover
         assert new_report.limit_lines[0].set_line_properties(
             style=style.Dot, width=4, hatch_above=False, violation_emphasis=True, hatch_pixels=1, color=(255, 255, 0)
         )
-        pass
 
     @pytest.mark.skipif(
         config["desktopVersion"] < "2022.2", reason="Not working in non-graphical mode in version earlier than 2022.2."
@@ -479,7 +478,6 @@ def test_09o_add_note(self):  # pragma: no cover
             font_size=10,
             color=(255, 0, 0),
         )
-        pass
 
     def test_10_delete_report(self):
         plots_number = len(self.aedtapp.post.plots)

_unittest/test_20_HFSS.py

@@ -667,7 +667,9 @@ def test_12_create_perfects_on_objects(self):
     def test_13_create_impedance_on_objects(self):
         box1 = self.aedtapp.modeler.create_box([0, 0, 0], [10, 10, 5], "imp1", "Copper")
         box2 = self.aedtapp.modeler.create_box([0, 0, 10], [10, 10, 5], "imp2", "copper")
-        imp = self.aedtapp.create_impedance_between_objects("imp1", "imp2", self.aedtapp.AxisDir.XPos, "TL2", 50, 25)
+        imp = self.aedtapp.create_impedance_between_objects(
+            box1.name, box2.name, self.aedtapp.AxisDir.XPos, "TL1", 50, 25
+        )
         assert imp.name in self.aedtapp.modeler.get_boundaries_name()
         assert imp.update()
 
@@ -677,14 +679,14 @@ def test_14_create_lumpedrlc_on_objects(self):
         box1 = self.aedtapp.modeler.create_box([0, 0, 0], [10, 10, 5], "rlc1", "Copper")
         box2 = self.aedtapp.modeler.create_box([0, 0, 10], [10, 10, 5], "rlc2", "copper")
         imp = self.aedtapp.create_lumped_rlc_between_objects(
-            "rlc1", "rlc2", self.aedtapp.AxisDir.XPos, Rvalue=50, Lvalue=1e-9
+            box1.name, box2.name, self.aedtapp.AxisDir.XPos, Rvalue=50, Lvalue=1e-9
         )
         assert imp.name in self.aedtapp.modeler.get_boundaries_name()
         assert imp.update()
 
         box3 = self.aedtapp.modeler.create_box([0, 0, 20], [10, 10, 5], "rlc3", "copper")
         lumped_rlc2 = self.aedtapp.create_lumped_rlc_between_objects(
-            "rlc2", "rlc3", self.aedtapp.AxisDir.XPos, Rvalue=50, Lvalue=1e-9, Cvalue=1e-9
+            box2.name, box3.name, self.aedtapp.AxisDir.XPos, Rvalue=50, Lvalue=1e-9, Cvalue=1e-9
         )
         assert lumped_rlc2.name in self.aedtapp.modeler.get_boundaries_name()
         assert lumped_rlc2.update()
@@ -710,9 +712,24 @@ def test_16_create_impedance_on_sheets(self):
         rect = self.aedtapp.modeler.create_rectangle(
             self.aedtapp.PLANE.XY, [0, 0, 0], [10, 2], name="ImpBound", matname="Copper"
         )
-        imp = self.aedtapp.assign_impedance_to_sheet("imp1", "TL2", 50, 25)
-        assert imp.name in self.aedtapp.modeler.get_boundaries_name()
-        assert imp.update()
+        imp1 = self.aedtapp.assign_impedance_to_sheet(rect.name, "TL2", 50, 25)
+        assert imp1.name in self.aedtapp.modeler.get_boundaries_name()
+        assert imp1.update()
+
+        impedance_box = self.aedtapp.modeler.create_box([0, -100, 0], [200, 200, 200], "ImpedanceBox")
+        ids = self.aedtapp.modeler.get_object_faces(impedance_box.name)[:3]
+
+        imp2 = self.aedtapp.assign_impedance_to_sheet(ids, sourcename="ImpedanceToFaces", resistance=60, reactance=-20)
+        assert imp2.name in self.aedtapp.modeler.get_boundaries_name()
+
+        rect2 = self.aedtapp.modeler.create_rectangle(
+            self.aedtapp.PLANE.XY, [0, 0, 0], [10, 2], name="AniImpBound", matname="Copper"
+        )
+        assert not self.aedtapp.assign_impedance_to_sheet(rect2.name, "TL3", [50, 20, 0, 0], [25, 0, 5])
+        imp2 = self.aedtapp.assign_impedance_to_sheet(rect2.name, "TL3", [50, 20, 0, 0], [25, 0, 5, 0])
+        assert imp2.name in self.aedtapp.modeler.get_boundaries_name()
+        imp3 = self.aedtapp.assign_impedance_to_sheet(impedance_box.top_face_z.id, "TL4", [50, 20, 0, 0], [25, 0, 5, 0])
+        assert imp3.name in self.aedtapp.modeler.get_boundaries_name()
 
     def test_17_create_lumpedrlc_on_sheets(self):
         rect = self.aedtapp.modeler.create_rectangle(
@@ -844,7 +861,6 @@ def test_24_create_curvilinear(self):
         ).GetPropValue("Apply Curvilinear Elements")
         mesh.delete()
         assert len(self.aedtapp.mesh.meshoperations) == 2
-        pass
 
     def test_30_assign_initial_mesh(self):
         assert self.aedtapp.mesh.assign_initial_mesh_from_slider(6)

_unittest/test_21_Circuit.py

@@ -118,7 +118,6 @@ def test_06a_create_setup(self):
     def test_08_import_mentor_netlist(self):
         self.aedtapp.insert_design("MentorSchematicImport")
         assert self.aedtapp.create_schematic_from_mentor_netlist(self.netlist_file2)
-        pass
 
     def test_09_import_netlist(self):
         self.aedtapp.insert_design("SchematicImport")

_unittest/test_28_Maxwell3D.py

@@ -469,6 +469,7 @@ def test_32_matrix(self, add_app):
         rectangle4 = m3d.modeler.create_rectangle(0, [32.5, 1.5, 0], [2.5, 5], name="Sheet4")
 
         m3d.assign_voltage(rectangle1.faces[0], amplitude=1, name="Voltage1")
+        m3d.assign_voltage("Sheet1", amplitude=1, name="Voltage5")
         m3d.assign_voltage(rectangle2.faces[0], amplitude=1, name="Voltage2")
         m3d.assign_voltage(rectangle3.faces[0], amplitude=1, name="Voltage3")
         m3d.assign_voltage(rectangle4.faces[0], amplitude=1, name="Voltage4")

_unittest/test_41_3dlayout_modeler.py

@@ -580,7 +580,6 @@ def test_33_set_temperature_dependence(self):
             ambient_temp=27,
             create_project_var=True,
         )
-        pass
 
     def test_34_create_additional_setup(self):
         setup_name = "SiwaveDC"
@@ -651,7 +650,6 @@ def test_39_import_ipc(self):
     def test_40_test_flex(self, add_app):
         flex = add_app(project_name=test_rigid_flex, application=Hfss3dLayout, subfolder=test_subfolder)
         assert flex.enable_rigid_flex()
-        pass
 
     def test_41_test_create_polygon(self):
         points = [[100, 100], [100, 200], [200, 200]]

_unittest/test_98_Icepak.py

@@ -131,7 +131,11 @@ def test_03_AssignPCBRegion(self):
             pcb_mesh_region.assignment.padding_types = "Absolute Offset"
             assert pcb_mesh_region.assignment.padding_values == ["2mm"] * 6
             assert pcb_mesh_region.assignment.padding_types == ["Absolute Offset"] * 6
-            subregion = self.aedtapp.modeler.create_subregion([50, 50, 50, 50, 100, 100], "Percentage Offset", "PCB")
+            assert self.aedtapp.modeler.create_subregion([50, 50, 50, 50, 100, 100], "Percentage Offset", "PCB")
+            box = self.aedtapp.modeler.create_box([0, 0, 0], [1, 2, 3])
+            assert self.aedtapp.modeler.create_subregion(
+                [50, 50, 50, 50, 100, 100], "Percentage Offset", ["PCB", box.name]
+            )
         else:
             box = self.aedtapp.modeler.create_box([0, 0, 0], [1, 2, 3])
             pcb_mesh_region.Objects = box.name
@@ -226,7 +230,6 @@ def test_10_DesignSettings(self):
 
     def test_11_mesh_level(self):
         assert self.aedtapp.mesh.assign_mesh_level({"USB_Shiels": 2})
-        pass
 
     def test_12a_AssignMeshOperation(self):
         self.aedtapp.oproject = test_project_name

_unittest_solvers/test_31_Q3D.py

@@ -191,7 +191,6 @@ def test_08_create_faceted_bondwire(self):
             "bondwire_example", self.aedtapp.AXIS.Z, min_size=0.2, numberofsegments=8
         )
         assert test
-        pass
 
     def test_11_assign_net(self):
         box = self.aedtapp.modeler.create_box([30, 30, 30], [10, 10, 10], name="mybox")

examples/02-HFSS/Probe_Fed_Patch.py

@@ -34,7 +34,7 @@
 # You can set ``non_graphical``  to ``True`` to view
 # HFSS while the notebook cells are executed.
 
-non_graphical = True
+non_graphical = False
 length_units = "mm"
 freq_units = "GHz"
 
@@ -84,7 +84,7 @@
 stackup.resize_around_element(patch)
 pad_length = [3, 3, 3, 3, 3, 3]  # Air bounding box buffer in mm.
 region = hfss.modeler.create_region(pad_length, is_percentage=False)
-hfss.assign_radiation_boundary_to_objects(region)
+hfss.assign_radiation_boundary_to_objects(region.name)
 
 patch.create_probe_port(ground, rel_x_offset=0.485)
 setup = hfss.create_setup(setupname="Setup1",
@@ -115,4 +115,4 @@
 # Release AEDT and clean up temporary folders and files.
 
 hfss.release_desktop()
-tmpdir.cleanup()
+tmpdir.cleanup()

examples/03-Maxwell/Maxwell2D_Transient.py

@@ -71,7 +71,7 @@
 # ~~~~~~~~~~~~~~~~~
 # Create an air region.
 
-region = maxwell_2d.modeler.create_region([100, 100, 100, 100, 100, 100])
+region = maxwell_2d.modeler.create_region([100, 100, 100, 100])
 
 ###############################################################################
 # Assign windings and balloon

examples/03-Maxwell/Maxwell_Control_Program.py

@@ -83,7 +83,7 @@
 # ~~~~~~~~~~~~
 # Plot Solved Results.
 
-sols = m2d.post.get_solution_data("FluxLinkage(Winding1)",variations={"Time":["All"]},  primary_sweep_variable="Time")
+sols = m2d.post.get_solution_data("FluxLinkage(Winding1)", variations={"Time":["All"]}, primary_sweep_variable="Time")
 sols.plot()
 
 ###################################################################################

examples/05-Q3D/Q2D_Armoured_Cable.py

@@ -199,7 +199,7 @@
 # Create region
 # ~~~~~~~~~~~~~
 
-region = q2d.modeler.create_region([500, 500, 500, 500, 0, 0])
+region = q2d.modeler.create_region([500, 500, 500, 500])
 region.material_name = "vacuum"
 
 ##########################################################
@@ -228,12 +228,6 @@
 
 q2d_setup = q2d.create_setup(setupname=setup_name)
 q2d_sweep = q2d_setup.add_sweep(sweepname=sweep_name)
-q2d_sweep.props["RangeType"] = "LogScale"
-q2d_sweep.props["RangeStart"] = "0Hz"
-q2d_sweep.props["RangeEnd"] = "3MHz"
-q2d_sweep.props["RangeCount"] = 10
-q2d_sweep.props["RangeSamples"] = 1
-q2d_sweep.update()
 
 ##########################################################
 # Analyze setup

examples/07-Circuit/Circuit_Transient.py

@@ -172,7 +172,7 @@
     bn = np.array(b)
     cellst = np.append(cellst, an)
     cellsv = np.append(cellsv, bn)
-plt.plot(cellst.T,  cellsv.T, zorder=0)
+plt.plot(cellst.T, cellsv.T, zorder=0)
 plt.show()
 
 ###############################################################################

examples/07-EMIT/interference_gui.py

@@ -612,7 +612,7 @@ def closeEvent(self, event):
 # Launch the GUI. If you want to run the GUI, uncomment the ``window.show()`` and
 # ``app.exec_()`` method calls. 
 
-if __name__ == '__main__' and  os.getenv("PYAEDT_DOC_GENERATION", "False") != "1":
+if __name__ == '__main__' and os.getenv("PYAEDT_DOC_GENERATION", "False") != "1":
     app = QtWidgets.QApplication([])
     window = MainWindow()
     window.show()

pyaedt/application/Analysis3DLayout.py

@@ -329,15 +329,15 @@ def get_next_xtalk_list(self, trlist=[], tx_prefix=""):
 
         >>> oModule.GetAllPorts
         """
-        next = []
+        next_xtalks = []
         if not trlist:
             trlist = [i for i in self.excitations if tx_prefix in i]
         for i in trlist:
             k = trlist.index(i) + 1
             while k < len(trlist):
-                next.append("S({},{})".format(i, trlist[k]))
+                next_xtalks.append("S({},{})".format(i, trlist[k]))
                 k += 1
-        return next
+        return next_xtalks
 
     @pyaedt_function_handler()
     def get_fext_xtalk_list(self, trlist=None, reclist=None, tx_prefix="", rx_prefix="", skip_same_index_couples=True):

pyaedt/application/AnalysisNexxim.py

@@ -483,15 +483,15 @@ def get_next_xtalk_list(self, trlist=[], tx_prefix=""):
 
         >>> oEditor.GetAllPorts
         """
-        next = []
+        next_xtalks = []
         if not trlist:
             trlist = [i for i in list(self.excitations.keys()) if tx_prefix in i]
         for i in trlist:
             k = trlist.index(i) + 1
             while k < len(trlist):
-                next.append("S({},{})".format(i, trlist[k]))
+                next_xtalks.append("S({},{})".format(i, trlist[k]))
                 k += 1
-        return next
+        return next_xtalks
 
     @pyaedt_function_handler()
     def get_fext_xtalk_list(self, trlist=None, reclist=None, tx_prefix="", rx_prefix="", skip_same_index_couples=True):