Skip to content

FEAT: Add AEDT File Management tests #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 11, 2025
Merged

FEAT: Add AEDT File Management tests #5879

merged 16 commits into from
Mar 11, 2025

Conversation

Samuelopez-ansys
Copy link
Member

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Close #5756

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

marwane rachad and others added 2 commits March 7, 2025 08:10
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Mar 7, 2025
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) March 7, 2025 07:26
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.03%. Comparing base (4d786bf) to head (506bb0e).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5879      +/-   ##
==========================================
+ Coverage   84.92%   85.03%   +0.10%     
==========================================
  Files         161      161              
  Lines       62156    62212      +56     
==========================================
+ Hits        52785    52900     +115     
+ Misses       9371     9312      -59     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys disabled auto-merge March 7, 2025 08:28
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM but I left a few minor comments. Thanks for making the migration @Samuelopez-ansys and thanks for the propositio @Marwane-20

Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, otherwise LGTM

Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys dismissed SMoraisAnsys’s stale review March 11, 2025 14:40

Changes requested implemented

@Samuelopez-ansys Samuelopez-ansys merged commit 308825d into main Mar 11, 2025
47 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/issue_5756 branch March 11, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve coverage aedt_file_management file
4 participants