-
Notifications
You must be signed in to change notification settings - Fork 163
FEAT: Add AEDT File Management tests #5879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5879 +/- ##
==========================================
+ Coverage 84.92% 85.03% +0.10%
==========================================
Files 161 161
Lines 62156 62212 +56
==========================================
+ Hits 52785 52900 +115
+ Misses 9371 9312 -59 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM but I left a few minor comments. Thanks for making the migration @Samuelopez-ansys and thanks for the propositio @Marwane-20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, otherwise LGTM
Co-authored-by: Alberto Di Maria <[email protected]>
Co-authored-by: Alberto Di Maria <[email protected]>
Co-authored-by: Alberto Di Maria <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes requested implemented
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Close #5756
Checklist