Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: Analysis init refactoring #5825

Closed
wants to merge 6 commits into from
Closed

REFACTOR: Analysis init refactoring #5825

wants to merge 6 commits into from

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Feb 25, 2025 •
edited
Loading

Description

Issue linked

Close #5826

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov Codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 18.06%. Comparing base (a3541b2) to head (cffade4).

❌ Your patch status has failed because the patch coverage (7.14%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #5825       +/-   ##
===========================================
- Coverage   81.18%   18.06%   -63.12%     
===========================================
  Files         160      160               
  Lines       61960    61962        +2     
===========================================
- Hits        50304    11196    -39108     
- Misses      11656    50766    +39110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmalinve gmalinve Awaiting requested review from gmalinve

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analysis class initialization
1 participant
@Samuelopez-ansys