From 0bebdd4c8e17ae51dc326ad91a5574cb1040e235 Mon Sep 17 00:00:00 2001 From: Samuelopez-ansys Date: Tue, 25 Feb 2025 08:26:41 +0100 Subject: [PATCH 1/5] Initialize properties as None in analysis.py --- src/ansys/aedt/core/application/analysis.py | 23 ++++++++++++--------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/ansys/aedt/core/application/analysis.py b/src/ansys/aedt/core/application/analysis.py index 6503be880a8..863c0ac1894 100644 --- a/src/ansys/aedt/core/application/analysis.py +++ b/src/ansys/aedt/core/application/analysis.py @@ -153,16 +153,16 @@ def __init__( ic_mode, remove_lock, ) - self._excitation_objects = {} + self._excitation_objects = None self._setup = None if setup_name: self.active_setup = setup_name self._materials = None self._available_variations = None - self._setups = [] - self._parametrics = [] - self._optimizations = [] - self._native_components = [] + self._setups = None + self._parametrics = None + self._optimizations = None + self._native_components = None self.SOLUTIONS = SOLUTIONS() self.SETUPS = SETUPS() self.AXIS = AXIS() @@ -185,7 +185,7 @@ def native_components(self): ------- dict[str, :class:`ansys.aedt.core.modules.Boundaries.NativeComponentObject`] """ - if not self._native_components: + if self._native_components is None: self._native_components = self._get_native_data() return {nc.name: nc for nc in self._native_components} @@ -244,7 +244,7 @@ def setups(self): Setups in the project. """ - if not self._setups: + if self._setups is None: if self.design_type not in ["Maxwell Circuit", "Circuit Netlist"]: self._setups = [self.get_setup(setup_name) for setup_name in self.setup_names] return self._setups @@ -259,7 +259,7 @@ def parametrics(self): Parametric setups in the project. """ - if not self._parametrics: + if self._parametrics is None: self._parametrics = ParametricSetups(self) return self._parametrics @@ -273,7 +273,7 @@ def optimizations(self): Parametric setups in the project. """ - if not self._optimizations: + if self._optimizations is None: self._optimizations = OptimizationSetups(self) return self._optimizations @@ -318,7 +318,7 @@ def active_setup(self): ---------- >>> oModule.GetAllSolutionSetups() """ - if self._setup: + if self._setup is not None: return self._setup elif self.existing_analysis_setups: return self.existing_analysis_setups[0] @@ -529,6 +529,9 @@ def excitation_objects(self): ---------- >>> oModule.GetExcitations """ + if self._excitation_objects is None: + self._excitation_objects = {} + exc_names = self.excitations[::] for el in self.boundaries: From 125cb62a8805caaaae3d03b8e41840af3dac5d80 Mon Sep 17 00:00:00 2001 From: Samuelopez-ansys Date: Tue, 25 Feb 2025 08:27:13 +0100 Subject: [PATCH 2/5] Update dev version --- src/ansys/aedt/core/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ansys/aedt/core/__init__.py b/src/ansys/aedt/core/__init__.py index 19280cff54a..eb333f254cc 100644 --- a/src/ansys/aedt/core/__init__.py +++ b/src/ansys/aedt/core/__init__.py @@ -71,7 +71,7 @@ def custom_show_warning(message, category, filename, lineno, file=None, line=Non # pyaedt_path = os.path.dirname(__file__) -__version__ = "0.15.dev0" +__version__ = "0.16.dev0" version = __version__ # isort: off From 239467ac5ebdb8c59aa0f06b5c37dc1fb536c21a Mon Sep 17 00:00:00 2001 From: Samuelopez-ansys Date: Tue, 25 Feb 2025 10:12:39 +0100 Subject: [PATCH 3/5] Update test --- tests/system/general/test_01_3dlayout_edb.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/system/general/test_01_3dlayout_edb.py b/tests/system/general/test_01_3dlayout_edb.py index e14a90e069a..42912bb702b 100644 --- a/tests/system/general/test_01_3dlayout_edb.py +++ b/tests/system/general/test_01_3dlayout_edb.py @@ -184,7 +184,7 @@ def test_03_get_pins(self, aedtapp): assert pins["L10-1"].object_units == "mm" assert pins["L10-1"].componentname == "L10" assert pins["L10-1"].is_pin - assert pins["L10-1"].angle == "90deg" or pins["L10-1"].angle == "-270deg" + assert pins["L10-1"].angle == "0deg" assert pins["L10-1"].location[0] != 0 assert pins["L10-1"].start_layer == "1_Top" assert pins["L10-1"].stop_layer == "1_Top" From 75c0ab7f32b9e02a56c1d57f6b819cfb277e8dc9 Mon Sep 17 00:00:00 2001 From: Samuelopez-ansys Date: Tue, 25 Feb 2025 12:19:44 +0100 Subject: [PATCH 4/5] Fix internal property usage --- src/ansys/aedt/core/application/analysis_3d_layout.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ansys/aedt/core/application/analysis_3d_layout.py b/src/ansys/aedt/core/application/analysis_3d_layout.py index a54fd0aeab6..add4ce7c71d 100644 --- a/src/ansys/aedt/core/application/analysis_3d_layout.py +++ b/src/ansys/aedt/core/application/analysis_3d_layout.py @@ -351,7 +351,7 @@ def get_setup(self, name, setup_type=None): """ if setup_type is None: setup_type = self.design_solutions.default_setup - for setup in self._setups: + for setup in self.setups: if name == setup.name: return setup setup = Setup3DLayout(self, setup_type, name, is_new_setup=False) From cffade415171b82285043f64cdef18dcc67e257a Mon Sep 17 00:00:00 2001 From: Samuelopez-ansys Date: Tue, 25 Feb 2025 12:21:07 +0100 Subject: [PATCH 5/5] Modify docstring --- src/ansys/aedt/core/modules/solve_setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ansys/aedt/core/modules/solve_setup.py b/src/ansys/aedt/core/modules/solve_setup.py index 2a5af1c1a02..77b9a628709 100644 --- a/src/ansys/aedt/core/modules/solve_setup.py +++ b/src/ansys/aedt/core/modules/solve_setup.py @@ -3946,7 +3946,7 @@ class SetupQ3D(Setup, object): Parameters ---------- - app : :class:`ansys.aedt.core.application.analysis_3d.FieldAnalysis3D` + app : :class:`ansys.aedt.core.application.analysis.Analysis` Inherited app object. solution_type : int, str Type of the setup.