Skip to content

Conversation

@hui-zhou-a
Copy link
Contributor

@hui-zhou-a hui-zhou-a commented Oct 24, 2025

Description

The test is too heavy for Linux. Simplify the test by providing empty configure file.

EDB configuration is covered by pyedb tests, so there is no need to test its backend function in the extension test

Issue linked

#6788 #6828

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@hui-zhou-a hui-zhou-a requested a review from a team as a code owner October 24, 2025 00:28
@github-actions github-actions bot added the bug Something isn't working label Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.48%. Comparing base (3751f04) to head (186e24f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6809      +/-   ##
==========================================
+ Coverage   81.53%   83.48%   +1.95%     
==========================================
  Files         245      245              
  Lines       77680    77681       +1     
==========================================
+ Hits        63334    64853    +1519     
+ Misses      14346    12828    -1518     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys
Copy link
Collaborator

Hi @hui-zhou-a, could you please extend your PR to handle #6788 ?
We have had to disable the flaky tests from the CI because it was impacting all of the PRs and required us to rerun the job multiple times (very often), cf #6839

@hui-zhou-a
Copy link
Contributor Author

@SMoraisAnsys all fixed.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @hui-zhou-a
Can you also update the CI so that we don't skip the flaky test anymore ?

@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 13, 2025
@hui-zhou-a
Copy link
Contributor Author

export IPC still causes Python fatal error even a very small PCB is used in the test. This method uses subprocess. It seems something wrong with the VM machine.

@hui-zhou-a
Copy link
Contributor Author

@eblanco-ansys test_export_layout_all_options is testing the backend, which I don't think it is necessary. The backend is tested in pyedb already.

@SMoraisAnsys
Copy link
Collaborator

@eblanco-ansys test_export_layout_all_options is testing the backend, which I don't think it is necessary. The backend is tested in pyedb already.

Then why do we have an issue here ? Having a test failing in pyaedt only implies that working with both of them can be an issue for our users.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good idea to mix

@pytest.mark.skipif(is_linux, reason="Lead to Python fatal error on Linux machines.")
and
@pytest.mark.flaky_linux

If there is an issue with linux, we need to understand why. Disabling test is only a temporary solution. If at the end we can't have tests passing correctly then shouldn't this method be limited to windows only if it's not stable in linux ?

@hui-zhou-a
Copy link
Contributor Author

hui-zhou-a commented Nov 13, 2025

@SMoraisAnsys I agree to limit this method to windows. This method never fail in pyedb tests. I highly suspect the PyAEDT CI linux machine is not stable. Could you approve this PR? This PR fixes a critical bug in configure layout extension. Eduardo is going to make a patch today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in Configure layout extension CI: Refactor code related to test_apply_config_to_edb or strengthen CI

4 participants