-
Notifications
You must be signed in to change notification settings - Fork 201
FIX: test_configure_layout.py #6809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6809 +/- ##
==========================================
+ Coverage 81.53% 83.48% +1.95%
==========================================
Files 245 245
Lines 77680 77681 +1
==========================================
+ Hits 63334 64853 +1519
+ Misses 14346 12828 -1518 🚀 New features to boost your workflow:
|
|
Hi @hui-zhou-a, could you please extend your PR to handle #6788 ? |
|
@SMoraisAnsys all fixed. |
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @hui-zhou-a
Can you also update the CI so that we don't skip the flaky test anymore ?
|
export IPC still causes Python fatal error even a very small PCB is used in the test. This method uses subprocess. It seems something wrong with the VM machine. |
|
@eblanco-ansys test_export_layout_all_options is testing the backend, which I don't think it is necessary. The backend is tested in pyedb already. |
Then why do we have an issue here ? Having a test failing in pyaedt only implies that working with both of them can be an issue for our users. |
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a good idea to mix
@pytest.mark.skipif(is_linux, reason="Lead to Python fatal error on Linux machines.")
and
@pytest.mark.flaky_linux
If there is an issue with linux, we need to understand why. Disabling test is only a temporary solution. If at the end we can't have tests passing correctly then shouldn't this method be limited to windows only if it's not stable in linux ?
|
@SMoraisAnsys I agree to limit this method to windows. This method never fail in pyedb tests. I highly suspect the PyAEDT CI linux machine is not stable. Could you approve this PR? This PR fixes a critical bug in configure layout extension. Eduardo is going to make a patch today. |
Description
The test is too heavy for Linux. Simplify the test by providing empty configure file.
EDB configuration is covered by pyedb tests, so there is no need to test its backend function in the extension test
Issue linked
#6788 #6828
Checklist