Skip to content

Conversation

@alexciurana
Copy link
Contributor

Description

Please provide a brief description of the changes made in this pull request.

Modified if/else condition when checking the Ansys EM path retrieved from the PYAEDT_SERVER_AEDT_PATH env var to avoid the case where it exists but it's overridden with the latest one installed in the system.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

#6866

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@alexciurana alexciurana self-assigned this Nov 10, 2025
@alexciurana alexciurana marked this pull request as ready for review November 10, 2025 10:28
@alexciurana alexciurana requested a review from a team as a code owner November 10, 2025 10:28
@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 10, 2025
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.48%. Comparing base (a2e6778) to head (0404ae1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6867      +/-   ##
==========================================
- Coverage   83.51%   83.48%   -0.03%     
==========================================
  Files         246      246              
  Lines       77864    77864              
==========================================
- Hits        65027    65006      -21     
- Misses      12837    12858      +21     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Good catch!

@Samuelopez-ansys
Copy link
Member

@SMoraisAnsys @ecoussoux-ansys Do you know why smoke tests are failing? It is related to wsproto module... we could skip it...

@SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys @ecoussoux-ansys Do you know why smoke tests are failing? It is related to wsproto module... we could skip it...

This is now handled :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants