-
Notifications
You must be signed in to change notification settings - Fork 201
FIX: ServiceManager.start_service ignores configured AEDT path in PYAEDT_SERVER_AEDT_PATH env var #6867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ub.com/ansys/pyaedt into aciurana/fix_start_service_ansysempath
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6867 +/- ##
==========================================
- Coverage 83.51% 83.48% -0.03%
==========================================
Files 246 246
Lines 77864 77864
==========================================
- Hits 65027 65006 -21
- Misses 12837 12858 +21 🚀 New features to boost your workflow:
|
Samuelopez-ansys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Good catch!
|
@SMoraisAnsys @ecoussoux-ansys Do you know why smoke tests are failing? It is related to wsproto module... we could skip it... |
This is now handled :) |
Description
Please provide a brief description of the changes made in this pull request.
Modified if/else condition when checking the Ansys EM path retrieved from the
PYAEDT_SERVER_AEDT_PATHenv var to avoid the case where it exists but it's overridden with the latest one installed in the system.Issue linked
Please mention the issue number or describe the problem this pull request addresses.
#6866
Checklist