Skip to content

Commit 5be173a

Browse files
authored
feat: type hint and docstring length (#340)
1 parent ed8909a commit 5be173a

File tree

10 files changed

+711
-231
lines changed

10 files changed

+711
-231
lines changed

.github/workflows/ci_cd.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ on:
1414
- main
1515

1616
env:
17-
MAIN_PYTHON_VERSION: '3.10'
17+
MAIN_PYTHON_VERSION: '3.12'
1818
PACKAGE_NAME: 'pyconverter-xml2py'
1919
PACKAGE_NAMESPACE: 'pyconverter.xml2py'
2020
DOCUMENTATION_CNAME: 'pyconverter-xml2py.docs.pyansys.com'
21-
RESET_PIP_CACHE: 2
22-
RESET_AUTOSUMMARY_CACHE: 2
23-
RESET_DOC_BUILD_CACHE: 2
21+
RESET_PIP_CACHE: 10
22+
RESET_AUTOSUMMARY_CACHE: 10
23+
RESET_DOC_BUILD_CACHE: 10
2424
ON_CI: true
2525

2626
concurrency:
@@ -48,7 +48,6 @@ jobs:
4848
with:
4949
token: ${{ secrets.GITHUB_TOKEN }}
5050

51-
5251
smoke-tests:
5352
name: Build and Smoke tests (Linux)
5453
runs-on: ubuntu-latest
@@ -229,6 +228,8 @@ jobs:
229228
with:
230229
cname: ${{ env.DOCUMENTATION_CNAME }}
231230
token: ${{ secrets.GITHUB_TOKEN }}
231+
bot-user: ${{ secrets.PYANSYS_CI_BOT_USERNAME }}
232+
bot-email: ${{ secrets.PYANSYS_CI_BOT_EMAIL }}
232233

233234

234235
release:
@@ -262,4 +263,5 @@ jobs:
262263
with:
263264
cname: ${{ env.DOCUMENTATION_CNAME }}
264265
token: ${{ secrets.GITHUB_TOKEN }}
265-
python-version: ${{ env.MAIN_PYTHON_VERSION }}
266+
bot-user: ${{ secrets.PYANSYS_CI_BOT_USERNAME }}
267+
bot-email: ${{ secrets.PYANSYS_CI_BOT_EMAIL }}

doc/source/user_guide/source_code.rst

+6-6
Original file line numberDiff line numberDiff line change
@@ -146,21 +146,21 @@ into account and added to the Python docstring:
146146
147147
Parameters
148148
----------
149-
nl1 : str
149+
nl1: str
150150
Number of the first line to be hit (touched by the end of the new line). If negative, assume ``P1`` (see below) is the second keypoint of the line instead of the first
151-
nl2 : str
151+
nl2: str
152152
Number of the second line to be hit. If negative, assume ``P3`` is the second keypoint of the line instead of the first.
153153
154-
ang1 : str
154+
ang1: str
155155
Angle of intersection (usually zero or 180) of generated line with tangent to first line.
156156
157-
ang2 : str
157+
ang2: str
158158
Angle of intersection (usually zero or 180) of generated line with tangent to second line.
159159
160-
phit1 : str
160+
phit1: str
161161
Number to be assigned to keypoint generated at hit location on first line (defaults to lowest available keypoint number ( :ref:`numstr` )).
162162
163-
phit2 : str
163+
phit2: str
164164
Number to be assigned to keypoint generated at hit location on second line (defaults to lowest available keypoint number ( :ref:`numstr` )).
165165
166166
Returns

pyproject.toml

+3
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ dependencies = [
2929
"click>=7.0,<9.0.0",
3030
"importlib-metadata>=4.0",
3131
"pygithub>=1.59.1",
32+
"inflect>=7.0.0",
3233
"lxml>=4.9.3",
3334
"numpy>=1.14.0,<1.25.0; python_version<'3.9'",
3435
"numpy>=1.14.0; python_version>='3.9'",
@@ -44,6 +45,7 @@ dependencies = [
4445
tests = [
4546
"black>=24.2.0",
4647
"click==8.1.7",
48+
"inflect==7.4.0",
4749
"pygithub==2.4.0",
4850
"lxml==5.3.0",
4951
"numpy==2.1.2",
@@ -59,6 +61,7 @@ doc = [
5961
"ansys-sphinx-theme[autoapi]==1.1.5",
6062
"build>= 0.10.0",
6163
"flit>=3.8.0",
64+
"inflect==7.4.0",
6265
"jupyter_sphinx==0.5.3",
6366
"numpy==2.1.2",
6467
"numpydoc==1.8.0",

0 commit comments

Comments
 (0)