Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Submodule workspace #888

Merged
merged 14 commits into from
Feb 15, 2024
Merged

chore: Submodule workspace #888

merged 14 commits into from
Feb 15, 2024

Conversation

0xJepsen
Copy link
Collaborator

@0xJepsen 0xJepsen commented Feb 14, 2024

Give an overview of the tasks completed
configured the submodule to be a workspace in the root repository
configured dependency discrepancies

Link to issue(s) that this PR closes

REMINDER! Please check that you have done the following prior to submitting this PR:

  • Checked that the relevant version(s) have been incremented if necessary.
  • Ran both and made any changes necessary for:
    • cargo +nightly fmt --all
    • cargo clippy --all

You can install the nightly toolchain on your system by:

rustup toolchain install nightly

@Autoparallel
Copy link
Collaborator

I made a few changes in the workflows to pull the submodule. All seems well now :)

Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xJepsen 0xJepsen merged commit fe6b556 into main Feb 15, 2024
8 checks passed
@0xJepsen 0xJepsen deleted the submodule_template branch February 15, 2024 01:51
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants