Skip to content

Commit 183b2a2

Browse files
committed
[themes] theme names are all not localized. Fixes microsoft#109840
1 parent c8b48d0 commit 183b2a2

File tree

22 files changed

+73
-48
lines changed

22 files changed

+73
-48
lines changed

Diff for: extensions/theme-abyss/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
"contributes": {
1010
"themes": [
1111
{
12-
"label": "Abyss",
12+
"id": "Abyss",
13+
"label": "%themeLabel%",
1314
"uiTheme": "vs-dark",
1415
"path": "./themes/abyss-color-theme.json"
1516
}
1617
]
1718
}
18-
}
19+
}

Diff for: extensions/theme-abyss/package.nls.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"displayName": "Abyss Theme",
3-
"description": "Abyss theme for Visual Studio Code"
4-
}
3+
"description": "Abyss theme for Visual Studio Code",
4+
"themeLabel": "Abyss"
5+
}

Diff for: extensions/theme-defaults/package.json

+7-7
Original file line numberDiff line numberDiff line change
@@ -11,41 +11,41 @@
1111
"themes": [
1212
{
1313
"id": "Default Dark+",
14-
"label": "Dark+ (default dark)",
14+
"label": "%darkPlusColorThemeLabel%",
1515
"uiTheme": "vs-dark",
1616
"path": "./themes/dark_plus.json"
1717
},
1818
{
1919
"id": "Default Light+",
20-
"label": "Light+ (default light)",
20+
"label": "%lightPlusColorThemeLabel%",
2121
"uiTheme": "vs",
2222
"path": "./themes/light_plus.json"
2323
},
2424
{
2525
"id": "Visual Studio Dark",
26-
"label": "Dark (Visual Studio)",
26+
"label": "%darkColorThemeLabel%",
2727
"uiTheme": "vs-dark",
2828
"path": "./themes/dark_vs.json"
2929
},
3030
{
3131
"id": "Visual Studio Light",
32-
"label": "Light (Visual Studio)",
32+
"label": "%lightColorThemeLabel%",
3333
"uiTheme": "vs",
3434
"path": "./themes/light_vs.json"
3535
},
3636
{
3737
"id": "Default High Contrast",
38-
"label": "High Contrast",
38+
"label": "%hcColorThemeLabel%",
3939
"uiTheme": "hc-black",
4040
"path": "./themes/hc_black.json"
4141
}
4242
],
4343
"iconThemes": [
4444
{
4545
"id": "vs-minimal",
46-
"label": "Minimal (Visual Studio Code)",
46+
"label": "%minimalIconThemeLabel%",
4747
"path": "./fileicons/vs_minimal-icon-theme.json"
4848
}
4949
]
5050
}
51-
}
51+
}

Diff for: extensions/theme-defaults/package.nls.json

+8-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,10 @@
11
{
22
"displayName": "Default Themes",
3-
"description": "The default Visual Studio light and dark themes"
4-
}
3+
"description": "The default Visual Studio light and dark themes",
4+
"darkPlusColorThemeLabel": "Dark+ (default dark)",
5+
"lightPlusColorThemeLabel": "Light+ (default light)",
6+
"darkColorThemeLabel": "Dark (Visual Studio)",
7+
"lightColorThemeLabel": "Light (Visual Studio)",
8+
"hcColorThemeLabel": "High Contrast",
9+
"minimalIconThemeLabel": "Minimal (Visual Studio Code)",
10+
}

Diff for: extensions/theme-kimbie-dark/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
"contributes": {
1010
"themes": [
1111
{
12-
"label": "Kimbie Dark",
12+
"id": "Kimbie Dark",
13+
"label": "%themeLabel%",
1314
"uiTheme": "vs-dark",
1415
"path": "./themes/kimbie-dark-color-theme.json"
1516
}
1617
]
1718
}
18-
}
19+
}

Diff for: extensions/theme-kimbie-dark/package.nls.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"displayName": "Kimbie Dark Theme",
3-
"description": "Kimbie dark theme for Visual Studio Code"
4-
}
3+
"description": "Kimbie dark theme for Visual Studio Code",
4+
"themeLabel": "Kimbie Dark"
5+
}

Diff for: extensions/theme-monokai-dimmed/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,11 @@
1111
"contributes": {
1212
"themes": [
1313
{
14-
"label": "Monokai Dimmed",
14+
"id": "Monokai Dimmed",
15+
"label": "%themeLabel%",
1516
"uiTheme": "vs-dark",
1617
"path": "./themes/dimmed-monokai-color-theme.json"
1718
}
1819
]
1920
}
20-
}
21+
}

Diff for: extensions/theme-monokai-dimmed/package.nls.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"displayName": "Monokai Dimmed Theme",
3-
"description": "Monokai dimmed theme for Visual Studio Code"
4-
}
3+
"description": "Monokai dimmed theme for Visual Studio Code",
4+
"themeLabel": "Monokai Dimmed"
5+
}

Diff for: extensions/theme-monokai/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,11 @@
1111
"contributes": {
1212
"themes": [
1313
{
14-
"label": "Monokai",
14+
"id": "Monokai",
15+
"label": "%themeLabel%",
1516
"uiTheme": "vs-dark",
1617
"path": "./themes/monokai-color-theme.json"
1718
}
1819
]
1920
}
20-
}
21+
}

Diff for: extensions/theme-monokai/package.nls.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"displayName": "Monokai Theme",
3-
"description": "Monokai theme for Visual Studio Code"
4-
}
3+
"description": "Monokai theme for Visual Studio Code",
4+
"themeLabel": "Monokai"
5+
}

Diff for: extensions/theme-quietlight/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,11 @@
1111
"contributes": {
1212
"themes": [
1313
{
14-
"label": "Quiet Light",
14+
"id": "Quiet Light",
15+
"label": "%themeLabel%",
1516
"uiTheme": "vs",
1617
"path": "./themes/quietlight-color-theme.json"
1718
}
1819
]
1920
}
20-
}
21+
}

Diff for: extensions/theme-quietlight/package.nls.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"displayName": "Quiet Light Theme",
3-
"description": "Quiet light theme for Visual Studio Code"
4-
}
3+
"description": "Quiet light theme for Visual Studio Code",
4+
"themeLabel": "Quiet Light"
5+
}

Diff for: extensions/theme-red/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
"contributes": {
1010
"themes": [
1111
{
12-
"label": "Red",
12+
"id": "Red",
13+
"label": "%themeLabel%",
1314
"uiTheme": "vs-dark",
1415
"path": "./themes/Red-color-theme.json"
1516
}
1617
]
1718
}
18-
}
19+
}

Diff for: extensions/theme-red/package.nls.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"displayName": "Red Theme",
3-
"description": "Red theme for Visual Studio Code"
4-
}
3+
"description": "Red theme for Visual Studio Code",
4+
"themeLabel": "Red"
5+
}

Diff for: extensions/theme-seti/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"iconThemes": [
1616
{
1717
"id": "vs-seti",
18-
"label": "Seti (Visual Studio Code)",
18+
"label": "%themeLabel%",
1919
"path": "./icons/vs-seti-icon-theme.json"
2020
}
2121
]

Diff for: extensions/theme-seti/package.nls.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"displayName": "Seti File Icon Theme",
3-
"description": "A file icon theme made out of the Seti UI file icons"
4-
}
3+
"description": "A file icon theme made out of the Seti UI file icons",
4+
"themeLabel": "Seti (Visual Studio Code)"
5+
}

Diff for: extensions/theme-solarized-dark/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
"contributes": {
1010
"themes": [
1111
{
12-
"label": "Solarized Dark",
12+
"id": "Solarized Dark",
13+
"label": "%themeLabel%",
1314
"uiTheme": "vs-dark",
1415
"path": "./themes/solarized-dark-color-theme.json"
1516
}
1617
]
1718
}
18-
}
19+
}

Diff for: extensions/theme-solarized-dark/package.nls.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"displayName": "Solarized Dark Theme",
3-
"description": "Solarized dark theme for Visual Studio Code"
4-
}
3+
"description": "Solarized dark theme for Visual Studio Code",
4+
"themeLabel": "Solarized Dark"
5+
}

Diff for: extensions/theme-solarized-light/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
"contributes": {
1010
"themes": [
1111
{
12-
"label": "Solarized Light",
12+
"id": "Solarized Light",
13+
"label": "%themeLabel%",
1314
"uiTheme": "vs",
1415
"path": "./themes/solarized-light-color-theme.json"
1516
}
1617
]
1718
}
18-
}
19+
}

Diff for: extensions/theme-solarized-light/package.nls.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"displayName": "Solarized Light Theme",
3-
"description": "Solarized light theme for Visual Studio Code"
4-
}
3+
"description": "Solarized light theme for Visual Studio Code",
4+
"themeLabel": "Solarized Light"
5+
}

Diff for: extensions/theme-tomorrow-night-blue/package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@
99
"contributes": {
1010
"themes": [
1111
{
12-
"label": "Tomorrow Night Blue",
12+
"id": "Tomorrow Night Blue",
13+
"label": "%themeLabel%",
1314
"uiTheme": "vs-dark",
1415
"path": "./themes/tomorrow-night-blue-theme.json"
1516
}
1617
]
1718
}
18-
}
19+
}
+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"displayName": "Tomorrow Night Blue Theme",
3-
"description": "Tomorrow night blue theme for Visual Studio Code"
4-
}
3+
"description": "Tomorrow night blue theme for Visual Studio Code",
4+
"themeLabel": "Quiet Light"
5+
}

0 commit comments

Comments
 (0)