Skip to content

Commit 7f43e5c

Browse files
committed
unHidePreview should also update dimensions
1 parent d949fd3 commit 7f43e5c

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -437,9 +437,7 @@ function webviewPreloads() {
437437
cellContainer.style.visibility = 'visible';
438438
}
439439

440-
if (typeof data.content === 'string') {
441-
updateMarkdownPreview(data.id, data.content);
442-
}
440+
updateMarkdownPreview(data.id, data.content);
443441
}
444442
break;
445443
case 'hideMarkdownPreview':
@@ -458,6 +456,7 @@ function webviewPreloads() {
458456
if (cellContainer) {
459457
cellContainer.style.visibility = 'visible';
460458
}
459+
updateMarkdownPreview(event.data.id, undefined);
461460
}
462461
break;
463462
case 'removeMarkdownPreview':
@@ -809,18 +808,21 @@ function webviewPreloads() {
809808
});
810809
}
811810

812-
function updateMarkdownPreview(cellId: string, content: string) {
811+
function updateMarkdownPreview(cellId: string, content: string | undefined) {
813812
const previewContainerNode = document.getElementById(`${cellId}_preview`);
814813
if (!previewContainerNode) {
815814
return;
816815
}
817816

818817
// TODO: handle namespace
819-
onDidCreateMarkdown.fire([undefined /* data.apiNamespace */, {
820-
element: previewContainerNode,
821-
content: content
822-
}]);
818+
if (typeof content === 'string') {
819+
onDidCreateMarkdown.fire([undefined /* data.apiNamespace */, {
820+
element: previewContainerNode,
821+
content: content
822+
}]);
823+
}
823824

825+
console.log(previewContainerNode.clientHeight);
824826
postNotebookMessage<IDimensionMessage>('dimension', {
825827
id: `${cellId}_preview`,
826828
data: {

0 commit comments

Comments
 (0)