update code to be compliant with drupal 8.8 & drupal 9

Author: WengerK

src/Controller/AdminSuggestionController.php

@@ -2,6 +2,7 @@
 
 namespace Drupal\template_whisperer\Controller;
 
+use Drupal\Core\Pager\PagerManagerInterface;
 use Drupal\template_whisperer\Entity\TemplateWhispererSuggestionEntityInterface;
 use Drupal\Core\Controller\ControllerBase;
 use Symfony\Component\DependencyInjection\ContainerInterface;
@@ -35,13 +36,21 @@ class AdminSuggestionController extends ControllerBase {
    */
   protected $urlGenerator;
 
+  /**
+   * The pager manager.
+   *
+   * @var \Drupal\Core\Pager\PagerManagerInterface
+   */
+  protected $pagerManager;
+
   /**
    * Class constructor.
    */
-  public function __construct(EntityTypeManagerInterface $entity_type_manager, TemplateWhispererSuggestionUsage $tw_suggestion_usage, UrlGeneratorInterface $url_generator) {
+  public function __construct(EntityTypeManagerInterface $entity_type_manager, TemplateWhispererSuggestionUsage $tw_suggestion_usage, UrlGeneratorInterface $url_generator, PagerManagerInterface $pager_manager) {
     $this->entityTypeManager = $entity_type_manager;
     $this->twSuggestionUsage = $tw_suggestion_usage;
     $this->urlGenerator      = $url_generator;
+    $this->pagerManager      = $pager_manager;
   }
 
   /**
@@ -50,10 +59,11 @@ public function __construct(EntityTypeManagerInterface $entity_type_manager, Tem
   public static function create(ContainerInterface $container) {
     // Instantiates this form class.
     return new static(
-    // Load the service required to construct this class.
-    $container->get('entity_type.manager'),
-    $container->get('template_whisperer.suggestion.usage'),
-    $container->get('url_generator')
+      // Load the service required to construct this class.
+      $container->get('entity_type.manager'),
+      $container->get('template_whisperer.suggestion.usage'),
+      $container->get('url_generator'),
+      $container->get('pager.manager')
     );
   }
 
@@ -84,8 +94,8 @@ public function usage(TemplateWhispererSuggestionEntityInterface $template_whisp
     $usages = $this->twSuggestionUsage->listUsage($template_whisperer_suggestion);
     $count = $this->twSuggestionUsage->countUsage($template_whisperer_suggestion);
 
+    $this->pagerManager->createPager($count, 30);
     // Pager.
-    pager_default_initialize($count, 30);
     $output[] = [
       '#type'     => 'pager',
       '#quantity' => '3',
@@ -105,7 +115,7 @@ public function usage(TemplateWhispererSuggestionEntityInterface $template_whisp
 
       // Build the table empty state.
       if (!empty($entity)) {
-        $output['table'][$i]['entity'] = ['#markup' => '<a target="_blank" href="' . $entity->url() . '">' . $entity->getTitle() . '</a>'];
+        $output['table'][$i]['entity'] = ['#markup' => '<a target="_blank" href="' . $entity->toUrl()->toString() . '">' . $entity->getTitle() . '</a>'];
       }
     }
 

src/Entity/TemplateWhispererSuggestionEntity.php

@@ -34,6 +34,11 @@
  *     "collection" = "/admin/structure/template-whisperer",
  *     "usage" = "/admin/structure/template-whisperer/{template_whisperer_suggestion}/usage",
  *   },
+ *   config_export = {
+ *     "id",
+ *     "name",
+ *     "suggestion",
+ *   }
  * )
  */
 class TemplateWhispererSuggestionEntity extends ConfigEntityBase implements TemplateWhispererSuggestionEntityInterface {

src/Plugin/Condition/TemplateWhisperer.php

@@ -15,7 +15,7 @@
  * @Condition(
  *   id = "template_whisperer",
  *   label = @Translation("Template Whisperer"),
- *   context = {
+ *   context_definitions = {
  *     "node" = @ContextDefinition("entity:node", label = @Translation("Node"))
  *   }
  * )

src/TemplateWhispererSuggestionListBuilder.php

@@ -8,6 +8,7 @@
 use Drupal\Core\Entity\EntityStorageInterface;
 use Drupal\Core\Routing\UrlGeneratorInterface;
 use Drupal\Core\Entity\EntityInterface;
+use Drupal\Core\Entity\EntityTypeManagerInterface;
 
 /**
  * Defines a class to build a listing of templates whisperer entities.
@@ -54,7 +55,7 @@ public function __construct(EntityTypeInterface $entity_type, EntityStorageInter
   public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) {
     return new static(
       $entity_type,
-      $container->get('entity.manager')->getStorage($entity_type->id()),
+      $container->get('entity_type.manager')->getStorage($entity_type->id()),
       $container->get('url_generator'),
       $container->get('template_whisperer.suggestion.usage')
     );

template_whisperer.info.yml

@@ -1,7 +1,7 @@
 name: Template Whisperer
 type: module
 description: Provides a formalized way to declare and suggest page templates.
-core: 8.x
+core_version_requirement: ^8.8 || ^9
 package: Fields types
 
 dependencies:

tests/src/Functional/TemplateWhispererTestBase.php

@@ -9,6 +9,11 @@
  */
 abstract class TemplateWhispererTestBase extends BrowserTestBase {
 
+  /**
+   * {@inheritdoc}
+   */
+  protected $defaultTheme = 'classy';
+
   /**
    * Enables Twig debugging.
    */

tests/src/Functional/UiFieldTest.php

@@ -12,6 +12,11 @@
  */
 class UiFieldTest extends TemplateWhispererTestBase {
 
+  /**
+   * {@inheritdoc}
+   */
+  protected $defaultTheme = 'stark';
+
   /**
    * {@inheritdoc}
    */

tests/src/Functional/UiPageTest.php

@@ -12,6 +12,11 @@
  */
 class UiPageTest extends TemplateWhispererTestBase {
 
+  /**
+   * {@inheritdoc}
+   */
+  protected $defaultTheme = 'stark';
+
   /**
    * {@inheritdoc}
    */

tests/src/Functional/WidgetFormElementTest.php

@@ -2,6 +2,8 @@
 
 namespace Drupal\Tests\template_whisperer\Functional;
 
+use Drupal\Core\Entity\Entity\EntityFormDisplay;
+
 /**
  * @coversDefaultClass \Drupal\template_whisperer\Plugin\Field\FieldWidget\TemplateWhispererWidget
  *
@@ -90,11 +92,10 @@ protected function setupArticle() {
       'bundle'        => 'article',
     ])->save();
 
-    entity_get_form_display('node', 'article', 'default')
-      ->setComponent('field_template_whisperer_1', [
-        'type' => 'template_whisperer',
-        'weight' => 20,
-      ])->save();
+    EntityFormDisplay::load('node.article.default')->setComponent('field_template_whisperer_1', [
+      'type' => 'template_whisperer',
+      'weight' => 20,
+    ])->save();
 
     $this->article = $em->getStorage('node')->create([
       'type'  => 'article',
@@ -127,11 +128,15 @@ protected function setupTag() {
       'bundle'        => 'tags',
     ])->save();
 
-    entity_get_form_display('taxonomy_term', 'tags', 'default')
-      ->setComponent('field_template_whisperer_2', [
-        'type' => 'template_whisperer',
-        'weight' => 20,
-      ])->save();
+    EntityFormDisplay::create([
+      'targetEntityType' => 'taxonomy_term',
+      'bundle' => 'tags',
+      'mode' => 'default',
+      'status' => TRUE,
+    ])->setComponent('field_template_whisperer_2', [
+      'type' => 'template_whisperer',
+      'weight' => 20,
+    ])->save();
 
     $this->tag = $em->getStorage('taxonomy_term')->create([
       'name' => 'Tags N°1',