Merge branch 'main' into feat/toggle-upsells

kanhayaKy · web-flow · commit f27327f7dec2 · 2025-09-11T18:40:09.000+05:30
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -2,6 +2,10 @@ name: Tests
 
 on:
   push:
+    branches:
+      - '**'
+    tags-ignore:
+      - 'production-*'
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
diff --git a/app/javascript/components/Download/OpenInAppButton.tsx b/app/javascript/components/Download/OpenInAppButton.tsx
@@ -7,6 +7,7 @@ type Props = { iosAppUrl: string; androidAppUrl: string };
 export const OpenInAppButton = ({ iosAppUrl, androidAppUrl }: Props) => (
   <Popover trigger={<span className="button">Open in app</span>}>
     <div
+      className="mx-auto"
       style={{
         display: "grid",
         textAlign: "center",
diff --git a/app/javascript/components/Post/PostCommentsSection.tsx b/app/javascript/components/Post/PostCommentsSection.tsx
@@ -113,6 +113,7 @@ export const PostCommentsSection = ({ paginated_comments }: Props) => {
       });
       showAlert("Successfully posted your comment", "success");
       upsertComment(comment);
+      setDraft(null);
     } catch (e) {
       assertResponseError(e);
       showAlert(`An error occurred while posting your comment - ${e.message}`, "error");
diff --git a/app/javascript/components/Settings/PaymentsPage/BankAccountSection.tsx b/app/javascript/components/Settings/PaymentsPage/BankAccountSection.tsx
@@ -939,7 +939,7 @@ const BankAccountSection = ({
         </fieldset>
         <div style={{ display: "grid", gap: "var(--spacer-2)" }}>
           {showNewBankAccount ? (
-            <div style={{ display: "grid", gap: "var(--spacer-5)", gridAutoFlow: "column", gridAutoColumns: "1fr" }}>
+            <div className="grid gap-5 md:auto-cols-fr md:grid-flow-col">
               {user.country_code === "CA" ? (
                 <>
                   <fieldset className={cx({ danger: errorFieldNames.has("transit_number") })}>
diff --git a/app/javascript/components/server-components/AffiliatedPage.tsx b/app/javascript/components/server-components/AffiliatedPage.tsx
@@ -287,21 +287,21 @@ const AffiliatedPage = ({
       selectedTab="affiliated"
       title={isShowingGlobalAffiliates ? "Gumroad Affiliates" : undefined}
       ctaButton={
-        <>
-          <Search onSearch={handleSearch} value={state.query} />
-          {isShowingGlobalAffiliates ? (
-            <Button onClick={() => toggleOpen(false)}>
-              <Icon name="x-circle" />
-              Close
-            </Button>
-          ) : (
+        isShowingGlobalAffiliates ? (
+          <Button onClick={() => toggleOpen(false)}>
+            <Icon name="x-circle" />
+            Close
+          </Button>
+        ) : (
+          <>
+            {initialAffiliatedProducts.length > 0 && <Search onSearch={handleSearch} value={state.query} />}
             <WithTooltip position="bottom" tip={affiliatesDisabledReason}>
               <Button color="accent" disabled={affiliatesDisabledReason !== null} onClick={() => toggleOpen(true)}>
                 Gumroad affiliate
               </Button>
             </WithTooltip>
-          )}
-        </>
+          </>
+        )
       }
       archivedTabVisible={archivedTabVisible}
     >
diff --git a/app/javascript/components/server-components/CommunitiesPage/ChatMessageList.tsx b/app/javascript/components/server-components/CommunitiesPage/ChatMessageList.tsx
@@ -28,6 +28,8 @@ export const ChatMessageList = ({
   const dateObserversRef = React.useRef<Map<string, IntersectionObserver>>(new Map());
   const dateElementsRef = React.useRef<Map<string, HTMLDivElement>>(new Map());
 
+  const isSafari = typeof window !== "undefined" && /^((?!chrome|android).)*safari/iu.test(navigator.userAgent);
+
   const lastReadMessageCreatedAt = community.last_read_community_chat_message_created_at;
   let lastReadMessageIndex = -1;
   if (lastReadMessageCreatedAt) {
@@ -97,6 +99,11 @@ export const ChatMessageList = ({
         // Observer for the date group content visibility
         const groupObserver = new IntersectionObserver(([entry]) => {
           setVisibleDateGroups((prev) => {
+            // Safari has issues with rapid IntersectionObserver callbacks,
+            // causing the UI to jump around when scrolling.
+            // So we skip updating the visible date groups in Safari.
+            if (isSafari) return prev;
+
             if (entry?.isIntersecting && !prev.includes(date)) {
               return [...prev, date].sort();
             } else if (!entry?.isIntersecting && prev.includes(date)) {
diff --git a/app/javascript/components/server-components/DownloadPage/WithContent.tsx b/app/javascript/components/server-components/DownloadPage/WithContent.tsx
@@ -341,7 +341,7 @@ const WithContent = ({
           {isDesktop ? null : (
             <Popover
               aria-label="Table of Contents"
-              position="top"
+              position="bottom"
               trigger={
                 <div className="button">
                   <Icon name="unordered-list" />
diff --git a/app/javascript/components/server-components/FollowersPage.tsx b/app/javascript/components/server-components/FollowersPage.tsx
@@ -120,27 +120,29 @@ export const FollowersPage = ({ followers: initialFollowers, per_page, total }:
       title="Subscribers"
       actions={
         <>
-          <Popover
-            open={searchBoxOpen}
-            onToggle={setSearchBoxOpen}
-            aria-label="Search"
-            trigger={
-              <WithTooltip tip="Search" position="bottom">
-                <div className="button">
-                  <Icon name="solid-search" />
-                </div>
-              </WithTooltip>
-            }
-          >
-            <input
-              ref={searchInputRef}
-              value={searchQuery}
-              autoFocus
-              type="text"
-              placeholder="Search followers"
-              onChange={(evt) => setSearchQuery(evt.target.value)}
-            />
-          </Popover>
+          {(followers.length > 0 || searchQuery.length > 0) && (
+            <Popover
+              open={searchBoxOpen}
+              onToggle={setSearchBoxOpen}
+              aria-label="Search"
+              trigger={
+                <WithTooltip tip="Search" position="bottom">
+                  <div className="button">
+                    <Icon name="solid-search" />
+                  </div>
+                </WithTooltip>
+              }
+            >
+              <input
+                ref={searchInputRef}
+                value={searchQuery}
+                autoFocus
+                type="text"
+                placeholder="Search followers"
+                onChange={(evt) => setSearchQuery(evt.target.value)}
+              />
+            </Popover>
+          )}
           <Popover
             aria-label="Export"
             trigger={
diff --git a/app/views/help_center/articles/contents/_101-designing-your-product-page.html.erb b/app/views/help_center/articles/contents/_101-designing-your-product-page.html.erb
@@ -21,7 +21,7 @@
     <figure><%= image_tag "https://d33v4339jhl8k0.cloudfront.net/docs/assets/5c4657ad2c7d3a66e32d763f/images/64248bcc4cd1ab01bbe8b082/file-qFRruuIBdB.png" %></figure>
     <p>The custom field info will be accessible in the <a href="https://www.gumroad.com/customers">Sales tab</a> and the <a href="74-the-analytics-dashboard#sales-csv">sales CSV</a>.</p>
     <h3 id="More-like-this-recommendations-5J9b1">Recommend related products</h3>
-    <p>Our <a href="334-more-like-this">Recommend related products</a> feature allows you to recommend other products from your store, products you're an affiliate of, or all of the products found on <a href="https://gumroad.com/discover">Gumroad Discover</a>!</p>p>
+    <p>Our <a href="334-more-like-this">Recommend related products</a> feature allows you to recommend other products from your store, products you're an affiliate of, or all of the products found on <a href="https://gumroad.com/discover">Gumroad Discover</a>!</p>
     <figure><%= image_tag "https://d33v4339jhl8k0.cloudfront.net/docs/assets/5c4657ad2c7d3a66e32d763f/images/65c3046b0a12eb325db176e7/file-mgZ6SnjBz9.png" %></figure>
     <h3 id="Creating-an-Upsell-PYDkp">Creating an Upsell</h3>
     <p>Upsells allow you to suggest additional products to your customers at checkout. You can either nudge them to purchase an upgraded version, replace the product with another one, or add an extra product to the cart. </p>
diff --git a/app/views/help_center/articles/contents/_131-using-workflows-to-send-automated-updates.html.erb b/app/views/help_center/articles/contents/_131-using-workflows-to-send-automated-updates.html.erb
@@ -59,7 +59,7 @@
     <figure><%= image_tag "https://d33v4339jhl8k0.cloudfront.net/docs/assets/5c4657ad2c7d3a66e32d763f/images/664b407972987f726dc81b5e/file-zEj6Ze1xcY.jpg" %></figure>
     <p>We do not send a duplicate card abandonment email every 24 hours if the customer’s cart remains abandoned.</p>
     <h3 id="Testing-your-workflow-z6ml8">Testing your workflow</h3>
-    <p>You can't test a workflow as part of a <a href="62-testing-a-purchase">test purchase</a>. As a test purchase isn't a real transaction, the workflow won't be triggered.</p>p>
+    <p>You can't test a workflow as part of a <a href="62-testing-a-purchase">test purchase</a>. As a test purchase isn't a real transaction, the workflow won't be triggered.</p>
     <p>Instead, you can test the workflow by creating a 100% <a href="128-discount-codes">Discount Code</a> and purchasing using another email address.</p>
     <h3 id="Your-audiences-experience-ZpRZS">Your audience's experience</h3>
     <p>Your audience will receive workflows as emails with links to any files you've attached.</p>
diff --git a/app/views/help_center/articles/contents/_133-pay-what-you-want-pricing.html.erb b/app/views/help_center/articles/contents/_133-pay-what-you-want-pricing.html.erb
@@ -17,6 +17,6 @@
       <li>You can use our PWYW feature and set a price of $0+ for your products, allowing customers to enter “0" for the price and access your product for free. </li>
       <li>You can send customers a 100% off <a href="128-discount-codes">discount code</a>. </li>
     </ol>
-    <p><b>Note</b>: You cannot price a product at $0 without the PWYW feature, and they have a lower <a href="289-file-size-limits-on-gumroad">file-size limit</a>. We also don't take any <a href="66-gumroads-fees">fee</a> on free product sales.</p>p>
+    <p><b>Note</b>: You cannot price a product at $0 without the PWYW feature, and they have a lower <a href="289-file-size-limits-on-gumroad">file-size limit</a>. We also don't take any <a href="66-gumroads-fees">fee</a> on free product sales.</p>
   </div>
 </div>
diff --git a/app/views/help_center/articles/contents/_149-adding-a-product.html.erb b/app/views/help_center/articles/contents/_149-adding-a-product.html.erb
@@ -25,7 +25,7 @@
     <p>You can also sell recurring charge <a href="82-membership-products" target="_self">memberships</a>, a <a href="339-product-bundles" target="_self">bundle</a> of multiple existing products, and <a href="70-can-i-sell-services" target="_self">service-type products</a>.</p>
     <figure><%= image_tag "help_center/creating-tab.png" %></figure>
     <h3 id="set-price">Set a price</h3>
-    <p>Products can be <a href="133-pay-what-you-want-pricing#Create-a-free-product-EV4ZH">free</a> or as much as USD 5,000. You can also let customers <a href="133-pay-what-you-want-pricing">pay whatever they want</a> by adding a '+' to a product's minimum price, like "$5+".</p>p>
+    <p>Products can be <a href="133-pay-what-you-want-pricing#Create-a-free-product-EV4ZH">free</a> or as much as USD 5,000. You can also let customers <a href="133-pay-what-you-want-pricing">pay whatever they want</a> by adding a '+' to a product's minimum price, like "$5+".</p>
     <p>Click the currency sign to select from the display currency options. For most products, you can change the display currency later, except for membership and bundle-type products which cannot be changed once created. Regardless of the display currency, please note that <a href="46-what-currency-does-gumroad-use">all charges are processed in USD.</a></p>
     <h3 id="describe">Describe your product</h3>
     <p>Describe your product and style it inline. You can even add images, quotes, code blocks, or embed videos and even media players!</p>
diff --git a/app/views/help_center/articles/contents/_190-how-do-i-get-a-refund.html.erb b/app/views/help_center/articles/contents/_190-how-do-i-get-a-refund.html.erb
@@ -17,7 +17,7 @@
     <p>or by looking at the "reply-to" information on your purchase email</p>
     <h3></h3>
     <figure><%= image_tag "https://d33v4339jhl8k0.cloudfront.net/docs/assets/5c4657ad2c7d3a66e32d763f/images/61fb919bd86136157d9a05c5/file-kV4glDwBbx.png" %></figure>
-    <p>If you didn't receive a receipt, please first check the spam folder in your email inbox. If you still cannot find your receipt, please go through the steps <a href="212-i-never-received-a-receipt" target="_self">on this page</a>.</p>p>
+    <p>If you didn't receive a receipt, please first check the spam folder in your email inbox. If you still cannot find your receipt, please go through the steps <a href="212-i-never-received-a-receipt" target="_self">on this page</a>.</p>
     <br>
     <h3 id="In-App-Purchases-GL6fX">In-App purchases</h3>
     <p>Refunds for in-app purchases are handled independently by Apple/Google support, so if you made a purchase on the <a href="177-the-gumroad-dashboard-app#Download-the-app-a0fEa">Gumroad mobile app</a>, neither the creator nor Gumroad can refund your purchase.</p>
diff --git a/app/views/help_center/articles/contents/_216-delete-credit-card-information.html.erb b/app/views/help_center/articles/contents/_216-delete-credit-card-information.html.erb
@@ -2,7 +2,7 @@
 <div class="scoped-tailwind-preflight help-center-article">
   <div>
     <p>You can remove your saved credit card or PayPal account from the bottom of the <a href="https://gumroad.com/settings/payments">payment settings</a> page.</p>
-    <p><b>Note:</b> You cannot delete your saved payment information if there's an active <a href="278-guide-to-memberships">membership</a> on it. To do so, you must first cancel your membership and wait for the billed period to complete.</p>p>
+    <p><b>Note:</b> You cannot delete your saved payment information if there's an active <a href="278-guide-to-memberships">membership</a> on it. To do so, you must first cancel your membership and wait for the billed period to complete.</p>
     <figure><%= image_tag "https://d33v4339jhl8k0.cloudfront.net/docs/assets/5c4657ad2c7d3a66e32d763f/images/64c09ddc57a4e8315e721e19/file-nbVxZc5hmP.png" %></figure>
   </div>
   <div>
diff --git a/app/views/help_center/articles/contents/_252-multiple-accounts.html.erb b/app/views/help_center/articles/contents/_252-multiple-accounts.html.erb
@@ -42,7 +42,7 @@
     <h3 id="Transferring-ownership-of-account-fk2W3">Transferring ownership of account</h3>
     <p>To transfer ownership of your Gumroad account:</p>
     <ol>
-      <li>The current owner will need to change the account’s email address to the new owner's email address from the <a href="https://gumroad.com/settings%5C">settings</a>.</li>
+      <li>The current owner will need to change the account’s email address to the new owner's email address from the <a href="https://gumroad.com/settings">settings</a>.</li>
       <li>The new owner will need to update the <a href="https://gumroad.com/settings/payments">payments settings</a> to their own. This includes updating the compliance and PayPal or bank account information. Changing the account’s country may require you to forfeit your existing balance.</li>
     </ol>
     <p>Please remember that all the products, followers, and sales data will remain intact during this process.</p>
diff --git a/app/views/help_center/articles/contents/_283-fraudulent-purchases.html.erb b/app/views/help_center/articles/contents/_283-fraudulent-purchases.html.erb
@@ -49,7 +49,7 @@
     <p>When this happens, please notify us or have your customer notify us. We can then unblock them from buying, and clear that card for future use on the platform. We do not have the ability to "un-refund" a charge, unfortunately, so the customer will have to re-purchase the product they've bought. </p>
     <h3 id="Can-I-block-customers-on-my-own--I3Xch">Can I block customers on my own? </h3>
     <p>Yes!</p>
-    <p>Using our <a href="329-customer-moderation">Customer Moderation tools</a>, you can block customers from purchasing your products. You can also revoke access to their content if you've noticed a customer distributing your content illegally or otherwise violating your terms.</p>p>
+    <p>Using our <a href="329-customer-moderation">Customer Moderation tools</a>, you can block customers from purchasing your products. You can also revoke access to their content if you've noticed a customer distributing your content illegally or otherwise violating your terms.</p>
   </div>
   <div>
     <h3>Related Articles</h3>
diff --git a/app/views/help_center/articles/contents/_286-how-do-i-report-a-gumroad-creator.html.erb b/app/views/help_center/articles/contents/_286-how-do-i-report-a-gumroad-creator.html.erb
@@ -18,6 +18,6 @@
     <p>Please fill out this free template and email it to us. We will forward it to the infringing party and take the necessary steps to comply.</p>
     <p>You can also learn more about DMCA takedown notices <a href="https://theartistsjd.com/dmca-takedown-notice/">here</a> and protecting your privacy <a href="https://www.plagiarismtoday.com/2014/08/19/5-tricks-protecting-privacy-sending-copyright-notices/">here</a>.</p>
     <h3>Here's what to expect after filing a report</h3>
-    <p>Once you fill out the form, a staff member will review the product in question and determine whether or not it is in violation of the <a href="155-things-you-cant-sell-on-gumroad" target="_blank">Gumroad Terms of Service</a>. The first violation will result in the product being removed from Gumroad and the user's account will remain open. After the second violation, the user will be given a two-weeks notice before their account is deleted.</p>p>
+    <p>Once you fill out the form, a staff member will review the product in question and determine whether or not it is in violation of the <a href="155-things-you-cant-sell-on-gumroad" target="_blank">Gumroad Terms of Service</a>. The first violation will result in the product being removed from Gumroad and the user's account will remain open. After the second violation, the user will be given a two-weeks notice before their account is deleted.</p>
   </div>
 </div>
diff --git a/app/views/help_center/articles/contents/_330-stripe-connect.html.erb b/app/views/help_center/articles/contents/_330-stripe-connect.html.erb
@@ -27,7 +27,7 @@
     <p>You can control your payout bank, currency, and schedule from your Stripe account.</p>
     <p>You will also be able to customize the charge description that customers see on their bank statements. It is important to use a recognizable name that will not lead to unintended disputes. More on that <a href="https://support.stripe.com/questions/update-business-name-shown-on-customer-bank-statements">here</a>.</p>
     <h3 id="refunds">Issue refunds</h3>
-    <p>You can <a href="47-how-to-refund-a-customer">refund customers</a> either from the sales dashboard or from your Stripe account, and the amount will be deducted from your connected account's balance.</p>p>
+    <p>You can <a href="47-how-to-refund-a-customer">refund customers</a> either from the sales dashboard or from your Stripe account, and the amount will be deducted from your connected account's balance.</p>
     <p>Due to certain API restrictions, if a customer claims a VAT/GST refund with a valid tax ID, part of the refund will be deducted from the connected Stripe account’s balance. To compensate for that, we will auto-credit the same amount to your Gumroad balance that gets paid weekly.</p>
     <h3 id="disputes">Manage disputes</h3>
     <p>Stripe Connect gives you greater control over fighting disputes (aka chargebacks). Once connected, Gumroad will no longer fight disputes on your behalf. Instead, you can respond and submit evidence via <a href="https://support.stripe.com/topics/disputes">Stripe’s dispute resolution process</a>. </p>
diff --git a/app/views/help_center/articles/contents/_331-creating-upsells.html.erb b/app/views/help_center/articles/contents/_331-creating-upsells.html.erb
@@ -23,7 +23,7 @@
       </li>
     </ol>
     <h3>The customer’s experience</h3>
-    <p>When the customer proceeds to checkout, after entering their payment information and pressing Pay, we'll present them with your upsell. You can try this for yourself by <a href="62-testing-a-purchase">testing a purchase</a>.</p>p>
+    <p>When the customer proceeds to checkout, after entering their payment information and pressing Pay, we'll present them with your upsell. You can try this for yourself by <a href="62-testing-a-purchase">testing a purchase</a>.</p>
   </div>
   <div>
     <h3>Related Articles</h3>
diff --git a/app/views/help_center/articles/contents/_341-collaborations.html.erb b/app/views/help_center/articles/contents/_341-collaborations.html.erb
@@ -23,7 +23,7 @@
     <p>Users can visit their <a href="https://gumroad.com/products/collabs">Collabs dashboard</a> to see all collaborated products, the cut for each, and the total revenue generated. They can edit products here as well.</p>
     <figure><%= image_tag "https://d33v4339jhl8k0.cloudfront.net/docs/assets/5c4657ad2c7d3a66e32d763f/images/6604f27b753f7a6540164ddf/file-ZkoP3LeIxo.png" %></figure>
     <h3>What happens after a purchase?</h3>
-    <p>At the time of sale, the collaborator's portion is added to their Gumroad balance and is paid out the same way as <a href="13-getting-paid">all other Gumroad creators and affiliates.</a> </p>p>
+    <p>At the time of sale, the collaborator's portion is added to their Gumroad balance and is paid out the same way as <a href="13-getting-paid">all other Gumroad creators and affiliates.</a> </p>
     <h3>Editing/Deleting a collaborator</h3>
     <p>You can edit or delete a collaborator from the collaborator dashboard. Anytime there is an update or deletion, we will send an email to the collaborator, notifying them of the changes. </p>
     <p style="text-align: center;" class="align-center"><%= image_tag "https://d33v4339jhl8k0.cloudfront.net/docs/assets/5c4657ad2c7d3a66e32d763f/images/65d6b6e96d2feb00a37ec6f4/file-t5ewcUdxlf.png" %></p>
diff --git a/app/views/help_center/articles/contents/_64-is-gumroad-for-me.html.erb b/app/views/help_center/articles/contents/_64-is-gumroad-for-me.html.erb
diff --git a/app/views/help_center/articles/contents/_82-membership-products.html.erb b/app/views/help_center/articles/contents/_82-membership-products.html.erb
diff --git a/app/views/home/features.html.erb b/app/views/home/features.html.erb
diff --git a/spec/requests/help_center_spec.rb b/spec/requests/help_center_spec.rb
